Skip to content

Commit 4380099

Browse files
Fix test issues in lib
1 parent d7e336e commit 4380099

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

__tests__/__snapshots__/index.js.snap

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -303,6 +303,7 @@ Object {
303303
"SUBMISSION_END_DATE": "submissionEndDate",
304304
},
305305
"default": undefined,
306+
"getFilterUrl": [Function],
306307
"getService": [Function],
307308
"normalizeChallenge": [Function],
308309
},
@@ -372,9 +373,9 @@ Object {
372373
},
373374
"tc": Object {
374375
"COMPETITION_TRACKS": Object {
375-
"DATA_SCIENCE": "Data Science",
376-
"DESIGN": "Design",
377-
"DEVELOP": "Development",
376+
"DES": "Design",
377+
"DEV": "Development",
378+
"DS": "Data Science",
378379
"QA": "Quality Assurance",
379380
},
380381
"REVIEW_OPPORTUNITY_TYPES": Object {

src/services/challenges.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@ export function getFilterUrl(backendFilter, frontFilter) {
2323
delete ff.types;
2424
delete ff.communityId;
2525

26-
console.log(ff);
26+
// console.log(ff);
2727

2828
let urlFilter = qs.stringify(_.reduce(ff, (result, value, key) => {
2929
// eslint-disable-next-line no-param-reassign
3030
if (value) result[key] = value;
3131
return result;
3232
}, {}));
33-
console.log(urlFilter);
33+
// console.log(urlFilter);
3434

3535
const ftags = _.map(tags, val => `tags[]=${val}`).join('&');
3636
const ftracks = _.map(_.reduce(tracks, (result, value, key) => {
@@ -165,10 +165,10 @@ class ChallengesService {
165165
endpoint,
166166
filter,
167167
) => {
168-
console.log(filter);
168+
// console.log(filter);
169169
const query = getFilterUrl(filter.backendFilter, filter.frontFilter);
170170
const url = `${endpoint}?${query}`;
171-
console.log(url);
171+
// console.log(url);
172172
const res = await this.private.apiV5.get(url).then(checkErrorV5);
173173
return {
174174
challenges: res.result || [],

src/utils/challenge/filter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ export function getFilterFunction(state) {
238238
* @param {Object} state
239239
* @return {Function}
240240
*/
241-
export function getReviewOpportunitiesFilterFunction(state, validTypes) {
241+
export function getReviewOpportunitiesFilterFunction(state) {
242242
return (opp) => {
243243
const trackAbbr = {
244244
DATA_SCIENCE: 'DS',
@@ -280,7 +280,7 @@ export function getReviewOpportunitiesFilterFunction(state, validTypes) {
280280
filterByTrack(challenge, state)
281281
&& filterByText(challenge, state)
282282
&& filterByTags(challenge, state)
283-
// && filterByTypes(challenge, state)
283+
&& filterByTypes(challenge, state)
284284
&& filterByEndDate(challenge, state)
285285
&& filterByStartDate(challenge, state)
286286
&& filterByReviewOpportunityType(opp, state)

0 commit comments

Comments
 (0)