Merge pull request #247 from topcoder-platform/milestone-v1.3

Milestone-v1.3

Author: sushilshinde

.circleci/config.yml

@@ -28,7 +28,7 @@ jobs:
       - attach_workspace:
           at: .
       - run: echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" >> ~/.npmrc
-      - run: npm publish
+      - run: npm publish --tag test-release
 # dont change anything
 workflows:
   version: 2

package.json

@@ -31,7 +31,7 @@
     "lint:js": "./node_modules/.bin/eslint --ext .js,.jsx .",
     "test": "npm run lint && npm run jest"
   },
-  "version": "1.0.3",
+  "version": "1000.22.2",
   "dependencies": {
     "auth0-js": "^6.8.4",
     "config": "^3.2.0",

src/services/terms.js

@@ -31,18 +31,14 @@ class TermsService {
    * @return {Promise}       promise of the request result
    */
   async getChallengeTerms(terms) {
-    if (this.private.tokenV3) {
-      const challengeService = getChallengeService(this.private.tokenV3);
-      const roleId = await challengeService.getRoleId('Submitter');
-      const registerTerms = _.filter(terms, t => t.roleId === roleId);
-
-      return Promise.all(_.map(registerTerms, term => this.getTermDetails(term.id)))
-        .then(challengeTerms => (
-          _.map(challengeTerms, term => _.pick(term, 'id', 'title', 'agreed'))
-        ));
-    }
-
-    return [];
+    const challengeService = getChallengeService(this.private.tokenV3);
+    const roleId = await challengeService.getRoleId('Submitter');
+    const registerTerms = _.filter(terms, t => t.roleId === roleId);
+
+    return Promise.all(_.map(registerTerms, term => this.getTermDetails(term.id)))
+      .then(challengeTerms => (
+        _.map(challengeTerms, term => _.pick(term, 'id', 'title', 'agreed'))
+      ));
   }
 
   /**