Terms API part2 challenge output

Resource terms
CRUDL endpoints

Author: gondzo

ReadMe.md

@@ -55,13 +55,14 @@ run `npm run test` under docusign_callback folder
 - Install dependencies `npm install`
 - Run lint `npm run lint`
 - Run lint fix `npm run lint:fix`
-- Start app `npm start`
-- App is running at `http://localhost:3000`
+- Setup process environment `source env.sh`
 - Clear and init db `npm run init-db`
 - Insert test data `npm run test-data`
+- Start app `npm start`
+- App is running at `http://localhost:3000`
 
 ## Testing
-#### You need to `stop` the app before running unit or e2e tests.
+#### You need to `stop` the app and run command `source env.sh` before running unit or e2e tests.
 - Run `npm run test` to execute unit tests and generate coverage report.
 - RUN `npm run e2e` to execute e2e tests and generate coverage report.
 

app-bootstrap.js

@@ -5,5 +5,8 @@
 global.Promise = require('bluebird')
 const Joi = require('joi')
 
-Joi.numberId = () => Joi.number().integer().min(1).max(2147483647).required()
+Joi.optionalNumberId = () => Joi.number().integer().min(1).max(2147483647)
+Joi.numberId = () => Joi.optionalNumberId().required()
 Joi.uuid = () => Joi.string().uuid().required()
+Joi.page = () => Joi.number().integer().min(1).default(1)
+Joi.perPage = () => Joi.number().integer().min(1).max(100).default(20)

app-constants.js

@@ -72,9 +72,14 @@ const Templates = [{
   handlers: []
 }]
 
+const UserRoles = {
+  Admin: 'Administrator'
+}
+
 module.exports = {
   Templates,
   AGREE_FOR_DOCUSIGN_TEMPLATE: 4,
   ELECT_AGREEABLE: 'Electronically-agreeable',
-  TEMPLATE_ID_INVALID: 'TEMPLATE_ID_INVALID'
+  TEMPLATE_ID_INVALID: 'TEMPLATE_ID_INVALID',
+  UserRoles
 }

app-routes.js

@@ -44,6 +44,10 @@ module.exports = (app) => {
           if (def.auth || (def.optionalAuth && req.headers.authorization)) {
             if (req.authUser.isMachine) {
               next(new errors.ForbiddenError('M2M token is not supported'))
+            } else {
+              if (def.access && (!req.authUser.roles || !helper.checkIfExists(def.access, req.authUser.roles))) {
+                next(new errors.ForbiddenError('You are not allowed to perform this action!'))
+              }
             }
           }
           next()

app.js

@@ -14,7 +14,6 @@ const logger = require('./src/common/logger')
 const interceptor = require('express-interceptor')
 const healthcheck = require('topcoder-healthcheck-dropin')
 
-
 // setup express app
 const app = express()
 
@@ -53,7 +52,7 @@ app.use(interceptor((req, res) => {
 // check if api is started
 // TODO: check db connection, docusign callback
 function check () {
-  return true;
+  return true
 }
 
 app.use(healthcheck.middleware([check]))

build.sh

@@ -7,9 +7,10 @@ module.exports = {
   PORT: process.env.PORT || 3000,
 
   AUTH_SECRET: process.env.AUTH_SECRET || 'mysecret',
-  VALID_ISSUERS: process.env.VALID_ISSUERS || '["https://api.topcoder-dev.com", "https://api.topcoder.com", "https://topcoder-dev.auth0.com/"]',
+  VALID_ISSUERS: process.env.VALID_ISSUERS || '["https://api.topcoder-dev.com", "https://api.topcoder.com", "https://topcoder-dev.auth0.com"]',
 
   POSTGRES_URL: process.env.POSTGRES_URL || 'postgres://postgres:password@localhost:5432/postgres',
+  DB_SCHEMA_NAME: process.env.DB_SCHEMA_NAME || 'termsdb',
 
   AUTH0_URL: process.env.AUTH0_URL,
   AUTH0_AUDIENCE: process.env.AUTH0_AUDIENCE || 'https://m2m.topcoder-dev.com/',

config/default.js

@@ -5,6 +5,6 @@
 module.exports = {
   WAIT_TIME: 1500,
   DOCUSIGN: {
-    ASSIGNMENT_TERMS_OF_USE_ID: process.env.ASSIGNMENT_TERMS_OF_USE_ID || 20754
+    ASSIGNMENT_TERMS_OF_USE_ID: 20754
   }
 }