From a9322fe75a4648f55607f59bf1524521ec0fe689 Mon Sep 17 00:00:00 2001
From: "Deddy Syefria (deedee)" <dsyefria@gmail.com>
Date: Wed, 4 Mar 2020 10:38:19 +0700
Subject: [PATCH 1/3] use submission api v5 to download submission

---
 conf/OnlineReview.xml                         |   3 +
 lib                                           |   2 +-
 .../BaseProjectDetailsAction.java             |  80 ++++----
 .../onlinereview/util/ActionsHelper.java      | 174 +++++++++++++-----
 .../onlinereview/util/ConfigHelper.java       |  10 +
 token.properties.example                      |   3 +-
 6 files changed, 170 insertions(+), 102 deletions(-)

diff --git a/conf/OnlineReview.xml b/conf/OnlineReview.xml
index ee81772b45..0573a4f30c 100644
--- a/conf/OnlineReview.xml
+++ b/conf/OnlineReview.xml
@@ -5311,6 +5311,9 @@
                 <Value>@aws_s3_bucket_dmz@</Value>
             </Property>
         </Property>
+        <Property name="submission_api">
+            <Value>@submission_api_endpoint@</Value>
+        </Property>
     </Config>
 
     <!--
diff --git a/lib b/lib
index 18b3f1c1bf..e81bce8012 160000
--- a/lib
+++ b/lib
@@ -1 +1 @@
-Subproject commit 18b3f1c1bf6f49595db16238766361e5b9b8f816
+Subproject commit e81bce80125b50861dcc551ef140e73ca2f67c91
diff --git a/src/java/main/com/cronos/onlinereview/actions/projectdetails/BaseProjectDetailsAction.java b/src/java/main/com/cronos/onlinereview/actions/projectdetails/BaseProjectDetailsAction.java
index c4d8b7e4fe..6c7de3d3d4 100644
--- a/src/java/main/com/cronos/onlinereview/actions/projectdetails/BaseProjectDetailsAction.java
+++ b/src/java/main/com/cronos/onlinereview/actions/projectdetails/BaseProjectDetailsAction.java
@@ -3,27 +3,6 @@
  */
 package com.cronos.onlinereview.actions.projectdetails;
 
-import java.io.BufferedReader;
-import java.io.Closeable;
-import java.io.DataOutputStream;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.InputStreamReader;
-import java.io.OutputStream;
-import java.net.HttpURLConnection;
-import java.net.MalformedURLException;
-import java.net.URL;
-import java.text.MessageFormat;
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-
-import com.amazonaws.services.s3.AmazonS3URI;
-
 import com.cronos.onlinereview.Constants;
 import com.cronos.onlinereview.actions.DynamicModelDrivenAction;
 import com.cronos.onlinereview.actions.event.EventBusServiceClient;
@@ -36,11 +15,7 @@
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.node.ObjectNode;
-import com.topcoder.management.deliverable.Submission;
-import com.topcoder.management.deliverable.SubmissionStatus;
-import com.topcoder.management.deliverable.Upload;
-import com.topcoder.management.deliverable.UploadManager;
-import com.topcoder.management.deliverable.UploadStatus;
+import com.topcoder.management.deliverable.*;
 import com.topcoder.management.deliverable.persistence.UploadPersistenceException;
 import com.topcoder.management.deliverable.search.SubmissionFilterBuilder;
 import com.topcoder.management.project.Project;
@@ -57,23 +32,28 @@
 import com.topcoder.search.builder.filter.AndFilter;
 import com.topcoder.search.builder.filter.EqualToFilter;
 import com.topcoder.search.builder.filter.Filter;
-import com.topcoder.servlet.request.ConfigurationException;
-import com.topcoder.servlet.request.DisallowedDirectoryException;
-import com.topcoder.servlet.request.FileDoesNotExistException;
-import com.topcoder.servlet.request.FileUpload;
-import com.topcoder.servlet.request.FileUploadResult;
-import com.topcoder.servlet.request.PersistenceException;
-import com.topcoder.servlet.request.UploadedFile;
+import com.topcoder.servlet.request.*;
 import com.topcoder.util.config.ConfigManagerException;
 import com.topcoder.util.errorhandling.BaseException;
 import com.topcoder.util.file.DocumentGenerator;
 import com.topcoder.util.file.Template;
-import com.topcoder.util.file.fieldconfig.Condition;
 import com.topcoder.util.file.fieldconfig.Field;
 import com.topcoder.util.file.fieldconfig.Node;
 import com.topcoder.util.file.fieldconfig.TemplateFields;
 import com.topcoder.util.file.templatesource.FileTemplateSource;
 
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import java.io.*;
+import java.net.HttpURLConnection;
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.text.MessageFormat;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
 /**
  * This is the base class for project details actions classes. It provides the
  * basic functions which will be used by all project detail actions.
@@ -200,7 +180,7 @@ protected CorrectnessCheckResult checkForCorrectUploadId(HttpServletRequest requ
     protected void processSubmissionDownload(Upload upload, HttpServletRequest request, HttpServletResponse response)
             throws UploadPersistenceException, SearchBuilderException, DisallowedDirectoryException,
             ConfigurationException, PersistenceException, FileDoesNotExistException, IOException,
-            ResourcePersistenceException {
+            ResourcePersistenceException, BaseException {
 
         // At this point, redirect-after-login attribute should be removed (if it
         // exists)
@@ -240,20 +220,22 @@ protected void processSubmissionDownload(Upload upload, HttpServletRequest reque
 
             outputDownloadedFile(uploadedFile, contentDisposition, response);
         } else {
-            AmazonS3URI s3Uri = ActionsHelper.isS3Url(upload.getUrl());
-            if (s3Uri == null) {
-                response.sendRedirect(upload.getUrl());
-            } else {
-                String key = s3Uri.getKey();
-                String contentDisposition;
-                if (submission != null) {
-                    contentDisposition = "attachment; filename=\"submission-" + submission.getId() + "-" + key + "\"";
-                } else {
-                    contentDisposition = "attachment; filename=\"upload-" + upload.getId() + "-" + key + "\"";
-                }
-
-                ActionsHelper.outputDownloadS3File(upload.getUrl(), key, contentDisposition, response);
-            }
+//            AmazonS3URI s3Uri = ActionsHelper.isS3Url(upload.getUrl());
+//            if (s3Uri == null) {
+//                response.sendRedirect(upload.getUrl());
+//            } else {
+//                String key = s3Uri.getKey();
+//                String contentDisposition;
+//                if (submission != null) {
+//                    contentDisposition = "attachment; filename=\"submission-" + submission.getId() + "-" + key + "\"";
+//                } else {
+//                    contentDisposition = "attachment; filename=\"upload-" + upload.getId() + "-" + key + "\"";
+//                }
+//
+//                ActionsHelper.outputDownloadS3File(upload.getUrl(), key, contentDisposition, response);
+//            }
+           // HttpResponse submissionFromApi = ActionsHelper.downloadSubmissionFromApi(submission.getId());
+            ActionsHelper.outputDownloadFromSubmissionApi(submission.getId(), response);
         }
     }
 
diff --git a/src/java/main/com/cronos/onlinereview/util/ActionsHelper.java b/src/java/main/com/cronos/onlinereview/util/ActionsHelper.java
index 5ad9a5c80a..1342348c41 100644
--- a/src/java/main/com/cronos/onlinereview/util/ActionsHelper.java
+++ b/src/java/main/com/cronos/onlinereview/util/ActionsHelper.java
@@ -3,46 +3,11 @@
  */
 package com.cronos.onlinereview.util;
 
-import java.io.File;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.OutputStream;
-import java.math.BigDecimal;
-import java.math.MathContext;
-import java.net.URL;
-import java.rmi.RemoteException;
-import java.sql.Connection;
-import java.sql.PreparedStatement;
-import java.sql.ResultSet;
-import java.sql.SQLException;
-import java.sql.Statement;
-import java.sql.Types;
-import java.text.Format;
-import java.text.SimpleDateFormat;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Calendar;
-import java.util.Collection;
-import java.util.Date;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
-
 import com.amazonaws.auth.PropertiesCredentials;
 import com.amazonaws.services.s3.AmazonS3Client;
-import com.amazonaws.services.s3.model.AmazonS3Exception;
+import com.amazonaws.services.s3.AmazonS3URI;
 import com.amazonaws.services.s3.model.GetObjectRequest;
 import com.amazonaws.services.s3.model.S3Object;
-import com.amazonaws.services.s3.AmazonS3URI;
-
-import javax.ejb.CreateException;
-import javax.naming.Context;
-import javax.naming.NamingException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-
 import com.cronos.onlinereview.Constants;
 import com.cronos.onlinereview.dataaccess.ProjectDataAccess;
 import com.cronos.onlinereview.dataaccess.ResourceDataAccess;
@@ -58,21 +23,15 @@
 import com.cronos.termsofuse.dao.ProjectTermsOfUseDao;
 import com.cronos.termsofuse.dao.TermsOfUseDao;
 import com.cronos.termsofuse.dao.UserTermsOfUseDao;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
 import com.opensymphony.xwork2.ActionContext;
 import com.opensymphony.xwork2.ActionSupport;
 import com.opensymphony.xwork2.TextProvider;
 import com.topcoder.date.workdays.DefaultWorkdaysFactory;
 import com.topcoder.date.workdays.Workdays;
-import com.topcoder.db.connectionfactory.ConfigurationException;
-import com.topcoder.db.connectionfactory.DBConnectionException;
-import com.topcoder.db.connectionfactory.DBConnectionFactory;
-import com.topcoder.db.connectionfactory.DBConnectionFactoryImpl;
-import com.topcoder.db.connectionfactory.UnknownConnectionException;
-import com.topcoder.management.deliverable.Deliverable;
-import com.topcoder.management.deliverable.DeliverableManager;
-import com.topcoder.management.deliverable.Submission;
-import com.topcoder.management.deliverable.Upload;
-import com.topcoder.management.deliverable.UploadManager;
+import com.topcoder.db.connectionfactory.*;
+import com.topcoder.management.deliverable.*;
 import com.topcoder.management.deliverable.late.LateDeliverable;
 import com.topcoder.management.deliverable.late.LateDeliverableManager;
 import com.topcoder.management.deliverable.persistence.DeliverableCheckingException;
@@ -113,11 +72,7 @@
 import com.topcoder.project.phases.template.StartDateGenerator;
 import com.topcoder.project.phases.template.persistence.XmlPhaseTemplatePersistence;
 import com.topcoder.search.builder.SearchBuilderException;
-import com.topcoder.search.builder.filter.AndFilter;
-import com.topcoder.search.builder.filter.EqualToFilter;
-import com.topcoder.search.builder.filter.Filter;
-import com.topcoder.search.builder.filter.NotFilter;
-import com.topcoder.search.builder.filter.OrFilter;
+import com.topcoder.search.builder.filter.*;
 import com.topcoder.servlet.request.DisallowedDirectoryException;
 import com.topcoder.servlet.request.FileUpload;
 import com.topcoder.servlet.request.LocalFileUpload;
@@ -131,6 +86,33 @@
 import com.topcoder.web.common.throttle.Throttle;
 import com.topcoder.web.ejb.forums.Forums;
 import com.topcoder.web.ejb.forums.ForumsHome;
+import org.apache.http.HttpEntity;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpResponse;
+import org.apache.http.HttpStatus;
+import org.apache.http.client.methods.HttpGet;
+import org.apache.http.impl.client.DefaultHttpClient;
+
+import javax.ejb.CreateException;
+import javax.naming.Context;
+import javax.naming.NamingException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.net.URI;
+import java.net.URL;
+import java.rmi.RemoteException;
+import java.sql.*;
+import java.text.Format;
+import java.text.SimpleDateFormat;
+import java.util.Date;
+import java.util.*;
+
 
 /**
  * <p>
@@ -242,6 +224,23 @@ public class ActionsHelper {
      */
     private static final String s3BucketDmz;
 
+    /**
+     * Submission Api endpoint
+     */
+    private static final String submissionApiUrl;
+
+    /**
+     * Submission api get submission
+     */
+    private static final String GET_SUBMISSION_ENDPOINT = "%s/submissions?legacySubmissionId=%s";
+
+    /**
+     * Submission Api download submission
+     */
+    private static final String GET_DOWNLOAD_ENDPOINT = "%s/submissions/%s/download";
+
+    protected static final ObjectMapper objectMapper = new ObjectMapper();
+
     static {
         try {
             ClassLoader loader = ActionsHelper.class.getClassLoader();
@@ -250,11 +249,14 @@ public class ActionsHelper {
             s3BucketDmz = ConfigHelper.getS3BucketDmz();
             presignedExpireMillis = ConfigHelper.getPreSignedExpTimeMilis();
             s3Client = new AmazonS3Client(new PropertiesCredentials(new File(credentialURL.getFile())));
+            String sUrl = ConfigHelper.getSubmissionApiEndpoint().trim();
+            submissionApiUrl = sUrl.endsWith("/") ? sUrl.substring(0, sUrl.length() -1 ) : sUrl;
         } catch (Throwable e) {
             throw new RuntimeException("Failed load to Amazon S3 CLient", e);
         }
     }
 
+
     /**
      * This constructor is declared private to prohibit instantiation of the
      * <code>ActionsHelper</code> class.
@@ -3878,4 +3880,74 @@ public static String createStudioLocalFilePath(long projectId, long userId, Stri
         buf.append(parameter);
         return buf.toString();
     }
+
+    /**
+     * Get submission from external API
+     *
+     * @param submissionId submissionId
+     * @throws Exception
+     */
+    public static void outputDownloadFromSubmissionApi(long submissionId,
+                                                       HttpServletResponse servletResponse) throws BaseException {
+        HttpResponse response = null;
+        DefaultHttpClient httpClient = null;
+        try {
+            httpClient = new DefaultHttpClient();
+            log.log(Level.INFO, "Get submission from api id: " + submissionId);
+            HttpGet request = new HttpGet(String.format(GET_SUBMISSION_ENDPOINT, submissionApiUrl, submissionId));
+            String v3Token = new JwtTokenUpdater().check().getToken();
+
+            request.setHeader(HttpHeaders.AUTHORIZATION, "Bearer " + v3Token);
+            request.addHeader(HttpHeaders.ACCEPT, "application/json");
+            response = httpClient.execute(request);
+            HttpEntity entity = response.getEntity();
+
+            if (response.getStatusLine().getStatusCode() != HttpStatus.SC_OK) {
+                throw new BaseException("Unable submission from the API:" + response.getStatusLine().getReasonPhrase());
+            }
+            JsonNode result = objectMapper.readTree(entity.getContent());
+
+            if (result.size() < 1) {
+             throw new BaseException("Can not found submission from API");
+            }
+            String v5SubmissionId = result.get(0).get("id").asText();
+            log.log(Level.INFO, "Found submission id: " + v5SubmissionId);
+            request.setURI(new URI(String.format(GET_DOWNLOAD_ENDPOINT, submissionApiUrl, v5SubmissionId)));
+            response = httpClient.execute(request);
+            if (response.getStatusLine().getStatusCode() != HttpStatus.SC_OK) {
+                throw new BaseException("Unable to download submission from the API:" + response.getStatusLine().getReasonPhrase());
+            }
+            log.log(Level.INFO, "begin downloading submission: " + v5SubmissionId);
+            InputStream in = response.getEntity().getContent();
+
+            servletResponse.setHeader("Content-Type", response.getEntity().getContentType().getValue());
+            servletResponse.setStatus(HttpServletResponse.SC_OK);
+            servletResponse.setIntHeader("Content-Length", (int) response.getEntity().getContentLength());
+            servletResponse.setHeader("Content-Disposition", response.getHeaders("Content-Disposition")[0].getValue());
+
+            servletResponse.flushBuffer();
+
+            OutputStream out = null;
+            try {
+                out = servletResponse.getOutputStream();
+                byte[] buffer = new byte[65536];
+
+                for (;;) {
+                    int numOfBytesRead = in.read(buffer);
+                    if (numOfBytesRead == -1) {
+                        break;
+                    }
+                    out.write(buffer, 0, numOfBytesRead);
+                }
+            } finally {
+                in.close();
+                if (out != null) {
+                    out.close();
+                }
+            }
+
+        } catch(Exception e) {
+            throw new BaseException(e.getMessage());
+        }
+    }
 }
diff --git a/src/java/main/com/cronos/onlinereview/util/ConfigHelper.java b/src/java/main/com/cronos/onlinereview/util/ConfigHelper.java
index f55c00767c..70f098f9d5 100644
--- a/src/java/main/com/cronos/onlinereview/util/ConfigHelper.java
+++ b/src/java/main/com/cronos/onlinereview/util/ConfigHelper.java
@@ -1056,6 +1056,11 @@ public class ConfigHelper {
      */
     private static String s3Bucket;
 
+    /**
+     * Submission Api endpoint
+     */
+    private static String submissionApiEndpoint;
+
     /**
      * AWS S3 bucket for DMZ
      */
@@ -1693,6 +1698,7 @@ public class ConfigHelper {
             Property awsS3 = cfgMgr.getPropertyObject(ONLINE_REVIEW_CFG_NS, "aws_s3");
             s3Bucket = awsS3.getValue("bucket");
             s3BucketDmz = awsS3.getValue("bucket_dmz");
+            submissionApiEndpoint = cfgMgr.getString(ONLINE_REVIEW_CFG_NS, "submission_api");
             try {
                 preSignedExpTimeMilis = Long.parseLong(awsS3.getValue("expire"));
             } catch (Exception e) {
@@ -2642,6 +2648,10 @@ public static String getS3Bucket() {
         return s3Bucket;
     }
 
+    public static String getSubmissionApiEndpoint() {
+        return submissionApiEndpoint;
+    }
+
     /**
      * Get S3 bucket DMZ
      * @return s3 bucket dmz name
diff --git a/token.properties.example b/token.properties.example
index cfba473f47..d03a3b80a5 100644
--- a/token.properties.example
+++ b/token.properties.example
@@ -197,8 +197,8 @@
 @tests.competitorusername@=user
 @tests.competitoruserpassword@=password
 @tests.competitoruserid@=132458
-@tests.timeout@=5000
 
+@tests.timeout@=5000
 #####################################
 # Parameters specific to Auto Pilot #
 #####################################
@@ -262,3 +262,4 @@
 @aws_s3_expire@=3600000
 @aws_s3_access_key@=
 @aws_s3_secret_key@=
+@submission_api_endpoint@=http://localhost:3000/v5/

From 81a2e9b17e74ef71036c3e5ebc3e3d9c9a247b5c Mon Sep 17 00:00:00 2001
From: "Deddy Syefria (deedee)" <dsyefria@gmail.com>
Date: Sat, 21 Mar 2020 19:19:33 +0700
Subject: [PATCH 2/3] change single import

---
 .../BaseProjectDetailsAction.java             | 30 +++++++++++++---
 .../onlinereview/util/ActionsHelper.java      | 35 ++++++++++++++++---
 2 files changed, 56 insertions(+), 9 deletions(-)

diff --git a/src/java/main/com/cronos/onlinereview/actions/projectdetails/BaseProjectDetailsAction.java b/src/java/main/com/cronos/onlinereview/actions/projectdetails/BaseProjectDetailsAction.java
index 6c7de3d3d4..f6aee7852c 100644
--- a/src/java/main/com/cronos/onlinereview/actions/projectdetails/BaseProjectDetailsAction.java
+++ b/src/java/main/com/cronos/onlinereview/actions/projectdetails/BaseProjectDetailsAction.java
@@ -11,11 +11,21 @@
 import com.cronos.onlinereview.model.DynamicModel;
 import com.cronos.onlinereview.model.FormFile;
 import com.cronos.onlinereview.phases.AmazonSNSHelper;
-import com.cronos.onlinereview.util.*;
+import com.cronos.onlinereview.util.ActionsHelper;
+import com.cronos.onlinereview.util.AuthorizationHelper;
+import com.cronos.onlinereview.util.ConfigHelper;
+import com.cronos.onlinereview.util.CorrectnessCheckResult;
+import com.cronos.onlinereview.util.LoggingHelper;
+import com.cronos.onlinereview.util.LookupHelper;
+import com.cronos.onlinereview.util.StrutsRequestParser;
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.node.ObjectNode;
-import com.topcoder.management.deliverable.*;
+import com.topcoder.management.deliverable.Submission;
+import com.topcoder.management.deliverable.SubmissionStatus;
+import com.topcoder.management.deliverable.Upload;
+import com.topcoder.management.deliverable.UploadManager;
+import com.topcoder.management.deliverable.UploadStatus;
 import com.topcoder.management.deliverable.persistence.UploadPersistenceException;
 import com.topcoder.management.deliverable.search.SubmissionFilterBuilder;
 import com.topcoder.management.project.Project;
@@ -32,7 +42,13 @@
 import com.topcoder.search.builder.filter.AndFilter;
 import com.topcoder.search.builder.filter.EqualToFilter;
 import com.topcoder.search.builder.filter.Filter;
-import com.topcoder.servlet.request.*;
+import com.topcoder.servlet.request.ConfigurationException;
+import com.topcoder.servlet.request.DisallowedDirectoryException;
+import com.topcoder.servlet.request.FileDoesNotExistException;
+import com.topcoder.servlet.request.FileUpload;
+import com.topcoder.servlet.request.FileUploadResult;
+import com.topcoder.servlet.request.PersistenceException;
+import com.topcoder.servlet.request.UploadedFile;
 import com.topcoder.util.config.ConfigManagerException;
 import com.topcoder.util.errorhandling.BaseException;
 import com.topcoder.util.file.DocumentGenerator;
@@ -44,7 +60,13 @@
 
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
-import java.io.*;
+import java.io.BufferedReader;
+import java.io.Closeable;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.io.OutputStream;
 import java.net.HttpURLConnection;
 import java.net.MalformedURLException;
 import java.net.URL;
diff --git a/src/java/main/com/cronos/onlinereview/util/ActionsHelper.java b/src/java/main/com/cronos/onlinereview/util/ActionsHelper.java
index 1342348c41..ddeb4b07fb 100644
--- a/src/java/main/com/cronos/onlinereview/util/ActionsHelper.java
+++ b/src/java/main/com/cronos/onlinereview/util/ActionsHelper.java
@@ -30,8 +30,16 @@
 import com.opensymphony.xwork2.TextProvider;
 import com.topcoder.date.workdays.DefaultWorkdaysFactory;
 import com.topcoder.date.workdays.Workdays;
-import com.topcoder.db.connectionfactory.*;
-import com.topcoder.management.deliverable.*;
+import com.topcoder.db.connectionfactory.ConfigurationException;
+import com.topcoder.db.connectionfactory.DBConnectionException;
+import com.topcoder.db.connectionfactory.DBConnectionFactory;
+import com.topcoder.db.connectionfactory.DBConnectionFactoryImpl;
+import com.topcoder.db.connectionfactory.UnknownConnectionException;
+import com.topcoder.management.deliverable.Deliverable;
+import com.topcoder.management.deliverable.DeliverableManager;
+import com.topcoder.management.deliverable.Submission;
+import com.topcoder.management.deliverable.Upload;
+import com.topcoder.management.deliverable.UploadManager;
 import com.topcoder.management.deliverable.late.LateDeliverable;
 import com.topcoder.management.deliverable.late.LateDeliverableManager;
 import com.topcoder.management.deliverable.persistence.DeliverableCheckingException;
@@ -72,7 +80,11 @@
 import com.topcoder.project.phases.template.StartDateGenerator;
 import com.topcoder.project.phases.template.persistence.XmlPhaseTemplatePersistence;
 import com.topcoder.search.builder.SearchBuilderException;
-import com.topcoder.search.builder.filter.*;
+import com.topcoder.search.builder.filter.AndFilter;
+import com.topcoder.search.builder.filter.EqualToFilter;
+import com.topcoder.search.builder.filter.Filter;
+import com.topcoder.search.builder.filter.NotFilter;
+import com.topcoder.search.builder.filter.OrFilter;
 import com.topcoder.servlet.request.DisallowedDirectoryException;
 import com.topcoder.servlet.request.FileUpload;
 import com.topcoder.servlet.request.LocalFileUpload;
@@ -107,11 +119,24 @@
 import java.net.URI;
 import java.net.URL;
 import java.rmi.RemoteException;
-import java.sql.*;
+import java.sql.Connection;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.sql.Types;
 import java.text.Format;
 import java.text.SimpleDateFormat;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Calendar;
+import java.util.Collection;
 import java.util.Date;
-import java.util.*;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
 
 
 /**

From e2e0029afd01b27368d9cca29157a5fce56fc165 Mon Sep 17 00:00:00 2001
From: "Deddy Syefria (deedee)" <dsyefria@gmail.com>
Date: Mon, 23 Mar 2020 03:15:27 +0700
Subject: [PATCH 3/3] some fixes on ActionsHelper.java

---
 .../onlinereview/util/ActionsHelper.java      | 72 +++++++++----------
 1 file changed, 34 insertions(+), 38 deletions(-)

diff --git a/src/java/main/com/cronos/onlinereview/util/ActionsHelper.java b/src/java/main/com/cronos/onlinereview/util/ActionsHelper.java
index ddeb4b07fb..ac93a681d5 100644
--- a/src/java/main/com/cronos/onlinereview/util/ActionsHelper.java
+++ b/src/java/main/com/cronos/onlinereview/util/ActionsHelper.java
@@ -98,6 +98,7 @@
 import com.topcoder.web.common.throttle.Throttle;
 import com.topcoder.web.ejb.forums.Forums;
 import com.topcoder.web.ejb.forums.ForumsHome;
+import org.apache.http.Header;
 import org.apache.http.HttpEntity;
 import org.apache.http.HttpHeaders;
 import org.apache.http.HttpResponse;
@@ -3830,25 +3831,7 @@ public static void outputDownloadS3File(String url, String key, String contentDi
 
             response.flushBuffer();
 
-            OutputStream out = null;
-
-            try {
-                out = response.getOutputStream();
-                byte[] buffer = new byte[65536];
-
-                for (;;) {
-                    int numOfBytesRead = in.read(buffer);
-                    if (numOfBytesRead == -1) {
-                        break;
-                    }
-                    out.write(buffer, 0, numOfBytesRead);
-                }
-            } finally {
-                in.close();
-                if (out != null) {
-                    out.close();
-                }
-            }
+            pipeInputStreamToOutputStream(in, response.getOutputStream());
         } catch (Exception e) {
             log.log(Level.ERROR, "ex: " + e.getMessage());
             throw new IOException("Error S3 download", e);
@@ -3948,31 +3931,44 @@ public static void outputDownloadFromSubmissionApi(long submissionId,
             servletResponse.setHeader("Content-Type", response.getEntity().getContentType().getValue());
             servletResponse.setStatus(HttpServletResponse.SC_OK);
             servletResponse.setIntHeader("Content-Length", (int) response.getEntity().getContentLength());
-            servletResponse.setHeader("Content-Disposition", response.getHeaders("Content-Disposition")[0].getValue());
+
+            Header[] headers = response.getHeaders("Content-Disposition");
+            String filename = "submission-" + submissionId + ".zip";
+            if (headers.length > 0) {
+                filename = headers[0].getValue();
+            }
+
+            servletResponse.setHeader("Content-Disposition", filename);
 
             servletResponse.flushBuffer();
+            pipeInputStreamToOutputStream(in, servletResponse.getOutputStream());
 
-            OutputStream out = null;
-            try {
-                out = servletResponse.getOutputStream();
-                byte[] buffer = new byte[65536];
+        } catch(Exception e) {
+            log.log(Level.ERROR, "Fail to get submission file for submissionId " + submissionId + "ex: " + e.getMessage());
+            throw new BaseException("Fail to get submission file for submissionId " + submissionId, e);
+        }
+    }
 
-                for (;;) {
-                    int numOfBytesRead = in.read(buffer);
-                    if (numOfBytesRead == -1) {
-                        break;
-                    }
-                    out.write(buffer, 0, numOfBytesRead);
-                }
-            } finally {
-                in.close();
-                if (out != null) {
-                    out.close();
+    /**
+     * Pipe inputstream to outputstream
+     *
+     * @param in inputstream
+     * @param out outputstream
+     * @throws IOException
+     */
+    private static void pipeInputStreamToOutputStream(InputStream in, OutputStream out) throws IOException {
+        try {
+            byte[] buffer = new byte[65536];
+            for (;;) {
+                int numOfBytesRead = in.read(buffer);
+                if (numOfBytesRead == -1) {
+                    break;
                 }
+                out.write(buffer, 0, numOfBytesRead);
             }
-
-        } catch(Exception e) {
-            throw new BaseException(e.getMessage());
+        } finally {
+            if (in != null) in.close();
+            if (out != null) out.close();
         }
     }
 }