Skip to content

Commit ca9d928

Browse files
committed
fix compilation problem
1 parent 7acbfed commit ca9d928

File tree

1 file changed

+17
-15
lines changed

1 file changed

+17
-15
lines changed

src/java/main/com/cronos/onlinereview/actions/project/SaveProjectAction.java

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1449,22 +1449,24 @@ private boolean checkUserChallengeEligibility(HttpServletRequest request, int re
14491449
// If there's no corresponding record in group_contest_eligibility
14501450
// then the challenge is available to all users
14511451
if (groups != null && groups.entrySet().size() > 0) {
1452-
Long challengeGroupInd = groups.get("challenge_group_ind")
1453-
if (challengeGroupInd != null || challengeGroupInd > 0) {
1454-
Long groupId = groups.get("group_id");
1455-
Set<Long> ids = this.getGroups(request, userId);
1456-
if (!ids.contains(groupInd)) {
1457-
ActionsHelper.addErrorToRequest(request, "resources_name[" + i + "]",
1458-
"error.com.cronos.onlinereview.actions.editProject.Resource.GroupPermissionDenied");
1459-
1460-
return false;
1461-
}
1462-
} else {
1463-
if (groups.get("user_group_xref_found") == null) {
1464-
ActionsHelper.addErrorToRequest(request, "resources_name[" + i + "]",
1465-
"error.com.cronos.onlinereview.actions.editProject.Resource.NotEligible");
1452+
Long challengeGroupInd = groups.get("challenge_group_ind");
1453+
if (challengeGroupInd != null) {
1454+
if (challengeGroupInd > 0) {
1455+
Long groupId = groups.get("group_id");
1456+
Set<Long> ids = this.getGroups(request, userId);
1457+
if (!ids.contains(groupId)) {
1458+
ActionsHelper.addErrorToRequest(request, "resources_name[" + resourceIdx + "]",
1459+
"error.com.cronos.onlinereview.actions.editProject.Resource.GroupPermissionDenied");
1460+
1461+
return false;
1462+
}
1463+
} else {
1464+
if (groups.get("user_group_xref_found") == null) {
1465+
ActionsHelper.addErrorToRequest(request, "resources_name[" + resourceIdx + "]",
1466+
"error.com.cronos.onlinereview.actions.editProject.Resource.NotEligible");
14661467

1467-
return false;
1468+
return false;
1469+
}
14681470
}
14691471
}
14701472
}

0 commit comments

Comments
 (0)