Skip to content

Commit bedb61c

Browse files
author
sachin-maheshwari
authored
Merge pull request #22 from topcoder-platform/feature/v5-support
Feature/v5 support
2 parents 81c868d + c2c9105 commit bedb61c

File tree

4 files changed

+14
-7
lines changed

4 files changed

+14
-7
lines changed

config/default.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,5 @@ module.exports = {
2727
KAFKA_CLIENT_CERT: process.env.KAFKA_CLIENT_CERT ? process.env.KAFKA_CLIENT_CERT.replace('\\n', '\n') : null,
2828
KAFKA_CLIENT_CERT_KEY: process.env.KAFKA_CLIENT_CERT_KEY ?
2929
process.env.KAFKA_CLIENT_CERT_KEY.replace('\\n', '\n') : null,
30+
API_CONTEXT_PATH: process.env.API_CONTEXT_PATH || '/v5/notifications',
3031
};

deploy.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ DATABASE_URL=postgres://$DB_USER:$DB_PASSWORD@$DB_HOST:$DB_PORT/$DB_DATABASE;
5858
family=$(eval "echo \$${ENV}_AWS_ECS_TASK_FAMILY")
5959
AWS_ECS_CONTAINER_NAME=$(eval "echo \$${ENV}_AWS_ECS_CONTAINER_NAME")
6060

61+
API_CONTEXT_PATH=$(eval "echo \$${ENV}_API_CONTEXT_PATH")
62+
6163
echo $APP_NAME
6264

6365
configure_aws_cli() {
@@ -172,6 +174,10 @@ make_task_def(){
172174
{
173175
"name": "PORT",
174176
"value": "%s"
177+
},
178+
{
179+
"name": "API_CONTEXT_PATH",
180+
"value": "%s"
175181
}
176182
],
177183
"portMappings": [
@@ -192,7 +198,7 @@ make_task_def(){
192198
}
193199
]'
194200

195-
task_def=$(printf "$task_template" $AWS_ECS_CONTAINER_NAME $AWS_ACCOUNT_ID $AWS_REGION $AWS_REPOSITORY $TAG $ENV "$KAFKA_CLIENT_CERT" "$KAFKA_CLIENT_CERT_KEY" $KAFKA_GROUP_ID "$KAFKA_TOPIC_IGNORE_PREFIX" $KAFKA_URL $DATABASE_URL $AUTHSECRET "$AUTHDOMAIN" "$JWKSURI" $TC_API_BASE_URL $TC_API_V3_BASE_URL $TC_API_V4_BASE_URL $TC_ADMIN_TOKEN $LOG_LEVEL $VALID_ISSUERS $PORT $AWS_ECS_CLUSTER $AWS_REGION $AWS_ECS_CLUSTER $ENV)
201+
task_def=$(printf "$task_template" $AWS_ECS_CONTAINER_NAME $AWS_ACCOUNT_ID $AWS_REGION $AWS_REPOSITORY $TAG $ENV "$KAFKA_CLIENT_CERT" "$KAFKA_CLIENT_CERT_KEY" $KAFKA_GROUP_ID "$KAFKA_TOPIC_IGNORE_PREFIX" $KAFKA_URL $DATABASE_URL $AUTHSECRET "$AUTHDOMAIN" "$JWKSURI" $TC_API_BASE_URL $TC_API_V3_BASE_URL $TC_API_V4_BASE_URL $TC_ADMIN_TOKEN $LOG_LEVEL $VALID_ISSUERS $PORT "$API_CONTEXT_PATH" $AWS_ECS_CLUSTER $AWS_REGION $AWS_ECS_CLUSTER $ENV)
196202
}
197203

198204
register_definition() {

src/app.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ function start(handlers) {
112112
});
113113
});
114114

115-
app.use('/', apiRouter);
115+
app.use(config.API_CONTEXT_PATH, apiRouter);
116116

117117

118118
app.use((req, res) => {

src/routes.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,31 @@
11
'use strict';
22

33
module.exports = {
4-
'/notifications': {
4+
'/list': {
55
get: {
66
controller: 'NotificationController',
77
method: 'listNotifications',
88
},
99
},
10-
'/notifications/:id/read': {
10+
'/:id/read': {
1111
put: {
1212
controller: 'NotificationController',
1313
method: 'markAsRead',
1414
},
1515
},
16-
'/notifications/read': {
16+
'/read': {
1717
put: {
1818
controller: 'NotificationController',
1919
method: 'markAllRead',
2020
},
2121
},
22-
'/notifications/:id/seen': {
22+
'/:id/seen': {
2323
put: {
2424
controller: 'NotificationController',
2525
method: 'markAsSeen',
2626
},
2727
},
28-
'/notificationsettings': {
28+
'/settings': {
2929
get: {
3030
controller: 'NotificationController',
3131
method: 'getSettings',

0 commit comments

Comments
 (0)