Using first event in the category of the notification type in case we don’t find a setting for the notification type. This mostly happens for a new notification type.

Author: Vikas Agarwal

connect/notificationServices/email.js

@@ -292,6 +292,19 @@ function handler(topicName, messageJSON, notification) {
     bundlePeriod = bundlePeriod && bundlePeriod.trim().length > 0 ? bundlePeriod : null;
     // if bundling is not explicitly set and the event is not a messaging event, assume bundling enabled
     if (!bundlePeriod && !messagingEvent) {
+      // finds the event category for the notification type
+      let eventBundleCategory = _.findKey(EVENT_BUNDLES, b => b.types && b.types.indexOf(notificationType) !== -1);
+      if (eventBundleCategory) {
+        const eventBundle = EVENT_BUNDLES[eventBundleCategory];
+        // if we find the event category for the notification, use the bundle settings from the first event
+        if (eventBundle && eventBundle.types && eventBundle.types.length) {
+          const firstEvtInBundle = eventBundle.types[0];
+          const firstEvtBundleSettingPath = `notifications['${firstEvtInBundle}'].${SETTINGS_EMAIL_SERVICE_ID}.bundlePeriod`
+          let firstEvtBundlePeriod = _.get(settings, firstEvtBundleSettingPath);
+          bundlePeriod = firstEvtBundlePeriod
+          logger.debug('Assuming bundle period of first event in the event category=>', bundlePeriod);
+        }
+      }
       // if bundle period is not set, assume it to be daily for default case
       bundlePeriod = !bundlePeriod ? 'daily' : bundlePeriod;
     }