PM-1143 - fix tax form status

Author: vas3a

prisma/migrations/20250425134520_truncate_tax_forms/migration.sql

@@ -8,7 +8,7 @@ ALTER TABLE "user_tax_form_associations" DROP CONSTRAINT "user_tax_form_associat
 DROP TABLE "user_tax_form_associations";
 DROP TYPE "tax_form_status";
 
-CREATE TYPE "tax_form_status" AS ENUM ('incomplete', 'submitted', 'reviewed', 'voided');
+CREATE TYPE "tax_form_status" AS ENUM ('ACTIVE', 'INACTIVE');
 
 -- CreateTable
 CREATE TABLE "user_tax_form_associations" (

prisma/schema.prisma

@@ -249,10 +249,8 @@ enum reference_type {
 }
 
 enum tax_form_status {
-  incomplete
-  submitted
-  reviewed
-  voided
+  ACTIVE
+  INACTIVE
 }
 
 enum transaction_status {

src/api/repository/taxForm.repo.ts

@@ -1,5 +1,5 @@
 import { Injectable } from '@nestjs/common';
-import { TaxFormStatus } from 'src/dto/adminWinning.dto';
+import { tax_form_status } from '@prisma/client';
 import { PrismaService } from 'src/shared/global/prisma.service';
 
 @Injectable()
@@ -16,7 +16,7 @@ export class TaxFormRepository {
     const count = await this.prisma.user_tax_form_associations.count({
       where: {
         user_id: userId,
-        tax_form_status: TaxFormStatus.Reviewed,
+        tax_form_status: tax_form_status.ACTIVE,
       },
     });
 

src/api/webhooks/trolley/handlers/tax-form.handler.ts

@@ -1,6 +1,7 @@
 import { Injectable } from '@nestjs/common';
 import { WebhookEvent } from '../../webhooks.decorators';
 import {
+  TaxFormStatus,
   TaxFormStatusUpdatedEvent,
   TaxFormStatusUpdatedEventData,
   TrolleyWebhookEvent,
@@ -23,28 +24,33 @@ export class TaxFormHandler {
     recipient: trolley_recipient,
     taxFormData: TaxFormStatusUpdatedEventData,
   ) {
+    const taxFormStatus =
+      taxFormData.status === TaxFormStatus.Reviewed
+        ? tax_form_status.ACTIVE
+        : tax_form_status.INACTIVE;
+
     const existingFormAssociation =
       await this.prisma.user_tax_form_associations.findFirst({
         where: {
           user_id: recipient.user_id,
           tax_form_id: taxFormId,
-          tax_form_status: { notIn: [tax_form_status.voided] },
+          tax_form_status: tax_form_status.ACTIVE,
         },
       });
 
     if (!existingFormAssociation) {
       return this.prisma.user_tax_form_associations.create({
         data: {
           user_id: recipient.user_id,
-          tax_form_status: taxFormData.status,
+          tax_form_status: taxFormStatus,
           date_filed: taxFormData.signedAt,
           tax_form_id: taxFormId,
         },
       });
     }
 
     // voided forms associations are removed from DB
-    if (taxFormData.status === tax_form_status.voided) {
+    if (taxFormData.status === TaxFormStatus.Voided) {
       return this.prisma.user_tax_form_associations.delete({
         where: {
           id: existingFormAssociation.id,
@@ -55,7 +61,7 @@ export class TaxFormHandler {
     return this.prisma.user_tax_form_associations.update({
       where: { id: existingFormAssociation?.id },
       data: {
-        tax_form_status: taxFormData.status,
+        tax_form_status: taxFormStatus,
         date_filed: taxFormData.signedAt,
       },
     });

src/api/webhooks/trolley/trolley.types.ts

@@ -6,7 +6,12 @@ export enum TrolleyWebhookEvent {
 
 export type TrolleyEventHandler = (eventPayload: any) => Promise<unknown>;
 
-export type TaxFormStatus = 'incomplete' | 'submitted' | 'reviewed' | 'voided';
+export enum TaxFormStatus {
+  Incomplete = 'incomplete',
+  Submitted = 'submitted',
+  Reviewed = 'reviewed',
+  Voided = 'voided',
+}
 
 export interface TaxFormStatusUpdatedEventData {
   recipientId: string;