Skip to content

[$70] Make some ResourceBooking fields not required. #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxceem opened this issue Dec 28, 2020 · 8 comments
Closed

[$70] Make some ResourceBooking fields not required. #84

maxceem opened this issue Dec 28, 2020 · 8 comments

Comments

@maxceem
Copy link
Contributor

maxceem commented Dec 28, 2020

Make the following fields on ResourceBooking be not required during all the operations:

  • startDate
  • endDate
  • memberRate
  • customerRate

Update documentation (swagger, postman) accordingly.

@maxceem
Copy link
Contributor Author

maxceem commented Dec 28, 2020

Contest https://www.topcoder.com/challenges/30160479 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem added the enhancement New feature or request label Dec 28, 2020
@maxceem
Copy link
Contributor Author

maxceem commented Dec 28, 2020

@imcaizheng this issue is open for pickup.

@imcaizheng imcaizheng self-assigned this Dec 28, 2020
@maxceem
Copy link
Contributor Author

maxceem commented Dec 28, 2020

Contest https://www.topcoder.com/challenges/30160479 has been updated - it has been assigned to aaron2017.

This is an automated message for maxceem via Topcoder X

@imcaizheng
Copy link
Contributor

PR created #86

@maxceem maxceem changed the title [$30] Make some ResourceBooking fields not required. [$70] Make some ResourceBooking fields not required. Dec 30, 2020
@maxceem
Copy link
Contributor Author

maxceem commented Dec 30, 2020

I've updated the budget as we also need to create a migration script for this. Details in the review #86 (review)

@maxceem
Copy link
Contributor Author

maxceem commented Jan 4, 2021

@nkumar-topcoder I would need your help to apply the fix for this issue.

We need to run a migration script that we've already created.

The migration script can be run by npm run migrate. This script would require to define env variables for DB connection:

  • DB_USERNAME
  • DB_PASSWORD
  • DB_NAME
  • DB_HOST

So this would need to be run on both DEV and on PROD servers.

Theoretically, we could add these commands to the CirecleCI, but I guess it would be better to keep it manual for better control for now.

@maxceem
Copy link
Contributor Author

maxceem commented Jan 6, 2021

Tested on DEV, works good.

@maxceem maxceem closed this as completed Jan 6, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Jan 6, 2021

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30160479

This is an automated message for maxceem via Topcoder X

@maxceem maxceem added this to the v1.0 - Initial Launch milestone Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants