-
Notifications
You must be signed in to change notification settings - Fork 33
[$30] Remove "skillMatched" property from all the responses #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@maxceem Agreed, good catch. Please continue on client side |
Contest https://www.topcoder.com/challenges/30160369 has been created for this ticket. |
@imcaizheng open for pickup. |
Contest https://www.topcoder.com/challenges/30160369 has been updated - it has been assigned to aaron2017. |
PR created #83 |
Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30160369 |
Currently, we are calculating
skillMatched
property server-side and return it in endpoints:GET /taas-teams/:teamId
GET /taas-teams/:teamId/jobs/:jobId
Though I think this property is unnecessary.
Both these endpoints return the list of job skills and list of user skills. So we can calculate the number of matched skills client-side.
I suggest removing this from API (including swagger and postman).
@nkumar-topcoder what do you think?
The text was updated successfully, but these errors were encountered: