Skip to content

[$30] Remove "skillMatched" property from all the responses #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxceem opened this issue Dec 25, 2020 · 6 comments
Closed

[$30] Remove "skillMatched" property from all the responses #82

maxceem opened this issue Dec 25, 2020 · 6 comments

Comments

@maxceem
Copy link
Contributor

maxceem commented Dec 25, 2020

Currently, we are calculating skillMatched property server-side and return it in endpoints:

  • GET /taas-teams/:teamId
  • GET /taas-teams/:teamId/jobs/:jobId

Though I think this property is unnecessary.

Both these endpoints return the list of job skills and list of user skills. So we can calculate the number of matched skills client-side.

I suggest removing this from API (including swagger and postman).

@nkumar-topcoder what do you think?

@maxceem maxceem added enhancement New feature or request question Further information is requested labels Dec 25, 2020
@nkumar-topcoder
Copy link
Contributor

@maxceem Agreed, good catch. Please continue on client side

@maxceem maxceem changed the title Remove "skillMatched" property from all the responses [$30] Remove "skillMatched" property from all the responses Dec 26, 2020
@maxceem
Copy link
Contributor Author

maxceem commented Dec 26, 2020

Contest https://www.topcoder.com/challenges/30160369 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Dec 26, 2020

@imcaizheng open for pickup.

@maxceem maxceem removed the question Further information is requested label Dec 26, 2020
@imcaizheng imcaizheng self-assigned this Dec 26, 2020
@maxceem
Copy link
Contributor Author

maxceem commented Dec 26, 2020

Contest https://www.topcoder.com/challenges/30160369 has been updated - it has been assigned to aaron2017.

This is an automated message for maxceem via Topcoder X

@imcaizheng
Copy link
Contributor

PR created #83

@maxceem
Copy link
Contributor Author

maxceem commented Dec 28, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30160369

This is an automated message for maxceem via Topcoder X

@maxceem maxceem added this to the v1.0 - Initial Launch milestone Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants