Skip to content

[$30] Change status when user is booked #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxceem opened this issue Dec 4, 2020 · 8 comments
Closed

[$30] Change status when user is booked #42

maxceem opened this issue Dec 4, 2020 · 8 comments

Comments

@maxceem
Copy link
Contributor

maxceem commented Dec 4, 2020

image

When we are updating the status of ResourceBooking to assigned the corresponding JobCandidate record (with the same userId and jobId should be updated with the status selected.

@maxceem maxceem added the enhancement New feature or request label Dec 4, 2020
@maxceem maxceem changed the title Change status when user is booked [$30] Change status when user is booked Dec 4, 2020
@maxceem
Copy link
Contributor Author

maxceem commented Dec 4, 2020

@imcaizheng ready for pick up.

@imcaizheng imcaizheng self-assigned this Dec 4, 2020
@imcaizheng
Copy link
Contributor

@maxceem PR created #45

@nkumar-topcoder
Copy link
Contributor

@imcaizheng

  1. Is the update to selected status for the jobcandidate for Elastic Search is also taken care ?
  2. What happens if the userid and jobid doesn't exists ?

CC @maxceem

@imcaizheng
Copy link
Contributor

@nkumar-topcoder

  1. yes. Internally the JobCandidateService.partiallyUpdateJobCandidate() function would be called after a resourceBooking is assigned, so the candidate would be updated in both db and es.
  2. no candidates would be updated when a candidate with same userId and jobId is not found.
  3. when there are more than one candidate with same userId and jobId found, all the candidates would be updated.

I also have a question. Currently POST /jobCandidates could be called multiple times to create duplicated candidates(with same userId and jobId). Shouldn't we raise conflict error in this case?

@nkumar-topcoder
Copy link
Contributor

@imcaizheng you have point, i shall get back on this.

@maxceem
Copy link
Contributor Author

maxceem commented Dec 7, 2020

Contest https://www.topcoder.com/challenges/30156199 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Dec 7, 2020

Contest https://www.topcoder.com/challenges/30156199 has been updated - it has been assigned to aaron2017.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Dec 8, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30156199

This is an automated message for maxceem via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants