[$100] Update Resource Booking model to not store time, only dates

[maxceem]

Task

• Update Resource Booking model startDate and endDate fields so they only store dates without time, same like WorkPeriod.startDate/endDate.
• Create a migration script that updates all the existent records to store only dates without time (Just cut the time and timezone or any simple way). And it updates the DB model accordingly.
• Update all Joi schemas so they only accept dates without time and timezone for Resource Booking create/update operations.
• Make sure that filtering and sorting by start/end dates work good for Resource Booking endoint.
• Update logic of automatic WorkPeriod creation. Now we don't need timezone conversion. Logic should use Resource Booking dates without time and timezone now. See logic description for create and update https://github.com/topcoder-platform/taas-apis/wiki/TaaS---Scope,-Status-and-permissions#work-period-wp-automation-and-constraints
• Update all Postman endpoints accordingly, so they all work good.
• Update Swagger if needed.
• Update demo data populate by npm run local:init if needed so if works good.
• Update ES processor test data https://github.com/topcoder-platform/taas-es-processor/tree/feature/work-periods/test/messages and make sure unit and e2e tests pass there.
• Make sure that data in ES is also stored without time and timezone.
• Unit tests in TaaS API should pass.
• Lint should pass.
• Update anything else which might be affected by this change.

References

• Task to update UI after this Show/Edit Resource Bookings strat/end dates without time and timezone topcoder-archive/topcoder-platform-taas-app#150

[maxceem]

Challenge https://www.topcoder.com/challenges/3f8d8c21-23b6-4410-9239-62c4ed928fd9 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

[maxceem]

@imcaizheng @eisbilir feel free to pick up this issue as per #1

Please, pick up one issue at a time. It's preferable to complete issues within 12 hours, but maximum of 24 hours.

[maxceem]

@eisbilir, please sign-up with Topcoder X tool

This is an automated message for maxceem via Topcoder X

[maxceem]

@eisbilir, please sign-up with Topcoder X tool

This is an automated message for maxceem via Topcoder X

[maxceem]

@eisbilir I would take care of Topcoder X tool, please feel free to work on this issue.

[eisbilir]

@maxceem we need to execute new migration script 2021-04-21-make-resource-booking-dates-store-no-timestamp.js before 2021-04-10-populate-work-periods-for-resource-bookings.js so, the populator script will be able to use updated resource booking dates. Can I name the new migration script as 2021-04-09-make-resource-booking-dates-store-no-timestamp.js, so that it can run before 2021-04-10-populate-work-periods-for-resource-bookings.js ?

[maxceem]

Yes, can rename that script.

[eisbilir]

@maxceem I removed the timezone conversion.
According to https://github.com/topcoder-platform/taas-apis/wiki/Work-Periods-(WP)-Automation-and-Constraints#work-period-wp-automation-and-constraints following statements are not implemented yet.

NOTE, that during creating Work Periods we should NOT set daysWorked and should keep it as null.

Once startDate or endDate is set, we don't allow removing them.

Default Days Worked calucalation ...

are they in the scope of this issue?

[maxceem]

@eisbilir ah sorry wrong link. Here is the correct one https://github.com/topcoder-platform/taas-apis/wiki/TaaS---Scope,-Status-and-permissions#work-period-wp-automation-and-constraints (I've fixed the description above).

No, in this issue keep the same logic, and just remove time and timezone. We would handle other updates separately by other issues https://github.com/topcoder-platform/taas-apis/issues?q=is%3Aissue+is%3Aopen+label%3ACF.

[eisbilir]

PR created #214
taas-es-processor#46

[maxceem]

Thank you @eisbilir all the PRs works good for me as per local testing. The payment is processed https://www.topcoder.com/challenges/a880287b-52f0-4b12-9cdc-450a5e948b39

[sandhiyakavi]

Verified below scenarios. Working as expected.

1. Newly created/updated RB doesn't include Time zone.
2. Existing RB doesn't include time details.
3. Not able to create/update dates of RB with Time zone .
4. Filtering the RB by startdate/End date is working correctly.
5. The WP created are displaying the dates and daysworked correctly now.

[maxceem]

Thank you for verification @sandhiyakavi.
Closing as it was only DEV issue.

[maxceem]

Challenge 3f8d8c21-23b6-4410-9239-62c4ed928fd9 has been cancelled

This is an automated message for maxceem via Topcoder X