Skip to content

[$40] Ability to switch off actual payments on PROD #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxceem opened this issue Apr 20, 2021 · 6 comments
Closed

[$40] Ability to switch off actual payments on PROD #201

maxceem opened this issue Apr 20, 2021 · 6 comments

Comments

@maxceem
Copy link
Contributor

maxceem commented Apr 20, 2021

When we create payment records using API POST /work-period-payments the actual payment would be created https://github.com/topcoder-platform/taas-apis/blob/dev/src/services/WorkPeriodPaymentService.js#L99-L105.

During testing on PROD we would like to be able to disable the actual payment processing.

Task

Unit test

Create unit tests to check this:

  • should not create actual payment when "PAYMENT_PROCESSING_SWITCH" if "OFF"
  • should create actual payment when "PAYMENT_PROCESSING_SWITCH" is "ON"
@maxceem maxceem added the CF label Apr 20, 2021
@maxceem maxceem added this to the v1.6.0 - Work Periods milestone Apr 20, 2021
@maxceem maxceem changed the title Ability to switch off actual payments on PROD [$20] Ability to switch off actual payments on PROD Apr 21, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Apr 21, 2021

Challenge https://www.topcoder.com/challenges/3286d857-f730-45af-9abd-69f60fac8539 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Apr 21, 2021

@imcaizheng @eisbilir feel free to pick up as per #1

@maxceem
Copy link
Contributor Author

maxceem commented Apr 21, 2021

Challenge https://www.topcoder.com/challenges/3286d857-f730-45af-9abd-69f60fac8539 has been assigned to aaron2017.

This is an automated message for maxceem via Topcoder X

@imcaizheng
Copy link
Contributor

PR created #211

@maxceem maxceem changed the title [$20] Ability to switch off actual payments on PROD [$40] Ability to switch off actual payments on PROD Apr 21, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Apr 21, 2021

The payment was increased as there were some common unit test fixes made.

@maxceem
Copy link
Contributor Author

maxceem commented Apr 21, 2021

Payment task has been updated: https://www.topcoder.com/challenges/3286d857-f730-45af-9abd-69f60fac8539
Payments Complete
Winner: aaron2017
Copilot: maxceem
Challenge 3286d857-f730-45af-9abd-69f60fac8539 has been paid and closed.

This is an automated message for maxceem via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants