-
Notifications
You must be signed in to change notification settings - Fork 33
[$40] Ability to switch off actual payments on PROD #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Challenge https://www.topcoder.com/challenges/3286d857-f730-45af-9abd-69f60fac8539 has been created for this ticket. |
@imcaizheng @eisbilir feel free to pick up as per #1 |
Challenge https://www.topcoder.com/challenges/3286d857-f730-45af-9abd-69f60fac8539 has been assigned to aaron2017. |
PR created #211 |
The payment was increased as there were some common unit test fixes made. |
Payment task has been updated: https://www.topcoder.com/challenges/3286d857-f730-45af-9abd-69f60fac8539 |
Uh oh!
There was an error while loading. Please reload this page.
When we create payment records using API
POST /work-period-payments
the actual payment would be created https://github.com/topcoder-platform/taas-apis/blob/dev/src/services/WorkPeriodPaymentService.js#L99-L105.During testing on PROD we would like to be able to disable the actual payment processing.
Task
PAYMENT_PROCESSING_SWITCH
, with the default valueOFF
PAYMENT_PROCESSING_SWITCH===OFF
, then don't callcreatePayment
method here https://github.com/topcoder-platform/taas-apis/blob/dev/src/services/WorkPeriodPaymentService.js#L99-L105. And just set a dummy challenge id value00000000-0000-0000-0000-000000000000
.Unit test
Create unit tests to check this:
The text was updated successfully, but these errors were encountered: