Skip to content

[$50] Make some Job fields optional #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maxceem opened this issue Jan 7, 2021 · 7 comments
Closed

[$50] Make some Job fields optional #102

maxceem opened this issue Jan 7, 2021 · 7 comments
Assignees
@imcaizheng
Labels
tcx_Assigned tcx_FixAccepted tcx_Paid
Milestone
v1.0 - Initial La...

Comments

@maxceem
Copy link
Contributor

maxceem commented Jan 7, 2021 •
edited
Loading

We would like to make the next fields in Job model optional as we don't always have them. So we would be more flexible during development.

  • externalId
  • description
  • startDate
  • endDate
  • resourceType
  • rateType
  • workload (and remove default value)

Make them optional in:

  • DB
  • ES
  • in all endpoints
  • swagger
  • create a migration script

If there are any places in code that rely on these values, please, let me know.
@maxceem maxceem changed the title Make some Job fields optional [$50] Make some Job fields optional Jan 7, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Jan 7, 2021

Contest https://www.topcoder.com/challenges/30161551 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Jan 7, 2021

@imcaizheng this is ready for pick up.

@imcaizheng imcaizheng self-assigned this Jan 8, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Jan 8, 2021

Contest https://www.topcoder.com/challenges/30161551 has been updated - it has been assigned to aaron2017.

This is an automated message for maxceem via Topcoder X

@imcaizheng
Copy link
Contributor

PR created #103
PR for taas-es-processor created topcoder-platform/taas-es-processor#11

@maxceem
Copy link
Contributor Author

maxceem commented Jan 10, 2021

@nkumar-topcoder PR for this issue has been tested locally and works good.

We would need your help to merge it.

  1. Merge PR make some fields of Job optional #103
  2. Run migration script npm run migrate

@maxceem
Copy link
Contributor Author

maxceem commented Jan 11, 2021

Verified on DEV, works good.

@maxceem maxceem closed this as completed Jan 11, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Jan 11, 2021

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30161551

This is an automated message for maxceem via Topcoder X

@maxceem maxceem added this to the v1.0 - Initial Launch milestone Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imcaizheng imcaizheng

Labels
tcx_Assigned tcx_FixAccepted tcx_Paid
Projects
None yet
Milestone
v1.0 - Initial Launch
Development

No branches or pull requests
2 participants
@maxceem @imcaizheng