Skip to content

Commit b0bd4dd

Browse files
committed
make fields startDate, endDate, memberRate and customerRate optional
1 parent 28e0b38 commit b0bd4dd

File tree

4 files changed

+16
-24
lines changed

4 files changed

+16
-24
lines changed

docs/swagger.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1861,10 +1861,6 @@ components:
18611861
- projectId
18621862
- userId
18631863
- status
1864-
- startDate
1865-
- endDate
1866-
- memberRate
1867-
- customerRate
18681864
- rateType
18691865
- createdAt
18701866
- createdBy
@@ -1935,10 +1931,6 @@ components:
19351931
- projectId
19361932
- userId
19371933
- status
1938-
- startDate
1939-
- endDate
1940-
- memberRate
1941-
- customerRate
19421934
- rateType
19431935
properties:
19441936
projectId:

src/models/ResourceBooking.js

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,23 +61,19 @@ module.exports = (sequelize) => {
6161
},
6262
startDate: {
6363
field: 'start_date',
64-
type: Sequelize.DATE,
65-
allowNull: false
64+
type: Sequelize.DATE
6665
},
6766
endDate: {
6867
field: 'end_date',
69-
type: Sequelize.DATE,
70-
allowNull: false
68+
type: Sequelize.DATE
7169
},
7270
memberRate: {
7371
field: 'member_rate',
74-
type: Sequelize.FLOAT,
75-
allowNull: false
72+
type: Sequelize.FLOAT
7673
},
7774
customerRate: {
7875
field: 'customer_rate',
79-
type: Sequelize.FLOAT,
80-
allowNull: false
76+
type: Sequelize.FLOAT
8177
},
8278
rateType: {
8379
field: 'rate_type',

src/services/ResourceBookingService.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -121,10 +121,10 @@ createResourceBooking.schema = Joi.object().keys({
121121
projectId: Joi.number().integer().required(),
122122
userId: Joi.string().uuid().required(),
123123
jobId: Joi.string().uuid(),
124-
startDate: Joi.date().required(),
125-
endDate: Joi.date().required(),
126-
memberRate: Joi.number().required(),
127-
customerRate: Joi.number().required(),
124+
startDate: Joi.date(),
125+
endDate: Joi.date(),
126+
memberRate: Joi.number(),
127+
customerRate: Joi.number(),
128128
rateType: Joi.rateType().required()
129129
}).required()
130130
}).required()
@@ -225,10 +225,10 @@ fullyUpdateResourceBooking.schema = Joi.object().keys({
225225
projectId: Joi.number().integer().required(),
226226
userId: Joi.string().uuid().required(),
227227
jobId: Joi.string().uuid(),
228-
startDate: Joi.date().required(),
229-
endDate: Joi.date().required(),
230-
memberRate: Joi.number().required(),
231-
customerRate: Joi.number().required(),
228+
startDate: Joi.date(),
229+
endDate: Joi.date(),
230+
memberRate: Joi.number(),
231+
customerRate: Joi.number(),
232232
rateType: Joi.rateType().required(),
233233
status: Joi.jobStatus().required()
234234
}).required()

src/services/TeamService.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,10 @@ async function getTeamDetail (currentUser, projects, isSearch = true) {
125125

126126
// Count weekly rate
127127
for (const item of rbs) {
128+
// ignore any resourceBooking that has customerRate missed
129+
if (!item.customerRate) {
130+
continue
131+
}
128132
const startDate = new Date(item.startDate)
129133
const endDate = new Date(item.endDate)
130134

0 commit comments

Comments
 (0)