fix connecting first calendar without timezone

Author: maxceem

migrations/2021-09-30-interview-nylas.js

@@ -50,8 +50,7 @@ module.exports = {
         defaultAvailableTime: nylasAvailableTimeSchema('defaultAvailableTime'),
         defaultTimezone: {
           field: 'defaultTimezone',
-          type: Sequelize.STRING(255),
-          allowNull: false
+          type: Sequelize.STRING(255)
         },
         nylasCalendars: nylasCalendarsSchema(),
         createdBy: {

src/models/UserMeetingSettings.js

@@ -53,8 +53,7 @@ module.exports = (sequelize) => {
       defaultAvailableTime: nylasAvailableTimeSchema('defaultAvailableTime'),
       defaultTimezone: {
         field: 'defaultTimezone',
-        type: Sequelize.STRING(255),
-        allowNull: false
+        type: Sequelize.STRING(255)
       },
       nylasCalendars: nylasCalendarsSchema(),
       createdBy: {

src/services/NylasService.js

@@ -42,7 +42,7 @@ async function createVirtualCalendarForUser (userId, userEmail, userFullName, ti
   if (_.isEmpty(calendars)) {
     calendar = await createVirtualCalendar(userFullName, timezone, accessToken)
   } else {
-    calendar = calendars.find(c => c.is_primary) || calendars[0]
+    calendar = getPrimaryCalendar(calendars)
   }
   return _.extend(calendar, { accessToken: accessToken })
 }
@@ -162,12 +162,35 @@ async function patchSchedulingPage (pageId, accessToken, changes) {
   return page
 }
 
+/**
+ * Detect calendar which would be used as a primary one
+ *
+ * @param {Array<Object>} calendars list of Nylas calendars
+ * @returns
+ */
+function getPrimaryCalendar (calendars) {
+  const primaryCalendar = _.find(calendars, { is_primary: true, read_only: false })
+
+  if (primaryCalendar) {
+    return primaryCalendar
+  }
+
+  const writableCalendars = _.filter(calendars, { read_only: false })
+
+  if (writableCalendars.length > 0) {
+    return writableCalendars[0]
+  }
+
+  return null
+}
+
 module.exports = {
   createVirtualCalendarForUser,
   createSchedulingPage,
   patchSchedulingPage,
   getAvailableTimeFromSchedulingPage,
   getTimezoneFromSchedulingPage,
   getExistingCalendars,
-  getAccessToken
+  getAccessToken,
+  getPrimaryCalendar
 }

src/services/UserMeetingSettingsService.js

@@ -192,9 +192,9 @@ async function handleConnectCalendarCallback (reqQuery) {
       throw new errors.BadRequestError('Error getting calendar data for the user.')
     }
 
-    const primaryCalendar = calendars.find(c => c.is_primary)
+    const primaryCalendar = NylasService.getPrimaryCalendar(calendars)
     if (!primaryCalendar) {
-      throw new errors.NotFoundError('Could not find any primary calendar in Nylas backend server.')
+      throw new errors.NotFoundError('Could not find any writable calendar.')
     }
 
     const calendarDetails = {
@@ -225,7 +225,6 @@ async function handleConnectCalendarCallback (reqQuery) {
             booking: { opening_hours: [] }
           }
         })
-      await processCreate(userMeetingSettings)
     } else { // or just update calendar details in the exisiting object
       const calendarIndexInUserMeetingSettings = _.findIndex(userMeetingSettings.nylasCalendars, (item) => item.id === calendarDetails.id)