Merge pull request #86 from imcaizheng/make-some-fields-for-resource-booking-optional

make fields startDate, endDate, memberRate and customerRate optional

Author: nkumar-topcoder

README.md

@@ -67,6 +67,19 @@ The following parameters can be set in config files or in env variables:
 - Modify `DATABASE_URL` under `config/default.js` to meet your environment.
 - Run `npm run init-db` to create table(run `npm run init-db force` to force creating table)
 
+## DB Migration
+- `npm run migrate`: run any migration files which haven't run yet.
+- `npm run migrate:undo`: revert most recent migration.
+
+Configuration for migration is at `./config/config.json`.
+
+The following parameters can be set in the config file or via env variables:
+
+- `username`: set via env `DB_USERNAME`; datebase username
+- `password`: set via env `DB_PASSWORD`; datebase password
+- `database`: set via env `DB_NAME`; datebase name
+- `host`: set via env `DB_HOST`; datebase host name
+
 ## ElasticSearch Setup
 - Go to https://www.elastic.co/downloads/ download and install the elasticsearch.
 - Modify `esConfig` under `config/default.js` to meet your environment.

config/config.js

@@ -0,0 +1,27 @@
+/*
+ * Configuration for DB migration.
+ */
+
+module.exports = {
+  development: {
+    username: process.env.DB_USERNAME || 'postgres',
+    password: process.env.DB_PASSWORD || 'postgres',
+    database: process.env.DB_NAME || 'postgres',
+    host: process.env.DB_HOST || '127.0.0.1',
+    dialect: 'postgres'
+  },
+  test: {
+    username: process.env.DB_USERNAME || 'postgres',
+    password: process.env.DB_PASSWORD || 'postgres',
+    database: process.env.DB_NAME || 'postgres',
+    host: process.env.DB_HOST || '127.0.0.1',
+    dialect: 'postgres'
+  },
+  production: {
+    username: process.env.DB_USERNAME,
+    password: process.env.DB_PASSWORD,
+    database: process.env.DB_NAME,
+    host: process.env.DB_HOST,
+    dialect: 'postgres'
+  }
+}

config/config.json

@@ -0,0 +1,23 @@
+{
+  "development": {
+    "username": "postgres",
+    "password": "postgres",
+    "database": "postgres",
+    "host": "127.0.0.1",
+    "dialect": "postgres"
+  },
+  "test": {
+    "username": "root",
+    "password": null,
+    "database": "database_test",
+    "host": "127.0.0.1",
+    "dialect": "mysql"
+  },
+  "production": {
+    "username": "root",
+    "password": null,
+    "database": "database_production",
+    "host": "127.0.0.1",
+    "dialect": "mysql"
+  }
+}

docs/swagger.yaml

@@ -1861,10 +1861,6 @@ components:
         - projectId
         - userId
         - status
-        - startDate
-        - endDate
-        - memberRate
-        - customerRate
         - rateType
         - createdAt
         - createdBy
@@ -1935,10 +1931,6 @@ components:
         - projectId
         - userId
         - status
-        - startDate
-        - endDate
-        - memberRate
-        - customerRate
         - rateType
       properties:
         projectId:

migrations/2021-01-04-make-some-resouce-booking-fields-optional.js

@@ -0,0 +1,18 @@
+/*
+ * Make ResourceBooking fields startDate, endDate, memberRate and customerRate optional.
+ */
+
+const targetFields = ['start_date', 'end_date', 'member_rate', 'customer_rate']
+
+module.exports = {
+  up: queryInterface => {
+    return Promise.all(targetFields.map(field =>
+      queryInterface.sequelize.query(`ALTER TABLE bookings.resource_bookings ALTER COLUMN ${field} DROP NOT NULL`)
+    ))
+  },
+  down: queryInterface => {
+    return Promise.all(targetFields.map(field =>
+      queryInterface.sequelize.query(`ALTER TABLE bookings.resource_bookings ALTER COLUMN ${field} SET NOT NULL`)
+    ))
+  }
+}