refactor: getSkills -> getTopcoderSkills

Author: maxceem

config/default.js

@@ -21,7 +21,7 @@ module.exports = {
 
   TC_API: process.env.TC_API || 'https://api.topcoder-dev.com/v5',
   ORG_ID: process.env.ORG_ID || '36ed815b-3da1-49f1-a043-aaed0a4e81ad',
-  TOPCODER_SKILL_PROVIDER_ID: process.env.TOPCODER_SKILL_PROVIDER_ID,
+  TOPCODER_SKILL_PROVIDER_ID: process.env.TOPCODER_SKILL_PROVIDER_ID || '9cc0795a-6e12-4c84-9744-15858dba1861',
 
   TOPCODER_USERS_API: process.env.TOPCODER_USERS_API || 'https://api.topcoder-dev.com/v3/users',
 

src/common/helper.js

@@ -475,10 +475,12 @@ async function getProjectById (currentUser, id) {
 
 /**
  * Function to search skills from v5/skills
+ * - only returns skills from Topcoder Skills Provider defined by `TOPCODER_SKILL_PROVIDER_ID`
+ *
  * @param {Object} criteria the search criteria
  * @returns the request result
  */
-async function getSkills (criteria) {
+async function getTopcoderSkills (criteria) {
   const token = await getM2Mtoken()
   try {
     const res = await request
@@ -490,7 +492,7 @@ async function getSkills (criteria) {
       .set('Authorization', `Bearer ${token}`)
       .set('Content-Type', 'application/json')
       .set('Accept', 'application/json')
-    localLogger.debug({ context: 'getSkills', message: `response body: ${JSON.stringify(res.body)}` })
+    localLogger.debug({ context: 'getTopcoderSkills', message: `response body: ${JSON.stringify(res.body)}` })
     return {
       total: Number(_.get(res.headers, 'x-total')),
       page: Number(_.get(res.headers, 'x-page')),
@@ -623,7 +625,7 @@ module.exports = {
   getUserById,
   getMembers,
   getProjectById,
-  getSkills,
+  getTopcoderSkills,
   getSkillById,
   getUserSkill,
   ensureJobById,

src/services/SkillService.js

@@ -10,7 +10,7 @@ const helper = require('../common/helper')
  * @returns {Object} the search result, contain total/page/perPage and result array
  */
 async function searchSkills (criteria) {
-  return helper.getSkills(criteria)
+  return helper.getTopcoderSkills(criteria)
 }
 
 searchSkills.schema = Joi.object().keys({