From 04ae399fe13a1e1907bc41fe3723140f5e4d3d87 Mon Sep 17 00:00:00 2001 From: Mithun Kamath Date: Sun, 22 Sep 2019 12:05:47 +0530 Subject: [PATCH] Fix lint errors and force pre commit lint checks --- package-lock.json | 403 ++++++++++++++++++++++++++++++++++ package.json | 6 + src/services/ReviewService.js | 140 ++++++------ 3 files changed, 479 insertions(+), 70 deletions(-) diff --git a/package-lock.json b/package-lock.json index 033a2606..fac7153a 100755 --- a/package-lock.json +++ b/package-lock.json @@ -202,6 +202,12 @@ "resolved": "https://registry.npmjs.org/@types/node/-/node-12.7.1.tgz", "integrity": "sha512-aK9jxMypeSrhiYofWWBf/T7O+KwaiAHzM4sveCdWPn71lzUSMimRnKzhXDKfKwV1kWoBo2P1aGgaIYGLf9/ljw==" }, + "@types/normalize-package-data": { + "version": "2.4.0", + "resolved": "https://registry.npmjs.org/@types/normalize-package-data/-/normalize-package-data-2.4.0.tgz", + "integrity": "sha512-f5j5b/Gf71L+dbqxIpQ4Z2WlmI/mPJ0fOkGGmFgtb6sAu97EPczzbS3/tJKxmcYDj55OX6ssqwDAWOHIYDRDGA==", + "dev": true + }, "@types/range-parser": { "version": "1.2.3", "resolved": "https://registry.npmjs.org/@types/range-parser/-/range-parser-1.2.3.tgz", @@ -859,6 +865,23 @@ "unset-value": "^1.0.0" } }, + "caller-callsite": { + "version": "2.0.0", + "resolved": "https://registry.npmjs.org/caller-callsite/-/caller-callsite-2.0.0.tgz", + "integrity": "sha1-hH4PzgoiN1CpoCfFSzNzGtMVQTQ=", + "dev": true, + "requires": { + "callsites": "^2.0.0" + }, + "dependencies": { + "callsites": { + "version": "2.0.0", + "resolved": "https://registry.npmjs.org/callsites/-/callsites-2.0.0.tgz", + "integrity": "sha1-BuuE8A7qQT2oav/vrL/7Ngk7PFA=", + "dev": true + } + } + }, "caller-path": { "version": "0.1.0", "resolved": "https://registry.npmjs.org/caller-path/-/caller-path-0.1.0.tgz", @@ -1803,6 +1826,40 @@ "vary": "^1" } }, + "cosmiconfig": { + "version": "5.2.1", + "resolved": "https://registry.npmjs.org/cosmiconfig/-/cosmiconfig-5.2.1.tgz", + "integrity": "sha512-H65gsXo1SKjf8zmrJ67eJk8aIRKV5ff2D4uKZIBZShbhGSpEmsQOPW/SKMKYhSTrqR7ufy6RP69rPogdaPh/kA==", + "dev": true, + "requires": { + "import-fresh": "^2.0.0", + "is-directory": "^0.3.1", + "js-yaml": "^3.13.1", + "parse-json": "^4.0.0" + }, + "dependencies": { + "js-yaml": { + "version": "3.13.1", + "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-3.13.1.tgz", + "integrity": "sha512-YfbcO7jXDdyj0DGxYVSlSeQNHbD7XPWvrVWeVUujrQEoZzWJIRrCPoyk6kL6IAjAG2IolMK4T0hNUe0HOUs5Jw==", + "dev": true, + "requires": { + "argparse": "^1.0.7", + "esprima": "^4.0.0" + } + }, + "parse-json": { + "version": "4.0.0", + "resolved": "https://registry.npmjs.org/parse-json/-/parse-json-4.0.0.tgz", + "integrity": "sha1-vjX1Qlvh9/bHRxhPmKeIy5lHfuA=", + "dev": true, + "requires": { + "error-ex": "^1.3.1", + "json-parse-better-errors": "^1.0.1" + } + } + } + }, "create-error-class": { "version": "3.0.2", "resolved": "https://registry.npmjs.org/create-error-class/-/create-error-class-3.0.2.tgz", @@ -2139,6 +2196,15 @@ "iconv-lite": "~0.4.13" } }, + "end-of-stream": { + "version": "1.4.1", + "resolved": "https://registry.npmjs.org/end-of-stream/-/end-of-stream-1.4.1.tgz", + "integrity": "sha512-1MkrZNvWTKCaigbn+W15elq2BB/L22nqrSY5DKlo3X6+vclJm8Bb5djXJBmEX6fS3+zCh/F4VBK5Z2KxJt4s2Q==", + "dev": true, + "requires": { + "once": "^1.4.0" + } + }, "error-ex": { "version": "1.3.1", "resolved": "https://registry.npmjs.org/error-ex/-/error-ex-1.3.1.tgz", @@ -3104,6 +3170,249 @@ "ms": "^2.0.0" } }, + "husky": { + "version": "3.0.5", + "resolved": "https://registry.npmjs.org/husky/-/husky-3.0.5.tgz", + "integrity": "sha512-cKd09Jy9cDyNIvAdN2QQAP/oA21sle4FWXjIMDttailpLAYZuBE7WaPmhrkj+afS8Sj9isghAtFvWSQ0JiwOHg==", + "dev": true, + "requires": { + "chalk": "^2.4.2", + "cosmiconfig": "^5.2.1", + "execa": "^1.0.0", + "get-stdin": "^7.0.0", + "is-ci": "^2.0.0", + "opencollective-postinstall": "^2.0.2", + "pkg-dir": "^4.2.0", + "please-upgrade-node": "^3.2.0", + "read-pkg": "^5.1.1", + "run-node": "^1.0.0", + "slash": "^3.0.0" + }, + "dependencies": { + "@babel/code-frame": { + "version": "7.5.5", + "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.5.5.tgz", + "integrity": "sha512-27d4lZoomVyo51VegxI20xZPuSHusqbQag/ztrBC7wegWoQ1nLREPVSKSW8byhTlzTKyNE4ifaTA6lCp7JjpFw==", + "dev": true, + "requires": { + "@babel/highlight": "^7.0.0" + } + }, + "@babel/highlight": { + "version": "7.5.0", + "resolved": "https://registry.npmjs.org/@babel/highlight/-/highlight-7.5.0.tgz", + "integrity": "sha512-7dV4eu9gBxoM0dAnj/BCFDW9LFU0zvTrkq0ugM7pnHEgguOEeOz1so2ZghEdzviYzQEED0r4EAgpsBChKy1TRQ==", + "dev": true, + "requires": { + "chalk": "^2.0.0", + "esutils": "^2.0.2", + "js-tokens": "^4.0.0" + } + }, + "ansi-styles": { + "version": "3.2.1", + "resolved": "https://registry.npmjs.org/ansi-styles/-/ansi-styles-3.2.1.tgz", + "integrity": "sha512-VT0ZI6kZRdTh8YyJw3SMbYm/u+NqfsAxEpWO0Pf9sq8/e94WxxOpPKx9FR1FlyCtOVDNOQ+8ntlqFxiRc+r5qA==", + "dev": true, + "requires": { + "color-convert": "^1.9.0" + } + }, + "chalk": { + "version": "2.4.2", + "resolved": "https://registry.npmjs.org/chalk/-/chalk-2.4.2.tgz", + "integrity": "sha512-Mti+f9lpJNcwF4tWV8/OrTTtF1gZi+f8FqlyAdouralcFWFQWF2+NgCHShjkCb+IFBLq9buZwE1xckQU4peSuQ==", + "dev": true, + "requires": { + "ansi-styles": "^3.2.1", + "escape-string-regexp": "^1.0.5", + "supports-color": "^5.3.0" + } + }, + "ci-info": { + "version": "2.0.0", + "resolved": "https://registry.npmjs.org/ci-info/-/ci-info-2.0.0.tgz", + "integrity": "sha512-5tK7EtrZ0N+OLFMthtqOj4fI2Jeb88C4CAZPu25LDVUgXJ0A3Js4PMGqrn0JU1W0Mh1/Z8wZzYPxqUrXeBboCQ==", + "dev": true + }, + "cross-spawn": { + "version": "6.0.5", + "resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-6.0.5.tgz", + "integrity": "sha512-eTVLrBSt7fjbDygz805pMnstIs2VTBNkRm0qxZd+M7A5XDdxVRWO5MxGBXZhjY4cqLYLdtrGqRf8mBPmzwSpWQ==", + "dev": true, + "requires": { + "nice-try": "^1.0.4", + "path-key": "^2.0.1", + "semver": "^5.5.0", + "shebang-command": "^1.2.0", + "which": "^1.2.9" + } + }, + "execa": { + "version": "1.0.0", + "resolved": "https://registry.npmjs.org/execa/-/execa-1.0.0.tgz", + "integrity": "sha512-adbxcyWV46qiHyvSp50TKt05tB4tK3HcmF7/nxfAdhnox83seTDbwnaqKO4sXRy7roHAIFqJP/Rw/AuEbX61LA==", + "dev": true, + "requires": { + "cross-spawn": "^6.0.0", + "get-stream": "^4.0.0", + "is-stream": "^1.1.0", + "npm-run-path": "^2.0.0", + "p-finally": "^1.0.0", + "signal-exit": "^3.0.0", + "strip-eof": "^1.0.0" + } + }, + "find-up": { + "version": "4.1.0", + "resolved": "https://registry.npmjs.org/find-up/-/find-up-4.1.0.tgz", + "integrity": "sha512-PpOwAdQ/YlXQ2vj8a3h8IipDuYRi3wceVQQGYWxNINccq40Anw7BlsEXCMbt1Zt+OLA6Fq9suIpIWD0OsnISlw==", + "dev": true, + "requires": { + "locate-path": "^5.0.0", + "path-exists": "^4.0.0" + } + }, + "get-stdin": { + "version": "7.0.0", + "resolved": "https://registry.npmjs.org/get-stdin/-/get-stdin-7.0.0.tgz", + "integrity": "sha512-zRKcywvrXlXsA0v0i9Io4KDRaAw7+a1ZpjRwl9Wox8PFlVCCHra7E9c4kqXCoCM9nR5tBkaTTZRBoCm60bFqTQ==", + "dev": true + }, + "get-stream": { + "version": "4.1.0", + "resolved": "https://registry.npmjs.org/get-stream/-/get-stream-4.1.0.tgz", + "integrity": "sha512-GMat4EJ5161kIy2HevLlr4luNjBgvmj413KaQA7jt4V8B4RDsfpHk7WQ9GVqfYyyx8OS/L66Kox+rJRNklLK7w==", + "dev": true, + "requires": { + "pump": "^3.0.0" + } + }, + "is-ci": { + "version": "2.0.0", + "resolved": "https://registry.npmjs.org/is-ci/-/is-ci-2.0.0.tgz", + "integrity": "sha512-YfJT7rkpQB0updsdHLGWrvhBJfcfzNNawYDNIyQXJz0IViGf75O8EBPKSdvw2rF+LGCsX4FZ8tcr3b19LcZq4w==", + "dev": true, + "requires": { + "ci-info": "^2.0.0" + } + }, + "js-tokens": { + "version": "4.0.0", + "resolved": "https://registry.npmjs.org/js-tokens/-/js-tokens-4.0.0.tgz", + "integrity": "sha512-RdJUflcE3cUzKiMqQgsCu06FPu9UdIJO0beYbPhHN4k6apgJtifcoCtT9bcxOpYBtpD2kCM6Sbzg4CausW/PKQ==", + "dev": true + }, + "locate-path": { + "version": "5.0.0", + "resolved": "https://registry.npmjs.org/locate-path/-/locate-path-5.0.0.tgz", + "integrity": "sha512-t7hw9pI+WvuwNJXwk5zVHpyhIqzg2qTlklJOf0mVxGSbe3Fp2VieZcduNYjaLDoy6p9uGpQEGWG87WpMKlNq8g==", + "dev": true, + "requires": { + "p-locate": "^4.1.0" + } + }, + "normalize-package-data": { + "version": "2.5.0", + "resolved": "https://registry.npmjs.org/normalize-package-data/-/normalize-package-data-2.5.0.tgz", + "integrity": "sha512-/5CMN3T0R4XTj4DcGaexo+roZSdSFW/0AOOTROrjxzCG1wrWXEsGbRKevjlIL+ZDE4sZlJr5ED4YW0yqmkK+eA==", + "dev": true, + "requires": { + "hosted-git-info": "^2.1.4", + "resolve": "^1.10.0", + "semver": "2 || 3 || 4 || 5", + "validate-npm-package-license": "^3.0.1" + } + }, + "p-limit": { + "version": "2.2.1", + "resolved": "https://registry.npmjs.org/p-limit/-/p-limit-2.2.1.tgz", + "integrity": "sha512-85Tk+90UCVWvbDavCLKPOLC9vvY8OwEX/RtKF+/1OADJMVlFfEHOiMTPVyxg7mk/dKa+ipdHm0OUkTvCpMTuwg==", + "dev": true, + "requires": { + "p-try": "^2.0.0" + } + }, + "p-locate": { + "version": "4.1.0", + "resolved": "https://registry.npmjs.org/p-locate/-/p-locate-4.1.0.tgz", + "integrity": "sha512-R79ZZ/0wAxKGu3oYMlz8jy/kbhsNrS7SKZ7PxEHBgJ5+F2mtFW2fK2cOtBh1cHYkQsbzFV7I+EoRKe6Yt0oK7A==", + "dev": true, + "requires": { + "p-limit": "^2.2.0" + } + }, + "p-try": { + "version": "2.2.0", + "resolved": "https://registry.npmjs.org/p-try/-/p-try-2.2.0.tgz", + "integrity": "sha512-R4nPAVTAU0B9D35/Gk3uJf/7XYbQcyohSKdvAxIRSNghFl4e71hVoGnBNQz9cWaXxO2I10KTC+3jMdvvoKw6dQ==", + "dev": true + }, + "parse-json": { + "version": "5.0.0", + "resolved": "https://registry.npmjs.org/parse-json/-/parse-json-5.0.0.tgz", + "integrity": "sha512-OOY5b7PAEFV0E2Fir1KOkxchnZNCdowAJgQ5NuxjpBKTRP3pQhwkrkxqQjeoKJ+fO7bCpmIZaogI4eZGDMEGOw==", + "dev": true, + "requires": { + "@babel/code-frame": "^7.0.0", + "error-ex": "^1.3.1", + "json-parse-better-errors": "^1.0.1", + "lines-and-columns": "^1.1.6" + } + }, + "path-exists": { + "version": "4.0.0", + "resolved": "https://registry.npmjs.org/path-exists/-/path-exists-4.0.0.tgz", + "integrity": "sha512-ak9Qy5Q7jYb2Wwcey5Fpvg2KoAc/ZIhLSLOSBmRmygPsGwkVVt0fZa0qrtMz+m6tJTAHfZQ8FnmB4MG4LWy7/w==", + "dev": true + }, + "path-parse": { + "version": "1.0.6", + "resolved": "https://registry.npmjs.org/path-parse/-/path-parse-1.0.6.tgz", + "integrity": "sha512-GSmOT2EbHrINBf9SR7CDELwlJ8AENk3Qn7OikK4nFYAu3Ote2+JYNVvkpAEQm3/TLNEJFD/xZJjzyxg3KBWOzw==", + "dev": true + }, + "pkg-dir": { + "version": "4.2.0", + "resolved": "https://registry.npmjs.org/pkg-dir/-/pkg-dir-4.2.0.tgz", + "integrity": "sha512-HRDzbaKjC+AOWVXxAU/x54COGeIv9eb+6CkDSQoNTt4XyWoIJvuPsXizxu/Fr23EiekbtZwmh1IcIG/l/a10GQ==", + "dev": true, + "requires": { + "find-up": "^4.0.0" + } + }, + "read-pkg": { + "version": "5.2.0", + "resolved": "https://registry.npmjs.org/read-pkg/-/read-pkg-5.2.0.tgz", + "integrity": "sha512-Ug69mNOpfvKDAc2Q8DRpMjjzdtrnv9HcSMX+4VsZxD1aZ6ZzrIE7rlzXBtWTyhULSMKg076AW6WR5iZpD0JiOg==", + "dev": true, + "requires": { + "@types/normalize-package-data": "^2.4.0", + "normalize-package-data": "^2.5.0", + "parse-json": "^5.0.0", + "type-fest": "^0.6.0" + } + }, + "resolve": { + "version": "1.12.0", + "resolved": "https://registry.npmjs.org/resolve/-/resolve-1.12.0.tgz", + "integrity": "sha512-B/dOmuoAik5bKcD6s6nXDCjzUKnaDvdkRyAk6rsmsKLipWj4797iothd7jmmUhWTfinVMU+wc56rYKsit2Qy4w==", + "dev": true, + "requires": { + "path-parse": "^1.0.6" + } + }, + "supports-color": { + "version": "5.5.0", + "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-5.5.0.tgz", + "integrity": "sha512-QjVjwdXIt408MIiAqCX4oUKsgU2EqAGzs2Ppkm4aQYbjm+ZEWEcW4SfFNTr4uMNZma0ey4f5lgLrkB0aX0QMow==", + "dev": true, + "requires": { + "has-flag": "^3.0.0" + } + } + } + }, "iconv-lite": { "version": "0.4.19", "resolved": "https://registry.npmjs.org/iconv-lite/-/iconv-lite-0.4.19.tgz", @@ -3146,6 +3455,27 @@ "integrity": "sha1-SMptcvbGo68Aqa1K5odr44ieKwk=", "dev": true }, + "import-fresh": { + "version": "2.0.0", + "resolved": "https://registry.npmjs.org/import-fresh/-/import-fresh-2.0.0.tgz", + "integrity": "sha1-2BNVwVYS04bGH53dOSLUMEgipUY=", + "dev": true, + "requires": { + "caller-path": "^2.0.0", + "resolve-from": "^3.0.0" + }, + "dependencies": { + "caller-path": { + "version": "2.0.0", + "resolved": "https://registry.npmjs.org/caller-path/-/caller-path-2.0.0.tgz", + "integrity": "sha1-Ro+DBE42mrIBD6xfBs7uFbsssfQ=", + "dev": true, + "requires": { + "caller-callsite": "^2.0.0" + } + } + } + }, "import-lazy": { "version": "2.1.0", "resolved": "https://registry.npmjs.org/import-lazy/-/import-lazy-2.1.0.tgz", @@ -3329,6 +3659,12 @@ } } }, + "is-directory": { + "version": "0.3.1", + "resolved": "https://registry.npmjs.org/is-directory/-/is-directory-0.3.1.tgz", + "integrity": "sha1-YTObbyR1/Hcv2cnYP1yFddwVSuE=", + "dev": true + }, "is-extendable": { "version": "0.1.1", "resolved": "https://registry.npmjs.org/is-extendable/-/is-extendable-0.1.1.tgz", @@ -3819,6 +4155,12 @@ "resolved": "https://registry.npmjs.org/limiter/-/limiter-1.1.4.tgz", "integrity": "sha512-XCpr5bElgDI65vVgstP8TWjv6/QKWm9GU5UG0Pr5sLQ3QLo8NVKsioe+Jed5/3vFOe3IQuqE7DKwTvKQkjTHvg==" }, + "lines-and-columns": { + "version": "1.1.6", + "resolved": "https://registry.npmjs.org/lines-and-columns/-/lines-and-columns-1.1.6.tgz", + "integrity": "sha1-HADHQ7QzzQpOgHWPe2SldEDZ/wA=", + "dev": true + }, "load-json-file": { "version": "2.0.0", "resolved": "https://registry.npmjs.org/load-json-file/-/load-json-file-2.0.0.tgz", @@ -4242,6 +4584,12 @@ "resolved": "https://registry.npmjs.org/negotiator/-/negotiator-0.6.1.tgz", "integrity": "sha1-KzJxhOiZIQEXeyhWP7XnECrNDKk=" }, + "nice-try": { + "version": "1.0.5", + "resolved": "https://registry.npmjs.org/nice-try/-/nice-try-1.0.5.tgz", + "integrity": "sha512-1nh45deeb5olNY7eX82BkPO7SSxR5SSYJiPTrTdFUVYwAl8CKMA5N9PjTYkHiRjisVcxcQ1HXdLhx2qxxJzLNQ==", + "dev": true + }, "nock": { "version": "9.4.3", "resolved": "https://registry.npmjs.org/nock/-/nock-9.4.3.tgz", @@ -6502,6 +6850,12 @@ "mimic-fn": "^1.0.0" } }, + "opencollective-postinstall": { + "version": "2.0.2", + "resolved": "https://registry.npmjs.org/opencollective-postinstall/-/opencollective-postinstall-2.0.2.tgz", + "integrity": "sha512-pVOEP16TrAO2/fjej1IdOyupJY8KDUM1CvsaScRbw6oddvpQoOfGk4ywha0HKKVAD6RkW4x6Q+tNBwhf3Bgpuw==", + "dev": true + }, "optionator": { "version": "0.8.2", "resolved": "https://registry.npmjs.org/optionator/-/optionator-0.8.2.tgz", @@ -6751,6 +7105,15 @@ "find-up": "^1.0.0" } }, + "please-upgrade-node": { + "version": "3.2.0", + "resolved": "https://registry.npmjs.org/please-upgrade-node/-/please-upgrade-node-3.2.0.tgz", + "integrity": "sha512-gQR3WpIgNIKwBMVLkpMUeR3e1/E1y42bqDQZfql+kDeXd8COYfM8PQA4X6y7a8u9Ua9FHmsrrmirW2vHs45hWg==", + "dev": true, + "requires": { + "semver-compare": "^1.0.0" + } + }, "pluralize": { "version": "7.0.0", "resolved": "https://registry.npmjs.org/pluralize/-/pluralize-7.0.0.tgz", @@ -6860,6 +7223,16 @@ "ps-tree": "^1.1.0" } }, + "pump": { + "version": "3.0.0", + "resolved": "https://registry.npmjs.org/pump/-/pump-3.0.0.tgz", + "integrity": "sha512-LwZy+p3SFs1Pytd/jYct4wpv49HiYCqd9Rlc5ZVdk0V+8Yzv6jR5Blk3TRmPL1ft69TxP0IMZGJ+WPFU2BFhww==", + "dev": true, + "requires": { + "end-of-stream": "^1.1.0", + "once": "^1.3.1" + } + }, "punycode": { "version": "1.3.2", "resolved": "https://registry.npmjs.org/punycode/-/punycode-1.3.2.tgz", @@ -7107,6 +7480,12 @@ "path-parse": "^1.0.5" } }, + "resolve-from": { + "version": "3.0.0", + "resolved": "https://registry.npmjs.org/resolve-from/-/resolve-from-3.0.0.tgz", + "integrity": "sha1-six699nWiBvItuZTM17rywoYh0g=", + "dev": true + }, "resolve-url": { "version": "0.2.1", "resolved": "https://registry.npmjs.org/resolve-url/-/resolve-url-0.2.1.tgz", @@ -7147,6 +7526,12 @@ "is-promise": "^2.1.0" } }, + "run-node": { + "version": "1.0.0", + "resolved": "https://registry.npmjs.org/run-node/-/run-node-1.0.0.tgz", + "integrity": "sha512-kc120TBlQ3mih1LSzdAJXo4xn/GWS2ec0l3S+syHDXP9uRr0JAT8Qd3mdMuyjqCzeZktgP3try92cEgf9Nks8A==", + "dev": true + }, "run-parallel": { "version": "1.1.9", "resolved": "https://registry.npmjs.org/run-parallel/-/run-parallel-1.1.9.tgz", @@ -7204,6 +7589,12 @@ "integrity": "sha512-4SJ3dm0WAwWy/NVeioZh5AntkdJoWKxHxcmyP622fOkgHa4z3R0TdBJICINyaSDE6uNwVc8gZr+ZinwZAH4xIA==", "dev": true }, + "semver-compare": { + "version": "1.0.0", + "resolved": "https://registry.npmjs.org/semver-compare/-/semver-compare-1.0.0.tgz", + "integrity": "sha1-De4hahyUGrN+nvsXiPavxf9VN/w=", + "dev": true + }, "semver-diff": { "version": "2.1.0", "resolved": "https://registry.npmjs.org/semver-diff/-/semver-diff-2.1.0.tgz", @@ -7411,6 +7802,12 @@ } } }, + "slash": { + "version": "3.0.0", + "resolved": "https://registry.npmjs.org/slash/-/slash-3.0.0.tgz", + "integrity": "sha512-g9Q1haeby36OSStwb4ntCGGGaKsaVSjQ68fBxoQcutl5fS1vuY18H3wSt3jFyFtrkx+Kz0V1G85A4MyAdDMi2Q==", + "dev": true + }, "slice-ansi": { "version": "1.0.0", "resolved": "https://registry.npmjs.org/slice-ansi/-/slice-ansi-1.0.0.tgz", @@ -8141,6 +8538,12 @@ "integrity": "sha512-0fr/mIH1dlO+x7TlcMy+bIDqKPsw/70tVyeHW787goQjhmqaZe10uwLujubK9q9Lg6Fiho1KUKDYz0Z7k7g5/g==", "dev": true }, + "type-fest": { + "version": "0.6.0", + "resolved": "https://registry.npmjs.org/type-fest/-/type-fest-0.6.0.tgz", + "integrity": "sha512-q+MB8nYR1KDLrgr4G5yemftpMC7/QLqVndBmEEdqzmNj5dcFOO4Oo8qlwZE3ULT3+Zim1F8Kq4cBnikNhlCMlg==", + "dev": true + }, "type-is": { "version": "1.6.16", "resolved": "https://registry.npmjs.org/type-is/-/type-is-1.6.16.tgz", diff --git a/package.json b/package.json index 7b3a0e8d..6ac22d65 100755 --- a/package.json +++ b/package.json @@ -50,6 +50,7 @@ "chai": "^4.1.2", "chai-http": "^4.0.0", "co-mocha": "^1.2.2", + "husky": "^3.0.5", "mocha": "^5.2.0", "mocha-prepare": "^0.1.0", "nock": "^9.4.3", @@ -64,5 +65,10 @@ "env": [ "mocha" ] + }, + "husky": { + "hooks": { + "pre-commit": "npm run lint" + } } } diff --git a/src/services/ReviewService.js b/src/services/ReviewService.js index 08cb6c3a..96c3f734 100644 --- a/src/services/ReviewService.js +++ b/src/services/ReviewService.js @@ -2,19 +2,19 @@ * Review Service */ -const errors = require('common-errors'); -const _ = require('lodash'); -const uuid = require('uuid/v4'); -const joi = require('joi'); -const logger = require('winston'); +const errors = require('common-errors') +const _ = require('lodash') +const uuid = require('uuid/v4') +const joi = require('joi') +const logger = require('winston') -const dbhelper = require('../common/dbhelper'); -const helper = require('../common/helper'); -const { originator, mimeType, events } = require('../../constants').busApiMeta; -const HelperService = require('./HelperService'); -const SubmissionService = require('./SubmissionService'); +const dbhelper = require('../common/dbhelper') +const helper = require('../common/helper') +const { originator, mimeType, events } = require('../../constants').busApiMeta +const HelperService = require('./HelperService') +const SubmissionService = require('./SubmissionService') -const table = 'Review'; +const table = 'Review' /** * Function to get review based on ID from DynamoDB @@ -22,16 +22,16 @@ const table = 'Review'; * @param {Number} reviewId reviewId which need to be retrieved * @return {Object} Data retrieved from database */ -function* _getReview(reviewId) { +function * _getReview (reviewId) { // Construct filter to retrieve record from Database const filter = { TableName: table, Key: { id: reviewId } - }; - const result = yield dbhelper.getRecord(filter); - return result.Item; + } + const result = yield dbhelper.getRecord(filter) + return result.Item } /** @@ -40,39 +40,39 @@ function* _getReview(reviewId) { * @param {Number} reviewId reviewId which need to be found * @return {Object} Data found from database or ES */ -function* getReview(authUser, reviewId) { - let review; +function * getReview (authUser, reviewId) { + let review const response = yield helper.fetchFromES( { id: reviewId }, helper.camelize(table) - ); + ) if (response.total === 0) { - logger.info(`Couldn't find review ${reviewId} in ES. Checking db`); - review = yield _getReview(reviewId); - logger.debug(`Review: ${review}`); + logger.info(`Couldn't find review ${reviewId} in ES. Checking db`) + review = yield _getReview(reviewId) + logger.debug(`Review: ${review}`) if (!review) { throw new errors.HttpStatusError( 404, `Review with ID = ${reviewId} is not found` - ); + ) } } else { - review = response.rows[0]; + review = response.rows[0] } // Fetch submission without review and review summations const submission = yield SubmissionService._getSubmission( review.submissionId, false - ); - logger.info('Check User access before returning the review'); - yield helper.checkReviewGetAccess(authUser, submission); + ) + logger.info('Check User access before returning the review') + yield helper.checkReviewGetAccess(authUser, submission) // Return the review - return review; + return review } getReview.schema = { @@ -81,15 +81,15 @@ getReview.schema = { .string() .uuid() .required() -}; +} /** * Function to list reviews from Elastic Search * @param {Object} query Query filters passed in HTTP request * @return {Object} Data fetched from ES */ -function* listReviews(query) { - return yield helper.fetchFromES(query, helper.camelize(table)); +function * listReviews (query) { + return yield helper.fetchFromES(query, helper.camelize(table)) } const listReviewsQuerySchema = { @@ -102,7 +102,7 @@ const listReviewsQuerySchema = { page: joi.id(), perPage: joi.pageSize(), orderBy: joi.sortOrder() -}; +} listReviewsQuerySchema.sortBy = joi .string() @@ -112,25 +112,25 @@ listReviewsQuerySchema.sortBy = joi 'perPage', 'orderBy' ]) - ); + ) listReviews.schema = { query: joi .object() .keys(listReviewsQuerySchema) .with('orderBy', 'sortBy') -}; +} /** * Function to create review in database * @param {Object} entity Data to be inserted * @return {Promise} */ -function* createReview(authUser, entity) { +function * createReview (authUser, entity) { // Check the validness of references using Helper function - yield HelperService._checkRef(entity); + yield HelperService._checkRef(entity) - const currDate = new Date().toISOString(); + const currDate = new Date().toISOString() const item = _.extend( { @@ -142,15 +142,15 @@ function* createReview(authUser, entity) { status: entity.status || 'completed' }, entity - ); + ) // Prepare record to be inserted const record = { TableName: table, Item: item - }; + } - yield dbhelper.insertRecord(record); + yield dbhelper.insertRecord(record) // Push Review created event to Bus API // Request body for Posting to Bus API @@ -165,14 +165,14 @@ function* createReview(authUser, entity) { }, item ) - }; + } // Post to Bus API using Client - yield helper.postToBusApi(reqBody); + yield helper.postToBusApi(reqBody) // Inserting records in DynamoDB doesn't return any response // Hence returning the same entity to be in compliance with Swagger - return item; + return item } createReview.schema = { @@ -201,7 +201,7 @@ createReview.schema = { metadata: joi.object() }) .required() -}; +} /* * Function to update review in the database @@ -211,19 +211,19 @@ createReview.schema = { * @param {Object} entity Data to be updated * @return {Promise} **/ -function* _updateReview(authUser, reviewId, entity) { - const exist = yield _getReview(reviewId); +function * _updateReview (authUser, reviewId, entity) { + const exist = yield _getReview(reviewId) if (!exist) { throw new errors.HttpStatusError( 404, `Review with ID = ${reviewId} is not found` - ); + ) } // Check the validness of references using Helper function - yield HelperService._checkRef(entity); + yield HelperService._checkRef(entity) - const currDate = new Date().toISOString(); + const currDate = new Date().toISOString() // Record used for updating in Database const record = { @@ -247,20 +247,20 @@ function* _updateReview(authUser, reviewId, entity) { ExpressionAttributeNames: { '#st': 'status' } - }; + } // If metadata exists, add it to the update expression if (entity.metadata || exist.metadata) { record['UpdateExpression'] = - record['UpdateExpression'] + `, metadata = :ma`; + record['UpdateExpression'] + `, metadata = :ma` record['ExpressionAttributeValues'][':ma'] = _.merge( {}, exist.metadata, entity.metadata - ); + ) } - yield dbhelper.updateRecord(record); + yield dbhelper.updateRecord(record) // Push Review updated event to Bus API // Request body for Posting to Bus API @@ -278,17 +278,17 @@ function* _updateReview(authUser, reviewId, entity) { }, entity ) - }; + } // Post to Bus API using Client - yield helper.postToBusApi(reqBody); + yield helper.postToBusApi(reqBody) // Updating records in DynamoDB doesn't return any response // Hence returning the response which will be in compliance with Swagger return _.extend(exist, entity, { updated: currDate, updatedBy: authUser.handle || authUser.sub - }); + }) } /** @@ -298,8 +298,8 @@ function* _updateReview(authUser, reviewId, entity) { * @param {Object} entity Data to be updated * @return {Promise} */ -function* updateReview(authUser, reviewId, entity) { - return yield _updateReview(authUser, reviewId, entity); +function * updateReview (authUser, reviewId, entity) { + return yield _updateReview(authUser, reviewId, entity) } updateReview.schema = { @@ -329,7 +329,7 @@ updateReview.schema = { metadata: joi.object() }) .required() -}; +} /** * Function to patch review in database @@ -338,8 +338,8 @@ updateReview.schema = { * @param {Object} entity Data to be patched * @return {Promise} */ -function* patchReview(authUser, reviewId, entity) { - return yield _updateReview(authUser, reviewId, entity); +function * patchReview (authUser, reviewId, entity) { + return yield _updateReview(authUser, reviewId, entity) } patchReview.schema = { @@ -357,20 +357,20 @@ patchReview.schema = { status: joi.reviewStatus(), metadata: joi.object() }) -}; +} /** * Function to delete review from database * @param {Number} reviewId reviewId which need to be deleted * @return {Promise} */ -function* deleteReview(reviewId) { - const exist = yield _getReview(reviewId); +function * deleteReview (reviewId) { + const exist = yield _getReview(reviewId) if (!exist) { throw new errors.HttpStatusError( 404, `Review with ID = ${reviewId} is not found` - ); + ) } // Filter used to delete the record @@ -379,9 +379,9 @@ function* deleteReview(reviewId) { Key: { id: reviewId } - }; + } - yield dbhelper.deleteRecord(filter); + yield dbhelper.deleteRecord(filter) // Push Review deleted event to Bus API // Request body for Posting to Bus API @@ -394,10 +394,10 @@ function* deleteReview(reviewId) { resource: helper.camelize(table), id: reviewId } - }; + } // Post to Bus API using Client - yield helper.postToBusApi(reqBody); + yield helper.postToBusApi(reqBody) } deleteReview.schema = { @@ -405,7 +405,7 @@ deleteReview.schema = { .string() .uuid() .required() -}; +} module.exports = { getReview, @@ -414,4 +414,4 @@ module.exports = { updateReview, patchReview, deleteReview -}; +}