Add review.legacyReviewId filter to GET /submissions endpoint

Author: meshde

docs/swagger.yaml

@@ -70,6 +70,7 @@ paths:
         - $ref: '#/parameters/filterSubmissionLegacyUploadId'
         - $ref: '#/parameters/filterSubmissionSubmissionPhaseId'
         - $ref: '#/parameters/filterSubmissionReviewScore'
+        - $ref: '#/parameters/filterSubmissionReviewLegacyReviewId'
         - $ref: '#/parameters/filterSubmissionReviewTypeId'
         - $ref: '#/parameters/filterSubmissionReviewReviewerId'
         - $ref: '#/parameters/filterSubmissionReviewScoreCardId'
@@ -1614,6 +1615,13 @@ parameters:
     required: false
     type: integer
 
+  filterSubmissionReviewLegacyReviewId:
+    in: query
+    name: review.legacyReviewId
+    description: The legacy review id filter of the reviews associated with the submission.
+    required: false
+    type: string
+
   filterSubmissionReviewTypeId:
     in: query
     name: review.typeId

scripts/data/Submissions.json

@@ -9,6 +9,7 @@
       {
         "id": "d24d4180-65aa-42ec-a945-5fd21dec0501",
         "score": 95.5,
+        "legacyReviewId": "6b4faff1-7685-4866-a2e3-24afabf5c2c1",
         "typeId": "c56a4180-65aa-42ec-a945-5fd21dec0503",
         "reviewerId": "c23a4180-65aa-42ec-a945-5fd21dec0503",
         "scoreCardId": 123456789,
@@ -25,6 +26,7 @@
       {
         "id": "d24d4180-65aa-42ec-a945-5fd21dec0502",
         "score": 92.0,
+        "legacyReviewId": "6b4faff1-7685-4866-a2e3-24afabf5c2c2",
         "typeId": "c56a4180-65aa-42ec-a945-5fd21dec0501",
         "reviewerId": "c23a4180-65aa-42ec-a945-5fd21dec0503",
         "scoreCardId": 123456789,
@@ -78,6 +80,7 @@
        {
         "id": "d24d4180-65aa-42ec-a945-5fd21dec0503",
         "score": 80.83,
+        "legacyReviewId": "6b4faff1-7685-4866-a2e3-24afabf5c2c9",
         "typeId": "c56a4180-65aa-42ec-a945-5fd21dec0503",
         "reviewerId": "c23a4180-65aa-42ec-a945-5fd21dec0503",
         "scoreCardId": 123456789,
@@ -94,6 +97,7 @@
       {
         "id": "d24d4180-65aa-42ec-a945-5fd21dec0504",
         "score": 85.62,
+        "legacyReviewId": "6b4faff1-7685-4866-a2e3-24afabf5c2c8",
         "typeId": "c56a4180-65aa-42ec-a945-5fd21dec0503",
         "reviewerId": "c23a4180-65aa-42ec-a945-5fd21dec0502",
         "scoreCardId": 123456789,
@@ -110,6 +114,7 @@
       {
         "id": "d24d4180-65aa-42ec-a945-5fd21dec0505",
         "score": 100,
+        "legacyReviewId": "6b4faff1-7685-4866-a2e3-24afabf5c2c7",
         "typeId": "f28b2725-ef90-4495-af59-ceb2bd98fc10",
         "reviewerId": "c23a4180-65aa-42ec-a945-5fd21dec0503",
         "scoreCardId": 123456789,
@@ -139,6 +144,7 @@
       {
         "id": "d24d4180-65aa-42ec-a945-5fd21dec0506",
         "score": 65.0,
+        "legacyReviewId": "6b4faff1-7685-4866-a2e3-24afabf5c2c3",
         "typeId": "c56a4180-65aa-42ec-a945-5fd21dec0503",
         "reviewerId": "c23a4180-65aa-42ec-a945-5fd21dec0503",
         "scoreCardId": 123456789,
@@ -155,6 +161,7 @@
       {
         "id": "d24d4180-65aa-42ec-a945-5fd21dec0507",
         "score": 68.0,
+        "legacyReviewId": "6b4faff1-7685-4866-a2e3-24afabf5c2c4",
         "typeId": "c56a4180-65aa-42ec-a945-5fd21dec0503",
         "reviewerId": "c23a4180-65aa-42ec-a945-5fd21dec0502",
         "scoreCardId": 123456789,
@@ -184,6 +191,7 @@
       {
         "id": "d24d4180-65aa-42ec-a945-5fd21dec0508",
         "score": 100,
+        "legacyReviewId": "6b4faff1-7685-4866-a2e3-24afabf5c2c5",
         "typeId": "f28b2725-ef90-4495-af59-ceb2bd98fc10",
         "reviewerId": "c23a4180-65aa-42ec-a945-5fd21dec0503",
         "scoreCardId": 123456789,
@@ -213,6 +221,7 @@
       {
         "id": "d24d4180-65aa-42ec-a945-5fd21dec0509",
         "score": 92.5,
+        "legacyReviewId": "6b4faff1-7685-4866-a2e3-24afabf5c2c6",
         "typeId": "c56a4180-65aa-42ec-a945-5fd21dec0503",
         "reviewerId": "c23a4180-65aa-42ec-a945-5fd21dec0503",
         "scoreCardId": 123456789,

src/services/SubmissionService.js

@@ -205,6 +205,7 @@ const listSubmissionsQuerySchema = {
   perPage: joi.pageSize(),
   orderBy: joi.sortOrder(),
   'review.score': joi.score(),
+  'review.legacyReviewId': joi.string().uuid(),
   'review.typeId': joi.string().uuid(),
   'review.reviewerId': joi.string().uuid(),
   'review.scoreCardId': joi.id(),

test/common/testData.js

@@ -185,6 +185,7 @@ const testSubmissionsES = {
        review: [ {
          id: 'd24d4180-65aa-42ec-a945-5fd21dec0502',
          score: 92,
+         legacyReviewId: '6b4faff1-7685-4866-a2e3-24afabf5c2c1',
          reviewerId: 'c23a4180-65aa-42ec-a945-5fd21dec0503',
          submissionId: 'a12a4180-65aa-42ec-a945-5fd21dec0501',
          scoreCardId: 123456789,
@@ -216,6 +217,7 @@ const testSubmissionsES = {
        review: [ {
          id: 'd24d4180-65aa-42ec-a945-5fd21dec0502',
          score: 92,
+         legacyReviewId: '6b4faff1-7685-4866-a2e3-24afabf5c2c1',
          reviewerId: 'c23a4180-65aa-42ec-a945-5fd21dec0503',
          submissionId: 'a12a4180-65aa-42ec-a945-5fd21dec0501',
          scoreCardId: 123456789,
@@ -247,6 +249,7 @@ const testSubmissionsES = {
        review: [ {
          id: 'd24d4180-65aa-42ec-a945-5fd21dec0502',
          score: 92,
+         legacyReviewId: '6b4faff1-7685-4866-a2e3-24afabf5c2c1',
          reviewerId: 'c23a4180-65aa-42ec-a945-5fd21dec0503',
          submissionId: 'a12a4180-65aa-42ec-a945-5fd21dec0501',
          scoreCardId: 123456789,
@@ -278,6 +281,7 @@ const testSubmissionsES = {
        review: [ {
          id: 'd24d4180-65aa-42ec-a945-5fd21dec0502',
          score: 92,
+         legacyReviewId: '6b4faff1-7685-4866-a2e3-24afabf5c2c1',
          reviewerId: 'c23a4180-65aa-42ec-a945-5fd21dec0503',
          submissionId: 'a12a4180-65aa-42ec-a945-5fd21dec0501',
          scoreCardId: 123456789,
@@ -309,6 +313,7 @@ const testSubmissionsES = {
        review: [ {
          id: 'd24d4180-65aa-42ec-a945-5fd21dec0502',
          score: 92,
+         legacyReviewId: '6b4faff1-7685-4866-a2e3-24afabf5c2c1',
          reviewerId: 'c23a4180-65aa-42ec-a945-5fd21dec0503',
          submissionId: 'a12a4180-65aa-42ec-a945-5fd21dec0501',
          scoreCardId: 123456789,