Skip to content

Fix for Community App Issue #3520 Open New Tab for Payments #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gets0ul
Copy link
Collaborator

@gets0ul gets0ul commented Jan 9, 2020

topcoder-platform/community-app#3520

Add support to newly added openNewTab attribute in community-app config so a secondary menu link
can be opened in a new tab.

Copy link
Collaborator

@luizrrodrigues luizrrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please check: $15 | Open new tab for "Payments" community-app#3520 (comment)

  2. Please remove dist/.. change from your MR

…so a secondary menu link can be opened in a new tab.
@gets0ul gets0ul force-pushed the comm_app_issue_3520 branch from 2c688e8 to 1e43bed Compare January 14, 2020 20:15
@luizrrodrigues luizrrodrigues self-assigned this Jan 15, 2020
@luizrrodrigues luizrrodrigues self-requested a review January 15, 2020 01:14
@luizrrodrigues luizrrodrigues merged commit 11819dc into topcoder-platform:nav-bugbash-2 Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants