Skip to content

Contact Details field mapping #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SathyaJayabal opened this issue Nov 2, 2021 · 2 comments · May be fixed by #13
Closed

Contact Details field mapping #8

SathyaJayabal opened this issue Nov 2, 2021 · 2 comments · May be fixed by #13
Assignees
@SathyaJayabal
Labels
P1 QA Pass on Dev
Milestone
v1.0.0

Comments

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Nov 2, 2021 •
edited
Loading

The field trait mapping should be the below:

Field Name Expected Actual/Current Implementation
Address Line 1 basic_info -> addresses -> streetAddr1 basic_info -> addresses -> streetAddr1
Address Line 2 basic_info -> addresses -> streetAddr2 basic_info -> addresses -> streetAddr2
City / District basic_info -> addresses -> city connect_info -> city
State / Province basic_info -> addresses -> stateCode connect_info -> state
Zip / Postal Code basic_info -> addresses -> zip connect_info -> zip
Country basic_info -> country connect_info -> country
Time Zone connect_info -> timeZone connect_info -> timeZone
Working Hours Start connect_info -> workingHourStart connect_info -> workingHourStart
Working Hours End connect_info -> workingHourEnd connect_info -> workingHourEnd

@vikasrohit @rakibansary @sushilshinde @Oanh-and-only-Oanh , Some of the data is present in both basic_info and connect_info (City, State , Zip and Country). At present these are mapped to the connect_info traits. I think they should be mapped to the basic_info traits as these are more visible to the new user (from the profile settings page on community app https://www.topcoder-dev.com/settings/profile) when compared to the connect profile page https://connect.topcoder-dev.com/settings/profile). Another reason is that city and state are grouped together with the addresses in the front end and it makes more sense to store them in the basic info traits addresses field.

Screenshot 2021-11-02 at 12 52 34 PM
@rakibansary rakibansary linked a pull request Nov 2, 2021 that will close this issue
fixed mapping. #13
Open
@dashu-baba dashu-baba mentioned this issue Nov 2, 2021
Open
@SathyaJayabal SathyaJayabal changed the title Contact Details field source Contact Details field mapping Nov 2, 2021
@SathyaJayabal
Copy link
Collaborator Author

@rakibansary , country value is not getting updated in basic_info traits and is only saving to the connect_info traits. The city state and zip ate getting saved to both basic_info and connect_info which is fine.

rakibansary added a commit that referenced this issue Nov 3, 2021
@rakibansary
fix: #8
bad773e 
* save country as a basic_info trait
@SathyaJayabal
Copy link
Collaborator Author

verified on dev
Screenshot 2021-11-03 at 7 42 11 PM

rakibansary added a commit that referenced this issue Nov 3, 2021
@rakibansary
fix: #8
2e2c1e4 
* save country as a basic_info trait
@SathyaJayabal SathyaJayabal added this to the v1.0.0 milestone Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SathyaJayabal SathyaJayabal

Labels
P1 QA Pass on Dev
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

fixed mapping. dashu-baba/micro-frontends-onboarding-app
2 participants
@rakibansary @SathyaJayabal