Skip to content

[$80] [iOS][Android] when previous page popup so it's hide behind the page per count button #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LieutenantRoger opened this issue Nov 28, 2021 · 14 comments

Comments

@LieutenantRoger
Copy link
Collaborator

Steps to Reproduce

  1. Go to the https://platform.topcoder.com/earn/find/challenges
  2. Scroll down and click on the next till get the previous page
  3. Observer when previous page popup so it's hide behind the page per count button

Actual Result(s)
when previous page popup so it's hide behind the page per count button

Expected Result(s)
each button should be aligned properly

Screen shot
20211029_215148

Environment Details

**Device(s):** Iphone 7
**Operating System:** iOS 14.7.1
**Browser(s):** safari 14
@LieutenantRoger LieutenantRoger changed the title [iOS][Android] when previous page popup so it's hide behind the page per count button [$5] [iOS][Android] when previous page popup so it's hide behind the page per count button Nov 30, 2021
@LieutenantRoger
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/871e1015-39f3-47cb-a692-1dac541d2e50 has been created for this ticket.

This is an automated message for lieutenantroger via Topcoder X

@LieutenantRoger
Copy link
Collaborator Author

@nqviet Please let's use this ticket as the responsive fix. :)

I have reviewed your PR: https://github.com/topcoder-platform/micro-frontends-challenges-app/pull/280/files

Couple of issues:

Under mobile view:

  1. Can we have some padding here in iOS screen: https://monosnap.com/file/CwogKK55RFyGV58JRhPmSZAaLcW1gA
    2
vvv.mp4

When we switch to another page, the mobile view seems will be stretched firstly, then rezied to mobile. Please refer to the above recording.

Under iPad view:

  1. The view seems will be stretched as well if we visit the second page, when we reach the four page, the UI element seems not aligned, please see the operations i have made in this video.
vvveee.mp4
  1. Also please refer to above video recording, the pagination indicator seems overlapped still under iPad view.

  2. Similarly for the banner, please add some padding for top and bottom : https://monosnap.com/file/J2uqFtalgne1dXyeNr4ngQ5MQhMlQQ

@LieutenantRoger LieutenantRoger changed the title [$5] [iOS][Android] when previous page popup so it's hide behind the page per count button [$80] [iOS][Android] when previous page popup so it's hide behind the page per count button Dec 1, 2021
@LieutenantRoger
Copy link
Collaborator Author

@nqviet please assign yourself for this ticket, I seems not able to assign you as I can't find your github id in the assigee search box.

@nqviet
Copy link
Contributor

nqviet commented Dec 1, 2021

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@nqviet 🛑 you have some issues assigned which are not completed yet, see #258.

As per our Bug Bash rules you may work only at one issue at a time.
Please, complete other issues first or unassign yourself before picking up a new issue.

@LieutenantRoger
Copy link
Collaborator Author

LieutenantRoger commented Dec 1, 2021

@nqviet I added Review For Review label for another ticket, please try one more time to see if this work, if the bot still doesn't allow you to assign, please unassign another ticket, we have logs, I will assign you back when we close that ticket.

@nqviet
Copy link
Contributor

nqviet commented Dec 1, 2021

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@nqviet ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@LieutenantRoger
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/871e1015-39f3-47cb-a692-1dac541d2e50 has been assigned to nqv2018.

This is an automated message for lieutenantroger via Topcoder X

@nqviet nqviet mentioned this issue Dec 1, 2021
@nqviet
Copy link
Contributor

nqviet commented Dec 1, 2021

@bug-bash-helper #280 is ready for review

and topcoder-archive/topcoder-platform-micro-frontends-earn-app#213

@bug-bash-hunt-helper
Copy link

@nqviet ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

@codejamtc
Copy link
Collaborator

Fixed 🆗
bandicam 2021-12-03 22-36-15-342
bandicam 2021-12-03 22-34-47-273
bandicam 2021-12-03 22-36-07-845
bandicam 2021-12-03 22-36-12-670

@codejamtc
Copy link
Collaborator

Fixed in Prod 🆗
bandicam 2021-12-07 10-37-16-453
bandicam 2021-12-07 10-37-49-425
bandicam 2021-12-07 10-37-10-266

@LieutenantRoger
Copy link
Collaborator Author

Payment task has been updated: https://www.topcoder.com/challenges/871e1015-39f3-47cb-a692-1dac541d2e50
Payments Complete
Winner: nqv2018
Copilot: lieutenantroger
Challenge 871e1015-39f3-47cb-a692-1dac541d2e50 has been paid and closed.

This is an automated message for lieutenantroger via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants