Skip to content

Groups API getGroup and updateGroup aren't working for inactive groups with M2M #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks
rootelement opened this issue Jun 15, 2020 · 4 comments
Open
5 tasks

Comments

@rootelement
Copy link

rootelement commented Jun 15, 2020

These calls should allow an M2M with the right scopes to act just as an admin can.

currentUser !== 'M2M' && helper.hasAdminRole(currentUser)

const isAdmin = currentUser !== 'M2M' && helper.hasAdminRole(currentUser)

I believe the update is:
currentUser === 'M2M' || helper.hasAdminRole(currentUser)

But please confirm and test.

  • Make sure you pass lint.
  • Please confirm the swagger is up to date and valid (can be loaded into editor.swagger.io)
  • Make sure any necessary postman updates are made
  • If there are tests, please add/update tests for this
  • Make a PR against develop.

cc @cwdcwd

@rootelement
Copy link
Author

FYI - i don't think this has really ever been an issue for anyone else because I'm bringing legacy groups forward with a script and I was creating them as inactive, so i couldn't find them afterward.

@bountyC0d3r
Copy link
Collaborator

by design the group update was only done by the admin only and not by the m2m

@rootelement
Copy link
Author

Ok, i'll conceed the Update part. But the GET won't allow an M2M to get Inactive groups?

@rootelement rootelement changed the title Groups API getGroup and updateGroup aren't working for inactive groups with M2M [$20] Groups API getGroup and updateGroup aren't working for inactive groups with M2M Jun 16, 2020
@bountyC0d3r
Copy link
Collaborator

@rootelement I made changes where you can get the inactive groups in getGroups call

@rootelement rootelement changed the title [$20] Groups API getGroup and updateGroup aren't working for inactive groups with M2M Groups API getGroup and updateGroup aren't working for inactive groups with M2M Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants