Skip to content

Commit 752e119

Browse files
authored
Merge pull request #34 from topcoder-platform/PROD-2585_ui-assessment-screen
PROD-2585 - Fix issue with fcc reserved & get help link
2 parents cb6d7d6 + 52f5f76 commit 752e119

File tree

4 files changed

+19
-53
lines changed

4 files changed

+19
-53
lines changed

client/src/templates/Challenges/classic/editor.tsx

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ interface EditorProps {
109109
usesMultifileEditor: boolean;
110110
isChallengeCompleted: boolean;
111111
testsRunning: boolean;
112+
showRightsReserved?: boolean;
112113
}
113114

114115
// TODO: this is grab bag of unrelated properties. There's no need for them to
@@ -1128,16 +1129,18 @@ const Editor = (props: EditorProps): JSX.Element => {
11281129
theme={editorTheme}
11291130
/>
11301131
</span>
1131-
<div className='all-rights-link'>
1132-
<a
1133-
href='https://www.freecodecamp.org/'
1134-
target='_blank'
1135-
rel='noreferrer'
1136-
>
1137-
© {currentYear}, freeCodeCamp. All rights reserved.
1138-
<ExternalLink />
1139-
</a>
1140-
</div>
1132+
{props.showRightsReserved && (
1133+
<div className='all-rights-link'>
1134+
<a
1135+
href='https://www.freecodecamp.org/'
1136+
target='_blank'
1137+
rel='noreferrer'
1138+
>
1139+
© {currentYear}, freeCodeCamp. All rights reserved.
1140+
<ExternalLink />
1141+
</a>
1142+
</div>
1143+
)}
11411144
</Suspense>
11421145
);
11431146
};

client/src/templates/Challenges/classic/multifile-editor.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ interface MultifileEditorProps {
4242
resizeProps: ResizeProps;
4343
title: string;
4444
showProjectPreview: boolean;
45+
showRightsReserved?: boolean;
4546
usesMultifileEditor: boolean;
4647
visibleEditors: {
4748
indexhtml?: boolean;
@@ -121,7 +122,7 @@ const MultifileEditor = (props: MultifileEditorProps) => {
121122
>
122123
<ReflexElement flex={10} {...reflexProps} {...resizeProps}>
123124
<ReflexContainer orientation='vertical'>
124-
{editorAndSplitterKeys.map(key => {
125+
{editorAndSplitterKeys.map((key, i) => {
125126
const isSplitter = key.endsWith('-splitter');
126127
if (isSplitter) {
127128
return (
@@ -147,6 +148,7 @@ const MultifileEditor = (props: MultifileEditorProps) => {
147148
title={title}
148149
usesMultifileEditor={usesMultifileEditor}
149150
showProjectPreview={showProjectPreview}
151+
showRightsReserved={props.showRightsReserved && !i}
150152
/>
151153
</ReflexElement>
152154
);

client/src/templates/Challenges/classic/show.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ class ShowClassic extends Component<ShowClassicProps, ShowClassicState> {
345345
);
346346
}
347347

348-
renderEditor() {
348+
renderEditor(hasEditableBoundaries?: boolean) {
349349
const {
350350
pageContext: {
351351
projectPreview: { showProjectPreview }
@@ -376,6 +376,7 @@ class ShowClassic extends Component<ShowClassicProps, ShowClassicState> {
376376
title={title}
377377
usesMultifileEditor={usesMultifileEditor}
378378
showProjectPreview={showProjectPreview}
379+
showRightsReserved={hasEditableBoundaries}
379380
/>
380381
)
381382
);
@@ -465,7 +466,7 @@ class ShowClassic extends Component<ShowClassicProps, ShowClassicState> {
465466
block={block}
466467
challengeFiles={challengeFiles}
467468
challengeType={challengeType}
468-
editor={this.renderEditor()}
469+
editor={this.renderEditor(hasEditableBoundaries)}
469470
hasEditableBoundaries={hasEditableBoundaries}
470471
hasNotes={!!notes}
471472
hasPreview={this.hasPreview()}

client/src/templates/Challenges/components/tool-panel.tsx

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import {
22
Button,
3-
DropdownButton,
4-
MenuItem
53
} from '@freecodecamp/react-bootstrap';
64
import React from 'react';
75
import { useTranslation } from 'react-i18next';
@@ -68,11 +66,7 @@ function ToolPanel({
6866
isMobile,
6967
isSignedIn,
7068
isRunningTests,
71-
openHelpModal,
72-
openVideoModal,
7369
openResetModal,
74-
guideUrl,
75-
videoUrl,
7670
challengeIsCompleted,
7771
submitChallenge
7872
}: ToolPanelProps) {
@@ -121,40 +115,6 @@ function ToolPanel({
121115
{isMobile ? t('buttons.reset') : t('buttons.reset-code')}
122116
</Button>
123117
)}
124-
<DropdownButton
125-
bsStyle='link'
126-
block={false}
127-
className='btn-invert'
128-
id='get-help-dropdown'
129-
title={isMobile ? t('buttons.help') : t('buttons.get-help')}
130-
>
131-
{guideUrl ? (
132-
<MenuItem
133-
bsStyle='primary'
134-
className='btn-invert'
135-
href={guideUrl}
136-
target='_blank'
137-
>
138-
{t('buttons.get-hint')}
139-
</MenuItem>
140-
) : null}
141-
{videoUrl ? (
142-
<MenuItem
143-
bsStyle='primary'
144-
className='btn-invert'
145-
onClick={openVideoModal}
146-
>
147-
{t('buttons.watch-video')}
148-
</MenuItem>
149-
) : null}
150-
<MenuItem
151-
bsStyle='primary'
152-
className='btn-invert'
153-
onClick={openHelpModal}
154-
>
155-
{t('buttons.ask-for-help')}
156-
</MenuItem>
157-
</DropdownButton>
158118
</div>
159119
);
160120
}

0 commit comments

Comments
 (0)