-
Notifications
You must be signed in to change notification settings - Fork 0
Universal nav integration updates #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jmgasper The question about user fields. Universal Nav displays user initials at the top of the page. JWT token doesn't contain user initials. I've also looked at a member payload and there are no user initails. In the challenge the tc-website (topcoder-archive/tc-website@e51ce08) is mentioned for reference. In this commit you can see that user initials are s calculated as the first two letter from user handle. This is not correct and perhaps this is by mistake. Please let me know if you are ok with that. Updated: I implemented issue 1 and issues 2. I am waiting for the commit in the forums-theme. Let me know when I can push the code in repos (forum, Topcoder plugin and theme) |
I think using the first two from the user's handle is fine here, thanks. |
@jmgasper Please apply PRS:
Thanks! Configuration
TestingPlease let me know if you have any questuions. |
@atelomycterus - All looks good, thanks! |
Issue 1
I've integrated Tool Navigation and the Footer Navigation with a hard-coded user in the forum theme.
We should add and fix several files in the forums repo(https://github.com/topcoder-platform/forums) to implement all requiremets.
'We have to ensure that it displays properly for: Anonymous (not logged in) user + Logged in user'
The forums theme uses Smarty templates. Smarty is a web template system written in PHP, facilitating the separation of presentation (HTML/CSS) from application logic. Vanilla Forums uses Topcoder JWT token to authenticate users and we need to use the data in smarty templates from session. Unfortunately, we have access to Vanilla User only, not Topcoder User in smart templates. We need to write some logic and commit several files in the forums repo(https://github.com/topcoder-platform/forums) to implement this requirements.
Issue 2
We need to update config files in the forums repo to support both envs (PROD/DEV) and make URLs to be configurable for the forum-theme.
In the submission section: 'You must submit a patch file against commit hash 2500e65 of the "dev" branch of the forums-theme Github repo'. What commit hash of the forums repo(https://github.com/topcoder-platform/forums) should be used?
Please let me know if there are no changes in the scope of the challenge.
The text was updated successfully, but these errors were encountered: