Skip to content

[$600] Performance issue #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Sep 2, 2021 · 8 comments
Closed

[$600] Performance issue #638

jmgasper opened this issue Sep 2, 2021 · 8 comments

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Sep 2, 2021

As discussed in Slack, investigate performance issue for user subhat

@jmgasper
Copy link
Collaborator Author

jmgasper commented Sep 2, 2021

Challenge https://www.topcoder.com/challenges/c171a064-5158-4e02-92c6-08b163c89df7 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

jmgasper commented Sep 2, 2021

Challenge https://www.topcoder.com/challenges/c171a064-5158-4e02-92c6-08b163c89df7 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

atelomycterus commented Sep 2, 2021

Added some details from Slack:
"i just clicked on “Challenge Forums” with the subhat user and it went immediately, because she’s tied to no challenges… but then i went back to Public Forums, it takes the 45sec"

Screen Shot 2021-09-02 at 11 28 41 AM
Screen Shot 2021-09-02 at 11 28 31 AM
:

@atelomycterus
Copy link
Collaborator

atelomycterus commented Sep 2, 2021

Perfomance issue: 'subhat' user viewed a home page:
Trace - https://app.tideways.io/o/Topcoder/Discussions/trace/gLhPqHsBcNBBDkEdLLDp/summary?m=60&s=web&env=production
image

image

The performance issue exists with any category page/discussion page for 'subhat' user:
image

@atelomycterus
Copy link
Collaborator

atelomycterus commented Sep 3, 2021

@jmgasper Please apply PR-topcoder-platform/forums-groups-plugin#93. Thanks!

Additional Changes

  • Added an event marker if there is no UserGroupCache
  • Added a custom variable (UserID). We can understand who this trace is associated with:
    image

The data is only displayed when the request trace is enabled in Tideways.

Local Testing

Before
image

After

image

Testing on DEV/PROD

Create a new user. Don't register for any challenges. Go to Vanilla and check response time.

@jmgasper
Copy link
Collaborator Author

jmgasper commented Sep 3, 2021

Thanks - tested with a couple users I had on dev that were new and it seems great.

@jmgasper jmgasper closed this as completed Sep 3, 2021
@jmgasper
Copy link
Collaborator Author

jmgasper commented Sep 3, 2021

Payment task has been updated: https://www.topcoder.com/challenges/c171a064-5158-4e02-92c6-08b163c89df7
Payments Complete
Winner: obog
Copilot: ghostar
Challenge c171a064-5158-4e02-92c6-08b163c89df7 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

jmgasper commented Sep 4, 2021

Deploying to production now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants