Skip to content

[$30] Formatting Issue in Forum Post editor window #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
m-yadav opened this issue Apr 13, 2021 · 10 comments
Closed

[$30] Formatting Issue in Forum Post editor window #568

m-yadav opened this issue Apr 13, 2021 · 10 comments

Comments

@m-yadav
Copy link

m-yadav commented Apr 13, 2021

In Vanilla forums , while posting a reply or initiating a thread , if we paste any string with the underscores, and then select the entire string and press on the italic button, the underscores vanish in the preview or the actual post.
Ideally the underscore should be preserved while clicking on the italic button.

Supporting Screenshots

Before :
image

image

After selecting the text and clicking on Italic Button

image
image

@jmgasper
Copy link
Collaborator

@m-yadav - Can you let me know exactly what browser and OS you are testing please?

@sdgun
Copy link
Collaborator

sdgun commented Apr 13, 2021

@jmgasper I checked this, it's not browser specific.

@sdgun sdgun added bug Something isn't working Dev env P3 labels Apr 13, 2021
@jmgasper jmgasper changed the title Formatting Issue in Forum Post editor window [$30] Formatting Issue in Forum Post editor window Apr 13, 2021
@jmgasper
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/4ca3ed16-a6bc-43c4-a234-d6732ab830c1 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/4ca3ed16-a6bc-43c4-a234-d6732ab830c1 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

@atelomycterus - This one can be lower priority, thanks.

@atelomycterus
Copy link
Collaborator

@jmgasper This formatting issue is due to using two special chars (* and _ ) for italic in EasyMDE . If the selection contains * or _ then they are removed, and the text is wrapped with *.

During debugging I found out the same formatting issue with bold. If we paste any string with the 2 underscores, and then select the entire string and press on the bold button, the underscores vanish in the editor. EasyMDE uses ** and __ for bold.

To keep the underscores in text we can use * for italic, ** for bold. Let me know if you are ok. I'll customize bold/italic actions.

Before formatting lines:
image

Select text and press on the Italic button. The special chars are removed from the selection and the text is wrapped with '*'.
image

Before formatting:
image

Select text and press on the Bold button.
image

@atelomycterus
Copy link
Collaborator

@jmgasper I've customized bold/italic actions (☝️ ). Use * for italic, ** for bold.
Please apply PR: topcoder-platform/forums-topcoder-editor-plugin#25. Thanks!

Testing

image

image

@jmgasper
Copy link
Collaborator

Payment task has been updated: https://www.topcoder.com/challenges/4ca3ed16-a6bc-43c4-a234-d6732ab830c1
Payments Complete
Winner: obog
Copilot: ghostar
Challenge 4ca3ed16-a6bc-43c4-a234-d6732ab830c1 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator

sdgun commented Apr 27, 2021

Verified in Dev.

image

@sdgun
Copy link
Collaborator

sdgun commented Apr 30, 2021

Verified in production.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants