[$150] Updated UI: Popups

[atelomycterus]

@jmgasper The popup window in MarvelApp:
Screen https://marvelapp.com/prototype/c06bg41/screen/77911788

The current design:

[jmgasper]

Challenge https://www.topcoder.com/challenges/06cb08ac-24da-4060-94cd-f3645850ec58 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

[jmgasper]

Challenge https://www.topcoder.com/challenges/06cb08ac-24da-4060-94cd-f3645850ec58 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

[atelomycterus]

@jmgasper At least 7 popups should be fixed. Each popup is a separate view with a different title and message.

1. Should I update only UI ?
2. Does this requirement include updating titles/messages? For example, the Delete Discussion title should be changed to Delete ( Add a new Category => Add, Invite User => Invite).
   For example, the Are you sure you want to delete this discussion? message should be changed to Are you sure you want to delete this item?

Discussion page

• Announce

• Move a discussion

• Delete a discussion
  

Group page

• Add New Category

• Delete a group

• Invite member
  

Profile page

[jmgasper]

@atelomycterus - I bumped the payment here. Yeah, let's try to get as close to the MarvelApp as possible, thanks!

[atelomycterus]

@jmgasper Please apply PRs:

• Issues-559: Fixed styles for a popup forums-theme#42
• Issues-559: fixed popups forums-groups-plugin#82
• Issues-559: Fixed popups #583
  Thanks!

Testing

Please clear browser cache before testing,
I've fixed all mentioned popups. Let me know if I missed any popups.
Delete popup looks the same for group / discussion/ token.

Other popups:

[sdgun]

@atelomycterus Even after clearing cache, I don't see any of these pop ups.

[jmgasper]

@sdgun - I can see them. Tested delete, move, announce

[jmgasper]

Payment task has been updated: https://www.topcoder.com/challenges/06cb08ac-24da-4060-94cd-f3645850ec58
Payments Complete
Winner: obog
Copilot: ghostar
Challenge 06cb08ac-24da-4060-94cd-f3645850ec58 has been paid and closed.

This is an automated message for ghostar via Topcoder X

[sdgun]

@atelomycterus Verified in Dev.

1. Delete comment pop up is not implemented as per the design, also after deleting a comment, the pop up is not getting closed and the screen shows a weird layout.

Screencast.2021-04-18.mp4

2. I don't see the Move option for copilot or admin anymore

Delete discussion is working as expected:

Announce is as expected:

Delete group:

Invite users:

Add category:

[jmgasper]

@sdgun - I see Move as an option for TonyJ:

[jmgasper]

I also can't reproduce the Delete issue - it's working fine for me.

[sdgun]

Created new issue for comment deleting related issues : #584

[sdgun]

Verified the below in production.

Deleting a comment
Move
Deleting a thread
Announcements

[atelomycterus]

@sdgun @jmgasper Please apply PR-#586. Thanks!

1. Delete comment pop up is not implemented as per the design, also after deleting a comment,

I missed it. The 'Deleting a comment' popup is generated with jquery.popup.js, other popups are implemented with php views.
Sorry about that. I've fixed:

2. I don't see the Move option for copilot or admin anymore

We've removed Edit permission (#490 (comment)). Moving a discussion requires:

• Discussion.Edit permission
• Discussion.Add permission on the target category.