Skip to content

[$200] Left nav for homepage #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Apr 7, 2021 · 6 comments
Closed

[$200] Left nav for homepage #548

jmgasper opened this issue Apr 7, 2021 · 6 comments

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Apr 7, 2021

As discussed in #487, we need to make sure the updated left nav is applied when the user drills down into public forums:

Screen_Shot_2021-04-08_at_8_28_35_am

@jmgasper
Copy link
Collaborator Author

jmgasper commented Apr 7, 2021

Challenge https://www.topcoder.com/challenges/291bd147-7eac-47e7-a996-16c56ee551d3 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

jmgasper commented Apr 7, 2021

Challenge https://www.topcoder.com/challenges/291bd147-7eac-47e7-a996-16c56ee551d3 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

@jmgasper Please apply PRs:
topcoder-platform/forums-theme#39
#576

Thanks!

Earlier we displayed a list of forums in the left nav on desktop and hid it on mobile. Now it works as before, i.e. it's hidden on mobile, no changes were made.

Testing

Please clear browser cache before testing.

The list of public forums topics is always hidden for guests:
image

The list of public forums topics is displayed for logged users:
image

The list of public forums topics is hidden:
image

image

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://www.topcoder.com/challenges/291bd147-7eac-47e7-a996-16c56ee551d3
Payments Complete
Winner: obog
Copilot: ghostar
Challenge 291bd147-7eac-47e7-a996-16c56ee551d3 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator

sdgun commented Apr 16, 2021

Verified in Dev. as expected left nav shows the public forum topics only when a logged in user is inside a public forum discussion.

@sdgun
Copy link
Collaborator

sdgun commented Apr 18, 2021

Verified in production.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants