Skip to content

[$40] "Viewing in Preview" text #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Apr 3, 2021 · 13 comments
Closed

[$40] "Viewing in Preview" text #530

jmgasper opened this issue Apr 3, 2021 · 13 comments

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Apr 3, 2021

Report by beta tester

When write text in the comment and click on Preview, the comment appears below LEAVE COMMENT but it doesn't have any heading. There is of course EDIT and POST COMMENT buttons, but still not very clear what you're submitting. See a screenshot below to see how it should look like according to my opinion:

109334053-80ead800-7860-11eb-9944-06e77b5227e6-2

Topcoder requirement

Please add a "Previewing" text when user is viewing a preview of their post

@jmgasper jmgasper changed the title [$40] " [$40] "Viewing in Preview" text Apr 3, 2021
@jmgasper
Copy link
Collaborator Author

jmgasper commented Apr 3, 2021

Challenge https://www.topcoder.com/challenges/456325ed-2c93-4275-8423-4a7ad41bade5 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

jmgasper commented Apr 3, 2021

Challenge https://www.topcoder.com/challenges/456325ed-2c93-4275-8423-4a7ad41bade5 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

atelomycterus commented Apr 14, 2021

@jmgasper We currently have no preview screens in MarvelApp. Maybe Topcoder/our designer missed it. Could you ask Topcoder /our designer how the comment/discussion preview screens should look? Thanks!

Discussion/Comment has slightly different preview screens.
Now Discussion preview looks like:
image

  • Should the input be hidden?
  • Should 'New Discussion' be replaced with a title , etc?

@jmgasper
Copy link
Collaborator Author

@atelomycterus - Asked, thanks!

@atelomycterus
Copy link
Collaborator

@jmgasper Is there any news on this task from Topcoder? Thanks!

@jmgasper
Copy link
Collaborator Author

@atelomycterus - Not yet. I've asked for an update from the Studio copilot.

@atelomycterus
Copy link
Collaborator

@jmgasper The Discussion preview screen has been added. https://marvelapp.com/prototype/c06bg41/screen/78581714.

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://www.topcoder.com/challenges/456325ed-2c93-4275-8423-4a7ad41bade5
Payments Complete
Winner: obog
Copilot: ghostar
Challenge 456325ed-2c93-4275-8423-4a7ad41bade5 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator

sdgun commented Apr 23, 2021

@atelomycterus @jmgasper Have we merged this change? I don't see the mentioned changes even after clearing browser cache.

@jmgasper jmgasper reopened this Apr 23, 2021
@jmgasper
Copy link
Collaborator Author

@sdgun - Sorry, my bad. Got mixed up with a different ticket.

@atelomycterus
Copy link
Collaborator

@jmgasper Please apply PRs:
topcoder-platform/forums-theme#48
#597

Thanks!

Testing

Notes: Button layout + editor size will be fixed in #595.

Previewing a comment:
image

Previewing a new discussion:
image

Previewing a discussion:
image

@sdgun
Copy link
Collaborator

sdgun commented Apr 24, 2021

Verified in Dev

image

image

image

@sdgun
Copy link
Collaborator

sdgun commented Apr 30, 2021

Verified in production.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment