Skip to content

[$75] Enable SORTING by: Most recent Highest views Highest responses #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Apr 3, 2021 · 9 comments
Closed

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Apr 3, 2021

Reported by testers:

In the new forum, I wasn't able to find an option sort by(Most Popular,Most recent,Date Posted) to see the questions posted in the forum.
Sorting will help the user to filter better

TC Requirement:

Enable SORTING by:

  • Most recent
  • Highest views
  • Highest responses
@jmgasper
Copy link
Collaborator Author

jmgasper commented Apr 3, 2021

Challenge https://www.topcoder.com/challenges/2fbcaf9b-953f-4dfa-8697-b652821a745c has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

jmgasper commented Apr 3, 2021

Challenge https://www.topcoder.com/challenges/2fbcaf9b-953f-4dfa-8697-b652821a745c has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

@jmgasper A few questions:

The category with discussions

  1. Most recent
    Now sort options are New and Old. 'New' will be renamed to 'Most Recent'. Should I remove 'Old'?
    image

  2. Highest views - sorting by Count of Views

  3. Highest responses - sorting by Count of Comments

The nested categories

We don't show sort options for nested categories. Let me know if it should be displayed:
image

@jmgasper
Copy link
Collaborator Author

jmgasper commented Apr 5, 2021

@atelomycterus - Not sure where my comment went, but I'll post it again. Sorry for the delay:

  1. Yes, we can remove Old and replace the options with the options in the requirements
  2. Correct
  3. Correct

@atelomycterus
Copy link
Collaborator

atelomycterus commented Apr 19, 2021

@jmgasper UPDATED: Sorting options have been added for discussions (Public Forums and Challenge Forums). At first I was confused by the updated Challenge Forums page screen.
A few questions. Please let me know if sorting options should be only changed for Public forums.

UPDATED (No changes, match MarvelApp): Sorting options for Challenges Forums page

Recently we've added sorting options (New/Old) for Challenges Forums page (#554). At least we should rename a sorting option for consistency (New to Most recent).
Should we remove Old options?

Challenges Forums page - https://marvelapp.com/prototype/c06bg41/screen/77911785.
image

If you want to add new sorting options for Challenge Forums:

  • Highest responses - sorting by Count of Comments - We can add this sorting option quickly for Challenge forums page because each category has a calculated DB field/ cached value of CountAllComments.

  • Highest views - sorting by Count of Views. This is more complicated for Challenge forums page, need to write a sql query to aggregate count of Discussion Views for each category and add/update this value in category cache and Category table. Otherwise it will work slowly if we recalculate everything at runtime. Public forums page works with a discussion table, this problem will not be here because the CountViews column is in the Discussion table . ~~

@atelomycterus
Copy link
Collaborator

@jmgasper Please apply PRs:

#588
topcoder-platform/forums-plugins#94

Thanks!

Public forums:
image

Challenge forums:
image

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://www.topcoder.com/challenges/2fbcaf9b-953f-4dfa-8697-b652821a745c
Payments Complete
Winner: obog
Copilot: ghostar
Challenge 2fbcaf9b-953f-4dfa-8697-b652821a745c has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator

sdgun commented Apr 22, 2021

Verified in Dev.

Challenge forums:
image

Public Forums:
image

@sdgun
Copy link
Collaborator

sdgun commented Apr 30, 2021

Verified in production.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants