Skip to content

[$40] The ellipsis with Edit option in it is shown for the normal user on their discussions #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdgun opened this issue Mar 27, 2021 · 6 comments

Comments

@sdgun
Copy link
Collaborator

sdgun commented Mar 27, 2021

Steps
Go to a discussion created by a normal user(log in as the same user)

The ellipsis is shown for the normal user on their discussions

Ticket #490 says 'The goal is that there will be no 3 dot menu for normal users. They will see Edit, Quote, and Reply as appropriate.'

image

@sdgun sdgun added bug Something isn't working Dev env P2 labels Mar 27, 2021
@jmgasper jmgasper changed the title The ellipsis with Edit option in it is shown for the normal user on their discussions [$40] The ellipsis with Edit option in it is shown for the normal user on their discussions Mar 28, 2021
@jmgasper
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/d2735e7a-bff3-47c8-9d0b-ef19a1cfdfb9 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/d2735e7a-bff3-47c8-9d0b-ef19a1cfdfb9 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

atelomycterus commented Apr 27, 2021

@jmgasper Please apply PRs
#608
topcoder-platform/forums-theme#53 - Fixed minor css style issues with Reply button.
topcoder-platform/forums-groups-plugin#89 - Fixed missing dropdown options for admin/copilots, etc in Group Page. The group page has matched MarvelApp but the dropdown options wasn't added.
Thanks!

Testing

No 3 dot menu for normal users on Discussion page:
image

The dropdown is displayed in Category pages (Public Forums):
image

Normal users: The dropdown is displayed in Group Page (Challenge Forums):
image

Other users: The dropdown options are displayed in Group page (Challenge Forums):
image

@jmgasper
Copy link
Collaborator

Payment task has been updated: https://www.topcoder.com/challenges/d2735e7a-bff3-47c8-9d0b-ef19a1cfdfb9
Payments Complete
Winner: obog
Copilot: ghostar
Challenge d2735e7a-bff3-47c8-9d0b-ef19a1cfdfb9 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator Author

sdgun commented Apr 28, 2021

Verified in Dev with all users.

@sdgun
Copy link
Collaborator Author

sdgun commented Apr 30, 2021

Verified in production

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants