Skip to content

[$250] Fix 'Quote' functionality #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Mar 23, 2021 · 8 comments
Closed

[$250] Fix 'Quote' functionality #491

jmgasper opened this issue Mar 23, 2021 · 8 comments

Comments

@jmgasper
Copy link
Collaborator

The Quote button currently goes to a new page, instead of staying on the existing page. This ticket will track:

  1. Moving the Quote button to the new location:

Screen_Shot_2021-03-24_at_8_28_21_am

2. Changing the functionality so that it works as it does now (adding in the quoted text to the comment), *but* staying on the current page, instead of leaving it. We'll just add the quoted text to the beginning of the comment, so if the user has already typed something in the comment, the quoted text will just be prepended to it.
@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/0c49f215-f868-449a-bd8f-7046094b27f8 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/0c49f215-f868-449a-bd8f-7046094b27f8 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

@jmgasper Quote functionality is part of the Quote plugin.
image

I've looked at Quotes plugin. The current page contains html not markdown. So need to fix the plugin's handlers to meet the second requirement.

Keep you updated.

@jmgasper jmgasper changed the title [$75] Fix 'Quote' functionality [$250] Fix 'Quote' functionality Mar 28, 2021
@atelomycterus
Copy link
Collaborator

atelomycterus commented Mar 28, 2021

@jmgasper Please apply PRs:
topcoder-platform/forums-topcoder-editor-plugin#16
topcoder-platform/forums-plugins#76 - set the scroll animations settings as in quotes plugin
#504

Testing

Please clear browser cache before testing.

Quotes are added to the beginning of the comment:
image

Using quotes with replies:
image

@jmgasper
Copy link
Collaborator Author

Looks great!

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://www.topcoder.com/challenges/0c49f215-f868-449a-bd8f-7046094b27f8
Payments Complete
Winner: obog
Copilot: ghostar
Challenge 0c49f215-f868-449a-bd8f-7046094b27f8 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator

sdgun commented Mar 29, 2021

Verified in Dev.

@sdgun sdgun added this to the 1.x milestone Mar 29, 2021
@sdgun
Copy link
Collaborator

sdgun commented Apr 1, 2021

Verified in production.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants