Skip to content

[$400] Reply / threaded view options #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Mar 23, 2021 · 9 comments
Closed

[$400] Reply / threaded view options #488

jmgasper opened this issue Mar 23, 2021 · 9 comments

Comments

@jmgasper
Copy link
Collaborator

This ticket will cover changing the Reply functionality.

Reply

If a user "replies" to a comment, it should be displayed in the threaded view as indented underneath that comment, down to some maximum depth (whatever makes sense)

Screen Shot 2021-03-23 at 6 58 55 pm

When the user clicks the new Reply button, we'll change the LEAVE A COMMENT text to say REPLYING TO <handle of original poster>

MarvelApp

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/91b0d3b3-8c03-4a88-9010-dd7ac7c6625a has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/91b0d3b3-8c03-4a88-9010-dd7ac7c6625a has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

@jmgasper Here are the slight differences between your screen and the current Marvelapp. For example, Re: <discussion title> (response to post by <handle> is displayed in Flat mode only.

Post links

In Flat mode Re:<discussion title> (response to <post link> by processor) is rendered.
Post link is going to

  • a discussion if user clicked on Reply in discussion block or user just left a comment (no reply)
  • a comment if user clicked on Reply in comment block

Threaded mode

https://marvelapp.com/prototype/c06bg41/screen/77911793
image

Flat mode

https://marvelapp.com/prototype/c06bg41/screen/77911792.
image

Reply to

Reply to Discussion

Clicking on 'Reply' from discussion block -> Author is used
image

image

Reply to Comment

Clicking on 'Reply' from comment block -> Author is used
image

@jmgasper
Copy link
Collaborator Author

Looks great, thanks!

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://www.topcoder.com/challenges/91b0d3b3-8c03-4a88-9010-dd7ac7c6625a
Payments Complete
Winner: obog
Copilot: ghostar
Challenge 91b0d3b3-8c03-4a88-9010-dd7ac7c6625a has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator

sdgun commented Mar 28, 2021

Verified in public forums/challenge forums comments/discussions and flat/threaded views in Dev.

@atelomycterus While testing the number of replies, I noticed, it's only possible to reply maximum 9 times. After that even a reply is shown as a comment in the threaded view

Screencast.2021-03-28.mp4

@atelomycterus
Copy link
Collaborator

@sdgun Thanks for testing!

@atelomycterus While testing the number of replies, I noticed, it's only possible to reply maximum 9 times. After that even a reply is shown as a comment in the threaded view

There is no limit to the number of replies. This is only about formatting nested comments. I've improved the formatting a bit
because after depth> 9 were displayed incorrectly.

Indent comments according to their depth, reduce the indenting after 5 levels and stop indenting any further after 15 levels. Stop indenting after 15 levels because there is little space to display a comment. The same rules are applied for mobile version.

Desktop:
https://user-images.githubusercontent.com/10196632/112754065-18b81f00-8fe3-11eb-9fa3-1ff22e26a494.mp4

Mobile:
https://user-images.githubusercontent.com/10196632/112754086-338a9380-8fe3-11eb-9a71-866db2a3d439.mp4

@jmgasper
Please apply PRs:
#504
topcoder-platform/forums-plugins#76

Thanks!

@sdgun
Copy link
Collaborator

sdgun commented Mar 29, 2021

Fixed. Verified in Dev. Indentation is reduced after 5th reply and after 15th reply not indenting.

https://vanilla.topcoder-dev.com/discussion/4089/new-discussion-1

@sdgun sdgun added this to the 1.x milestone Mar 29, 2021
@sdgun
Copy link
Collaborator

sdgun commented Apr 1, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants