-
Notifications
You must be signed in to change notification settings - Fork 0
[$400] Reply / threaded view options #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Challenge https://www.topcoder.com/challenges/91b0d3b3-8c03-4a88-9010-dd7ac7c6625a has been created for this ticket. |
Challenge https://www.topcoder.com/challenges/91b0d3b3-8c03-4a88-9010-dd7ac7c6625a has been assigned to obog. |
@jmgasper Here are the slight differences between your screen and the current Marvelapp. For example, Post linksIn Flat mode
Threaded modehttps://marvelapp.com/prototype/c06bg41/screen/77911793 Flat modehttps://marvelapp.com/prototype/c06bg41/screen/77911792. Reply toReply to DiscussionClicking on 'Reply' from discussion block -> Author is used Reply to Comment |
Looks great, thanks! |
Payment task has been updated: https://www.topcoder.com/challenges/91b0d3b3-8c03-4a88-9010-dd7ac7c6625a |
Verified in public forums/challenge forums comments/discussions and flat/threaded views in Dev. @atelomycterus While testing the number of replies, I noticed, it's only possible to reply maximum 9 times. After that even a reply is shown as a comment in the threaded view Screencast.2021-03-28.mp4 |
@sdgun Thanks for testing!
There is no limit to the number of replies. This is only about formatting nested comments. I've improved the formatting a bit Indent comments according to their depth, reduce the indenting after 5 levels and stop indenting any further after 15 levels. Stop indenting after 15 levels because there is little space to display a comment. The same rules are applied for mobile version. @jmgasper Thanks! |
Fixed. Verified in Dev. Indentation is reduced after 5th reply and after 15th reply not indenting. https://vanilla.topcoder-dev.com/discussion/4089/new-discussion-1 |
Verified in production. https://discussions.topcoder.com/discussion/4482/503-error-test?view=threaded |
This ticket will cover changing the
Reply
functionality.Reply
If a user "replies" to a comment, it should be displayed in the threaded view as indented underneath that comment, down to some maximum depth (whatever makes sense)
When the user clicks the new
Reply
button, we'll change theLEAVE A COMMENT
text to sayREPLYING TO <handle of original poster>
MarvelApp
The text was updated successfully, but these errors were encountered: