[$50] Empty message change

[jmgasper]

Current

Current behavior: when a member tries to post something without any content, they receive a “Body is required” message. Doesn’t make much sense to the members.

Expected

UPDATE error message to Cannot post an empty message and update the look and feel as follows:

MarvelApp: https://marvelapp.com/prototype/c06bg41/screen/77868363

[jmgasper]

Challenge https://www.topcoder.com/challenges/f9aa7ade-18fb-404a-b62e-a43faf1042dc has been created for this ticket.

This is an automated message for ghostar via Topcoder X

[jmgasper]

Challenge https://www.topcoder.com/challenges/f9aa7ade-18fb-404a-b62e-a43faf1042dc has been assigned to obog.

This is an automated message for ghostar via Topcoder X

[atelomycterus]

@jmgasper Vanilla generates a message from DB schema if some fields must be not null.
I've implemented the main requirements and added validation on client side. The error message is displayed and the buttons are disabled if body is empty.

• The Vanilla.Comment.MaxLength parameter is used:
  

• If body comment length > max comment length:
  

There are few questions related to this issue.

• Vanilla trims spaces from a comment before saving it in DB. User types several spaces, auto-save is running in several seconds and the error message is displayed. It is confusing.
  

So I've implemented the same on the client. Trying to post a comment with spaces:

• What message should be displayed if comment length > max comment length? Vanilla displays the message:
  

• Do you want to disable the submit button if comment length > max comment length?

[jmgasper]

@atelomycterus - For now, let's just focus on the minimum comment limit. I think the space handling you document is fine.

I'll log something for the max character limit as well, thanks.

[atelomycterus]

@jmgasper Please apply PRs:
#536
topcoder-platform/forums-topcoder-editor-plugin#18
topcoder-platform/forums-theme#35

Thanks!

Testing

Please clear browser cache before testing.

Adding a new comment:

Editing a comment:

[jmgasper]

Payment task has been updated: https://www.topcoder.com/challenges/f9aa7ade-18fb-404a-b62e-a43faf1042dc
Payments Complete
Winner: obog
Copilot: ghostar
Challenge f9aa7ade-18fb-404a-b62e-a43faf1042dc has been paid and closed.

This is an automated message for ghostar via Topcoder X

[sdgun]

@jmgasper This same issue is there with discussions too, are we only fixing this in comments?

[jmgasper]

@sdgun - Thanks for catching that - I'll log a separate issue.

[sdgun]

Verified in Dev with comments(empty/spaces/auto saving) the expected error message is displayed with the red outline. When logged in from a user with upload access, the upload icon disappears when this error is displayed, but it reappears when user enters some text.

Screencast.2021-04-06.mp4

[atelomycterus]

@sdgun @jmgasper

When logged in from a user with upload access, the upload icon disappears when this error is displayed, but it reappears when user enters some text.

The default message is hidden in the status bar when the error is displayed. Please let me know if it's confusing. I'll fix it.

[sdgun]

Verified in production.