Skip to content

[$50] Priority - not all admins showing orange handles #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Mar 2, 2021 · 10 comments
Closed

[$50] Priority - not all admins showing orange handles #451

jmgasper opened this issue Mar 2, 2021 · 10 comments

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Mar 2, 2021

@atelomycterus - This ones a priority, since we want to get it fixed, at least in dev, before the billing account closes tomorrow.

A couple handles for admins aren't showing as orange in prod. I don't see anything obviously wrong in the code, but it looks like we may be relying on cached data for some of this.

Screen Shot 2021-03-01 at 3 52 33 PM

Screen Shot 2021-03-01 at 3 51 48 PM

@jmgasper
Copy link
Collaborator Author

jmgasper commented Mar 2, 2021

Challenge https://www.topcoder.com/challenges/f234f616-30de-4003-bcff-05094b88bdb1 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

jmgasper commented Mar 2, 2021

Challenge https://www.topcoder.com/challenges/f234f616-30de-4003-bcff-05094b88bdb1 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

atelomycterus commented Mar 2, 2021

@jmgasper orange handle is shown if user has Admin,admin,administrator or Administrator role (#24)
In DEV both users have 'copilot' role, not admin.
In PROD need to check https://api.topcoder.com/v3/roles?filter=subjectID%3D<topcoderID> . I get 403 with my personal token.

DEV

jmpld40 (14999860) - https://api.topcoder-dev.com/v3/roles?filter=subjectID%3D14999860
nick.castillo (23194912) - https://api.topcoder-dev.com/v3/roles?filter=subjectID%3D23194912

image

In DEV both users with role 'copilot' :
image

image

@jmgasper
Copy link
Collaborator Author

jmgasper commented Mar 2, 2021

@atelomycterus - Interesting. I checked nick.castillo and jmpld40 in prod. Neither are listed as admins, but they are listed as Connect Manager. Can we add Connect Manager to the check for the time being please?

@jmgasper
Copy link
Collaborator Author

jmgasper commented Mar 2, 2021

@rootelement ☝️ Any concerns?

@atelomycterus
Copy link
Collaborator

@jmgasper Sure. Please apply PR-topcoder-platform/forums-plugins#64, Thanks!

Testing

image

@jmgasper
Copy link
Collaborator Author

jmgasper commented Mar 2, 2021

Payment task has been updated: https://www.topcoder.com/challenges/f234f616-30de-4003-bcff-05094b88bdb1
Payments Complete
Winner: obog
Copilot: ghostar
Challenge f234f616-30de-4003-bcff-05094b88bdb1 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator

sdgun commented Mar 3, 2021

Verified in Dev.

@sdgun
Copy link
Collaborator

sdgun commented Mar 16, 2021

The issue is still there with those admin users in production.

@atelomycterus
Copy link
Collaborator

@sdgun Yes, the issue exists. I've fixed it in #466. We've tested topcoder handles in mentions but topcoder admins are shown in black if he/she creates discussion/comment.
For example in DEV:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants