-
Notifications
You must be signed in to change notification settings - Fork 0
[$300] Formalise deployment #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Challenge https://www.topcoder.com/challenges/491b41b2-c32c-4bf7-b578-cb5bf232b007 has been created for this ticket. |
Challenge https://www.topcoder.com/challenges/491b41b2-c32c-4bf7-b578-cb5bf232b007 has been assigned to obog. |
@jmgasper Do you have permissions to rename a branch? One repo is named 'main' , all others are named 'master'. Renaming branch - https://github.com/github/renaming/ |
@atelomycterus - Renaming done. |
@jmgasper Could you create 'develop' branches for plugins and set them as 'default'? Thanks! The list of plugins: |
@jmgasper I've created develop branches. Please set 'develop' branch as default. I don't have permissions. DebugBar plugin will be not deployed to PROD anymore because if someone with admin roles turns it on, then any authorized user can see sensitive information (like server env params, API Keys and so on). If know how to configure permissions, then for unauthorized ones. Please apply PR-#446. Set 'develop 'as a default branch for the repos: Thanks! |
@atelomycterus - Thanks. Default branches are set, and PR is merged and deploying to dev. |
Payment task has been updated: https://www.topcoder.com/challenges/491b41b2-c32c-4bf7-b578-cb5bf232b007 |
Found an issue with the deploy keys. Fixing that now. |
@jmgasper Sorry about that. The issue with a branch name, I used '$CIRCLE_BRANCH' env param which set in 'Preparing environment variables' step. This could detect the branch automatically but it didn't work. Fixed. #447. Thanks!
|
@jmgasper Verified it:
|
@atelomycterus - Currently our deployment just uses the
master
branch of things like the plugins and other dependency repos. I'd like to get this formalised so that we usedevelop
for all dependencies in dev andmaster
for all dependencies in prod. This will allow us to more easily roll back changes if we run into deployment issues.The text was updated successfully, but these errors were encountered: