Skip to content

[$300] Formalise deployment #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Feb 25, 2021 · 11 comments
Closed

[$300] Formalise deployment #440

jmgasper opened this issue Feb 25, 2021 · 11 comments

Comments

@jmgasper
Copy link
Collaborator

@atelomycterus - Currently our deployment just uses the master branch of things like the plugins and other dependency repos. I'd like to get this formalised so that we use develop for all dependencies in dev and master for all dependencies in prod. This will allow us to more easily roll back changes if we run into deployment issues.

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/491b41b2-c32c-4bf7-b578-cb5bf232b007 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/491b41b2-c32c-4bf7-b578-cb5bf232b007 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

atelomycterus commented Feb 25, 2021

@jmgasper Do you have permissions to rename a branch? One repo is named 'main' , all others are named 'master'.
It would be better if all repositories have the same name. Otherwise, we will have to write if /else condition in the bash script (dockerfile).

Renaming branch - https://github.com/github/renaming/

image

@jmgasper
Copy link
Collaborator Author

@atelomycterus - Renaming done.

@atelomycterus
Copy link
Collaborator

@jmgasper I've created develop branches. Please set 'develop' branch as default. I don't have permissions.

DebugBar plugin will be not deployed to PROD anymore because if someone with admin roles turns it on, then any authorized user can see sensitive information (like server env params, API Keys and so on). If know how to configure permissions, then for unauthorized ones.

Please apply PR-#446.

Set 'develop 'as a default branch for the repos:
https://github.com/topcoder-platform/forums-plugins
https://github.com/topcoder-platform/forums-filestack-plugin
https://github.com/topcoder-platform/forums-groups-plugin
https://github.com/topcoder-platform/forums-sumologic-plugin
https://github.com/topcoder-platform/forums-topcoder-editor-plugin
https://github.com/topcoder-platform/forums-theme

Thanks!

@jmgasper
Copy link
Collaborator Author

@atelomycterus - Thanks. Default branches are set, and PR is merged and deploying to dev.

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://www.topcoder.com/challenges/491b41b2-c32c-4bf7-b578-cb5bf232b007
Payments Complete
Winner: obog
Copilot: ghostar
Challenge 491b41b2-c32c-4bf7-b578-cb5bf232b007 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Found an issue with the deploy keys. Fixing that now.

@atelomycterus
Copy link
Collaborator

@jmgasper Sorry about that. The issue with a branch name, I used '$CIRCLE_BRANCH' env param which set in 'Preparing environment variables' step. This could detect the branch automatically but it didn't work. Fixed. #447. Thanks!

'Preparing environment variables' 
Using build environment variables:
  BASH_ENV=/tmp/.bash_env-603997f5d0e4ac13848086c6-0-build
  CI=true
  CIRCLECI=true
  CIRCLE_BRANCH=develop
  CIRCLE_BUILD_NUM=256
  CIRCLE_BUILD_URL=https://circleci.com/gh/topcoder-platform/forums/256
  CIRCLE_COMPARE_URL=
  CIRCLE_JOB=build-dev

@atelomycterus
Copy link
Collaborator

@jmgasper Verified it:

 ---> Running in 3a0a1fcc032d
'develop' branch will be used for dependency repos ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants