Skip to content

[$200] Navigation Bar Should Match Current #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hokienick opened this issue Feb 19, 2021 · 13 comments
Closed

[$200] Navigation Bar Should Match Current #419

hokienick opened this issue Feb 19, 2021 · 13 comments

Comments

@hokienick
Copy link

The Navigation Bar should be the same as what is currently used on the Community Site. This is an issue we had before where if we made any change to the navigation on the Community site, we would have to make the same updates in Jive. I hope that will not be the case again.

Here is how it shows in dev currently:
Screen Shot 2021-02-19 at 1 42 36 PM

This is how it should operate:
Screen Shot 2021-02-19 at 1 42 22 PM

@jmgasper jmgasper changed the title Navigation Bar Should Match Current [$100] Navigation Bar Should Match Current Feb 20, 2021
@jmgasper
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/3e9e44c2-739d-47ce-a5fa-9df3dbd051e6 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/3e9e44c2-739d-47ce-a5fa-9df3dbd051e6 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

@jmgasper a few questions about navigation. All links now navigate to pages in Vanilla. Should these links navigate to Topcoder pages or not?

  1. Topcoder profile - https://www.topcoder-dev.com/members/TonyJ
    Vanilla profile - https://vanilla.topcoder-dev.com/profile/discussions/TonyJ

  2. Topcoder settings https://www.topcoder-dev.com/settings/profile
    Vanilla settings https://vanilla.topcoder-dev.com/profile/preferences

image

@jmgasper
Copy link
Collaborator

  1. Let's put the profile to Topcoder
  2. Settings should be Vanilla

@jmgasper
Copy link
Collaborator

Eventually, we're going to move the settings to Topcoder and have Topcoder make API calls back to Vanilla, but that's not on the current roadmap.

@jmgasper jmgasper changed the title [$100] Navigation Bar Should Match Current [$200] Navigation Bar Should Match Current Feb 25, 2021
@atelomycterus
Copy link
Collaborator

@jmgasper What about nav bar on mobile? Is in the scope of the task?

Topcoder sites: The menu opens in full screen,
Vanilla: the second nav bar appears. If click on username then the menu popup is displayed

image

image

@jmgasper
Copy link
Collaborator

@atelomycterus - We can leave that for a future task for now

@atelomycterus
Copy link
Collaborator

@jmgasper Keep you updated:

Desktop: Implemented, Clean code and push it tomorrow.
image

@jmgasper
Copy link
Collaborator

Great, thanks!

@atelomycterus
Copy link
Collaborator

atelomycterus commented Feb 28, 2021

@jmgasper Please apply PRs
#448
topcoder-platform/forums-plugins#63
topcoder-platform/forums-theme#26

Thanks!

Testing

Please clear browser cache before testing:
image

If count of New Notifications > 0 then a dot should be displayed:
image

@jmgasper
Copy link
Collaborator

Payment task has been updated: https://www.topcoder.com/challenges/3e9e44c2-739d-47ce-a5fa-9df3dbd051e6
Payments Complete
Winner: obog
Copilot: ghostar
Challenge 3e9e44c2-739d-47ce-a5fa-9df3dbd051e6 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun sdgun added the P2 label Mar 1, 2021
@sdgun
Copy link
Collaborator

sdgun commented Mar 1, 2021

Verified in Dev.

image

@sdgun
Copy link
Collaborator

sdgun commented Mar 16, 2021

Verified in production.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants