Skip to content

[$50] Re-enable "Move" #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Feb 10, 2021 · 5 comments
Closed

[$50] Re-enable "Move" #384

jmgasper opened this issue Feb 10, 2021 · 5 comments

Comments

@jmgasper
Copy link
Collaborator

@atelomycterus - I ran into a situation where we may need to move some discussion around. We had originally just disabled it here: #117

Can we re-enable and just fix up that popup so it looks a little better please? My bad for not thinking further ahead, thanks.

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/1643d90a-ef6c-4d98-9aeb-6adee4194049 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/1643d90a-ef6c-4d98-9aeb-6adee4194049 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

atelomycterus commented Feb 10, 2021

@jmgasper Wrote notes about Moving Discussions and re-enabled 'Move'. Please apply PRs:

UI

Added 'Cancel' button for consistency with other popups (Add Category/Invite user and so on)
image

Permissions in Vanilla

'Garden.Moderation.Manage' is a global Vanilla permission. Use it for moderator/admin roles.
'Groups.Moderation.Manage' is a custom permission added by Groups plugin. Use it for copilot roles. User is allowed to move a group discussion only.

if User has 'Garden.Moderation.Manage'/'Groups.Moderation.Manage' and can edit a discussion then
'Move' should be displayed in the dropdown:
image

Moving Discussions

The next permissions will be checked after moving confirmation:

  • Discussion.Edit permission
  • Discussion.Add permission on the target category
    If User isn't allowed to add a discussion to the category then the category is disabled in the category dropdown.
    image

'Leave a redirect link'

if 'Leave a redirect link' is checked then a discussion record (type= redirect) is added in Discussion table. It may be required for tracking some discussions. I moved the discussion (id=164) + checked 'redirect link':
image

Email for a discussion (type=redirect):
image

Moving content from a category

If you want move content and delete a category:
image

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://www.topcoder.com/challenges/1643d90a-ef6c-4d98-9aeb-6adee4194049
Payments Complete
Winner: obog
Copilot: ghostar
Challenge 1643d90a-ef6c-4d98-9aeb-6adee4194049 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@jmgasper jmgasper added this to the V1.2 Roundtables milestone Feb 22, 2021
@sdgun
Copy link
Collaborator

sdgun commented Feb 22, 2021

Verified in Dev unable to verify in prod since only admin users can perform this action.

@sdgun sdgun added the QA Pass label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants