Skip to content

[$80] Remove Follow functionality #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Feb 4, 2021 · 12 comments
Closed

[$80] Remove Follow functionality #372

jmgasper opened this issue Feb 4, 2021 · 12 comments

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Feb 4, 2021

@atelomycterus - We're going to remove Follow, sticking only with the Watch functionality where users are notified by email. There's been confusion on the differences between the two, and we're going to be updating the nav to remove My Discussions from the left anyways.

Please let me know if you have concerns - we can just hide both the Follow button and My Discussions for now.

@jmgasper
Copy link
Collaborator Author

jmgasper commented Feb 4, 2021

Challenge https://www.topcoder.com/challenges/e43be9b8-cb71-4b58-a9ba-598e3c6e2697 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

jmgasper commented Feb 4, 2021

Challenge https://www.topcoder.com/challenges/e43be9b8-cb71-4b58-a9ba-598e3c6e2697 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator

sdgun commented Feb 5, 2021

@jmgasper Recent discussions, All categories and roundtables have the View option which will not make sense once follow option is removed

image

image

image

@jmgasper
Copy link
Collaborator Author

jmgasper commented Feb 5, 2021

@sdgun - Good point, thanks. @atelomycterus - We can remove that View dropdown as well.

@jmgasper jmgasper changed the title [$60] Remove Follow functionality [$80] Remove Follow functionality Feb 5, 2021
@atelomycterus
Copy link
Collaborator

@jmgasper What about REST API? Should I remove it from REST API?
'/groups/{id}/member/{userid}' - Get a member details (watch status/follow status)
'/groups/{id}/member/{userid} - Update watch status and/or follow status for a member.'

@atelomycterus
Copy link
Collaborator

atelomycterus commented Feb 5, 2021

@jmgasper

Changes

Please apply PRs:
#374,
topcoder-platform/forums-groups-plugin#52.
Thanks!

  1. Status: Fixed. Show/Hide 'My Discussions' in the left nav in config.php:
$Configuration['Vanilla']['Discussions']['ShowMineTab'] = false;
  1. Status: Fixed. I've fixed Vanilla controllers. Now we can enable/disable this feature using Vanilla EnableCategoryFollowing key.
$Configuration['Vanilla']['EnableCategoryFollowing'] = false;
  1. Status: Fixed. EnableCategoryFollowing is supported in Groups Plugin. If EnableCategoryFollowing= false:
  • don't insert/update rows in Gdn_UserCategory table.
  • don't clear/update FollowCategory cache
  • hide Follow/unfollow categories in a group page:
    image

Questions

Let me know about REST API. Should we support 'EnableCategoryFollowing' in REST API or remove 'follow' status from REST API?
if 'EnableCategoryFollowing' = false:

  • don't return follow status for '/groups/{id}/member/{userid}' - Get a member details (watch status/follow status)
  • don't use/ignore 'follow' for '/groups/{id}/member/{userid} - Update watch status and/or follow status for a member.'

@jmgasper
Copy link
Collaborator Author

jmgasper commented Feb 7, 2021

@atelomycterus - We can remove this from the REST API as well, but that's lower priority.

@atelomycterus
Copy link
Collaborator

@jmgasper Please apply PRs:

We can remove this from the REST API as well, but that's lower priority.

Fixed. Challenge forum processor was updated.

@jmgasper
Copy link
Collaborator Author

jmgasper commented Feb 8, 2021

Payment task has been updated: https://www.topcoder.com/challenges/e43be9b8-cb71-4b58-a9ba-598e3c6e2697
Payments Complete
Winner: obog
Copilot: ghostar
Challenge e43be9b8-cb71-4b58-a9ba-598e3c6e2697 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator

sdgun commented Feb 8, 2021

Verified in roundtables and challenge forums, the follow option and the view drop down are not available.

@sdgun sdgun added QA Pass and removed Ready for QA labels Feb 8, 2021
@atelomycterus
Copy link
Collaborator

@jmgasper One PR has not been applied. Please apply PR - topcoder-platform/challenge-forum-processor#50. Thanks!

@jmgasper jmgasper added this to the V1.2 Roundtables milestone Feb 22, 2021
@sdgun
Copy link
Collaborator

sdgun commented Feb 22, 2021

Verified in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants