Skip to content

[$100] Check group role / rights #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Jan 27, 2021 · 12 comments
Closed

[$100] Check group role / rights #363

jmgasper opened this issue Jan 27, 2021 · 12 comments

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Jan 27, 2021

@atelomycterus - We're getting reports of folks who are not registered for a challenge able to access the challenge forum.

Can you investigate ASAP please?

Sample:

Login:

CustomerUser/appirio123

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/bfd2e64b-f65c-4a51-8ab9-d8b74ccd3d8e has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/bfd2e64b-f65c-4a51-8ab9-d8b74ccd3d8e has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

atelomycterus commented Jan 27, 2021

@jmgasper CustomerUser is a member of the group. The user joined TEST CHALLENGE FORUM RELEASE 1/22/2021 at 2021-01-22 06:45:23.

Go to 'All members' of the TEST CHALLENGE FORUM RELEASE 1/22/2021:
image

I would check some more users 'who are not registered for a challenge able to access the challenge forum'.
If they have joined groups but not registered by themselves for challenges then
have a look at challenge forum processor logs. What events have been received and so on.
Let me know if I can help with it.

@jmgasper
Copy link
Collaborator Author

@sdgun ☝️ Can you validate please?

@sdgun
Copy link
Collaborator

sdgun commented Jan 27, 2021

@atelomycterus This user unregisters from the challenges, but it doesn't remove him from the groups.

image

@atelomycterus
Copy link
Collaborator

atelomycterus commented Jan 27, 2021

@jmgasper I registered for a challenge (https://www.topcoder.com/challenges/c8395d32-970e-4c77-8c63-4969a29a031f) using my account and unregistered from it but I wasn't removed from a Vanilla group.

I see that challenge-forum-processor (master) doesn't include several commits after 21 Dec:
image

The user is not removed from a group due to a missing commit ( 780ca615008b76802bca2d5aab16c0cafaa9f347 commit from 25 December):
image

Several new methods were added in GroupAPI. I remember I changed a path due to PHP Runtime error in Vanilla. Need to follow Vanilla Controller API naming conventions. Sorry about that.

Let me know when the challenge forum processor is re-deployed. I'll validate it.

@jmgasper
Copy link
Collaborator Author

@atelomycterus - Ah, good catch, thanks. Fixing / redeploying now.

@sdgun
Copy link
Collaborator

sdgun commented Jan 28, 2021

Verified, unregistering removed the user from the group. Also verified email notifications after unregistering and user is not getting any notification after that. This issue can be closed @jmgasper

@atelomycterus
Copy link
Collaborator

@jmgasper It works as expected. I've tested with my account. After unregistering from a challenge, Permission Problem page is displayed.
@sdgun Please validate it. Let me know if you find something wrong.

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/153518f7-acf8-4df3-a000-86771046d807 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/153518f7-acf8-4df3-a000-86771046d807 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://www.topcoder.com/challenges/153518f7-acf8-4df3-a000-86771046d807
Payments Complete
Winner: obog
Copilot: ghostar
Challenge 153518f7-acf8-4df3-a000-86771046d807 has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun sdgun added this to the V1.2 Roundtables milestone Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants