Skip to content

[$150] Performance: Group Page , Discussion Page #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
atelomycterus opened this issue Jan 8, 2021 · 7 comments
Closed

[$150] Performance: Group Page , Discussion Page #350

atelomycterus opened this issue Jan 8, 2021 · 7 comments

Comments

@atelomycterus
Copy link
Collaborator

Execution time is worse for pages that have a challenge group because member roles are displayed for a challenge.
image

Group page

Group page takes about 2,5- 4,5 seconds.

image

For a challenge group page:
65% of execution time:

  • get M2M token
  • get Role Resources
  • get Challenge Resources for a challenge

image

Discussion page

Discussion page takes about 2,5-5,3 secs.
image

42% of execution time takes to get response from Topcoder API.
image

TODO

Need to cache data:

  • Role Resources
  • Challenge Resources
@atelomycterus atelomycterus self-assigned this Jan 8, 2021
@atelomycterus
Copy link
Collaborator Author

@jmgasper Please apply PR-topcoder-platform/forums-plugins#57. Thanks!

I see the list of errors in DEV. As a result, member roles are not displayed at group pages/ discussion pages.
image

I have compared all M2M parameters. In my environment, I have only one parameter different ('AUTH0_AUDIENCE').
Please check it 'AUTH0_AUDIENCE' before deploying. It should be https://m2m.topcoder-dev.com/, not https://api.topcoder.com/ for DEV. This issue from November - #109 (comment).

Testing

Group page:
image

Group page:
image

Discussion page with 33 comments:

image

CacheKeys

topcoder.roleresources
image

topcoder.challenge.<ChallengeID>.resources
image

@jmgasper jmgasper changed the title Performance: Group Page , Discussion Page [$150] Performance: Group Page , Discussion Page Jan 9, 2021
@jmgasper
Copy link
Collaborator

jmgasper commented Jan 9, 2021

Contest https://www.topcoder.com/challenges/30161722 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

jmgasper commented Jan 9, 2021

Contest https://www.topcoder.com/challenges/30161722 has been updated - it has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

Seems much betters thanks.

@jmgasper
Copy link
Collaborator

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30161722

This is an automated message for ghostar via Topcoder X

@jmgasper jmgasper added this to the January 2021 Release milestone Jan 11, 2021
@sdgun
Copy link
Collaborator

sdgun commented Jan 12, 2021

Verified in Groups page, Discussion page, and with 3 pages of comments. All calls completed below 1 second

image

image

@sdgun
Copy link
Collaborator

sdgun commented Jan 22, 2021

Verified in production

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants