Skip to content

[$200] Editor - supporting old and new formats #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Dec 23, 2020 · 6 comments
Closed

[$200] Editor - supporting old and new formats #308

jmgasper opened this issue Dec 23, 2020 · 6 comments

Comments

@jmgasper
Copy link
Collaborator

  • Rich content is not displayed properly if it is converted from rich to html and from html to markdown.
  • Rich content is stored in Quill format. So Quill can be converted to Markdown but it's necessary to implement a formatter.
  • Only plain text formatter and html formatter are implemented in Vanilla.

The solution would be enabling Rich Editor to support existing discussion/comment created previously.
Topocder editor should be used for new comments/discussions. But there are issues when both editors are enabled. I am trying to fix it now.

@jmgasper
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30159993 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30159993 has been updated - it has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

@jmgasper Please apply PRs:
#314
topcoder-platform/challenge-forum-processor#48
topcoder-platform/forums-topcoder-editor-plugin#3

Thanks!

Vanilla site

'Markdown' is used by default.
'Rich' format - Rich editor is used for existing discussions/comments created previously using Rich Editor.
'wysiwyg' format is supported. Discussions created by a challenge forum processor had this format. These discussions have plain text or simple html markup. Topcoder Editor is used for editing them, no issues with converting.
image

Challenge forum processor

template.json was updated. Markdown is used.
image

image

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30159993

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator

sdgun commented Dec 31, 2020

Verified

@jmgasper jmgasper added this to the January 2021 Release milestone Jan 11, 2021
@sdgun sdgun added QA Pass and removed QAverified labels Jan 11, 2021
@sdgun
Copy link
Collaborator

sdgun commented Jan 22, 2021

Unable to completely verify this in production, but tested quoting of the old comments and they worked fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants