Skip to content

[$100] The URLs in the discussion/comment are opening them in the same tab #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdgun opened this issue Nov 19, 2020 · 7 comments
Closed

Comments

@sdgun
Copy link
Collaborator

sdgun commented Nov 19, 2020

Steps
Go to any discussion which has a link (https://vanilla.topcoder-dev.com/discussion/1737/test-123/p1?new=1)
Click on the link or the image

It's opening it in the same tab, it will be useful if we can open them in a separate tab

@sdgun sdgun added the enhancement New feature or request label Nov 19, 2020
@jmgasper jmgasper changed the title The URLs in the discussion/comment are opening them in the same tab [$30] The URLs in the discussion/comment are opening them in the same tab Nov 29, 2020
@jmgasper
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30154457 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30154457 has been updated - it has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

@jmgasper Keep you updated:
Rich Editor is written using React and a part of core Vanilla library. The downloaded Vanilla distr is prebuild.
To fix this ticket:

  • install dependencies locally and build updated frontend.

So I am trying to build it locally from Vanilla src but it has issue with bower. Bower is installed locally.
image

@jmgasper jmgasper changed the title [$30] The URLs in the discussion/comment are opening them in the same tab [$100] The URLs in the discussion/comment are opening them in the same tab Nov 30, 2020
@atelomycterus
Copy link
Collaborator

@atelomycterus
Copy link
Collaborator

@jmgasper Please apply PR -#269. Thanks!
Added steps how build Vanilla assets - https://github.com/topcoder-platform/forums/blob/73f605629bdf69b5a83ec0972a808a93378e1b20/docs/BuildVanillaForums.md

Testing

Embedded resources (Image, URL, File) and html links (<a href='site'>go to</a>) should be opened in a new tab.

image

@jmgasper
Copy link
Collaborator

jmgasper commented Dec 5, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30154457

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator Author

sdgun commented Dec 7, 2020

Verified, Image, URL, and html links are opened in a new tab, but pdf files are still opening in the same tab.

Screencast 2020-12-07.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants