Skip to content

[$300] Differentiate between a challenge group and a regular group #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Nov 8, 2020 · 11 comments
Closed

[$300] Differentiate between a challenge group and a regular group #133

jmgasper opened this issue Nov 8, 2020 · 11 comments

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Nov 8, 2020

@atelomycterus - There's some user feedback we've gotten that the groups structure is a bit confusing for challenges vs. regular groups, especially since we're going to support the public round tables in the future, after the challenges are moved over.

What I think we should do:

  1. Separate out "Challenge" from "Groups", so we'd have two separate sections under https://vanilla.topcoder-dev.com/groups/mine. They would both be groups, but we'll display "Challenges" at the top and "Groups" at the bottom.
  2. Separate out "My Challenges" from "My Groups" on https://vanilla.topcoder-dev.com/groups
  3. All breadcrumbs for challenges should have Challenges in the breadcrumb
  4. All breadcrumbs for groups should have Groups in the breadcrumb

We'll need to support this in navigation (on the left nav, have separate Challenges and Groups), and in the REST API.

Screen_Shot_2020-11-09_at_08_21_54

@jmgasper
Copy link
Collaborator Author

jmgasper commented Nov 8, 2020

Contest https://www.topcoder.com/challenges/30149668 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

jmgasper commented Nov 8, 2020

Contest https://www.topcoder.com/challenges/30149668 has been updated - it has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

@jmgasper

Changes (I've implemented ):

  • Added an enum column (values:'challenge', 'regular') in Group table.
  • Existing data will be updated after altering the table. If a group has ChallengeID => a challenge group.
  • Updated a challenge processor + template.json
  • Updated Vanilla REST API

TODO:

  • Update add/edit group page
  • Testing

I'm going to push it tomorrow, including 'Add ability to archive a group' #136

image

image

image

@atelomycterus
Copy link
Collaborator

@jmgasper
Copy link
Collaborator Author

@atelomycterus - This looks good, but one issue - see below.

@sdgun - Please be aware of this change, thanks. I think it will make navigation easier on members, especially when we get to housing more stuff than just challenges (roundtables, etc...)

@atelomycterus - One problem is that the breadcrumb isn't showing Groups vs. Challenges. It seems to always be Challenges:

Screen_Shot_2020-11-20_at_08_53_26

@sdgun
Copy link
Collaborator

sdgun commented Nov 20, 2020

@atelomycterus In your above comment you have the below screen shot, how can we access this page?

image

@atelomycterus
Copy link
Collaborator

@sdgun The direct link is https://vanilla.topcoder-dev.com/groups/mine. What do you think maybe add the link to the left menu?

@sdgun
Copy link
Collaborator

sdgun commented Nov 20, 2020

@jmgasper I am not sure about above, but otherwise users do not have a way to access this

@atelomycterus
Copy link
Collaborator

@jmgasper Thanks for your feedback ! Fixed. Please apply PRs:
#220
topcoder-platform/forums-groups-plugin#28

@sdgun Please test it after deploying PRs.

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30149668

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator

sdgun commented Nov 23, 2020

Verified, the breadcrumbs show the challenges and groups and left nav has Challenges and Groups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants