Skip to content

[$50] The copilot, manager and admin cannot create new categories outside of the code and document questions categories in challenge forums #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdgun opened this issue Nov 5, 2020 · 12 comments

Comments

@sdgun
Copy link
Collaborator

sdgun commented Nov 5, 2020

Steps
Go to the forums as a copilot, manager or admin user (link - https://vanilla.topcoder-dev.com/)
Click New discussion
Check the hierarchy

Actual result
These users can only create a category in code questions and document questions, but cannot create a category in the same hierarchy as code question and code documents
In the drop New discussion page, in category drop down, the challenge name is disabled for selection, only code questions and code documents can be selected

Expected result
In the current forums, these users can do 'Create Forum' which creates the new category in the same hierarchy as code document and code questions

image

@sdgun sdgun added bug Something isn't working Dev env P1 labels Nov 5, 2020
@sdgun sdgun changed the title The copilot, manager and admin cannot create new categories in the challenge forums The copilot, manager and admin cannot create new categories outside of the code and document questions categories in challenge forums Nov 5, 2020
@jmgasper jmgasper changed the title The copilot, manager and admin cannot create new categories outside of the code and document questions categories in challenge forums [$50] The copilot, manager and admin cannot create new categories outside of the code and document questions categories in challenge forums Nov 5, 2020
@jmgasper
Copy link
Collaborator

jmgasper commented Nov 5, 2020

Contest https://www.topcoder.com/challenges/30149000 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

jmgasper commented Nov 5, 2020

Contest https://www.topcoder.com/challenges/30149000 has been updated - it has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator

jmgasper commented Nov 5, 2020

@atelomycterus - Do I need to tweak the permissions here?

@atelomycterus
Copy link
Collaborator

@jmgasper Category can be created by Vanilla Administrator in Admin site .
I can add a link ('add a category') to meet this requirement. The link will be visible for the topcoder roles :

Go to the forums as a copilot, manager or admin user (link - https://vanilla.topcoder-dev.com/)

We've added 'copilot' in a group (See #88).
Should we add 'manager' in a group?

By admin user you mean a user with the 'Connect Admin' role?

@jmgasper
Copy link
Collaborator

jmgasper commented Nov 5, 2020

  1. Yes, let's add manager in a group
  2. No, we'll leave Connect Admin as-is for now

@atelomycterus
Copy link
Collaborator

atelomycterus commented Nov 6, 2020

@jmgasper Fixed PR - topcoder-platform/challenge-forum-processor#38.
All members with 'manager' added by a challenge processor.

Add/Edit Category pages in Admin site only. We need to create a category from Vanilla site. TODO:

  • a basic page/popup (category name field) to create a category.
  • add a link +permissions

@atelomycterus
Copy link
Collaborator

atelomycterus commented Nov 6, 2020

@jmgasper Adding a category from Vanilla site:
Please apply PR- topcoder-platform/forums-groups-plugin#17
#130
Thanks!

I haven't set 'Ready to Review' for this ticket. Please see 'Questions'. I want to be sure that I've used correct roles in a group plugin.

Testing

Disable/Enable Groups plugin to add permissions and update roles in DB

Questions

We have a lot of roles. It is necessary to clarify the Topcoder roles will be used to check certain permissions in Vanilla.
I'm confused about 'Connect Admin' vs 'administrator', 'Connect Copilot' vs 'copilot'.
Which roles are global? Which ones are related to projects/challenges?
Please could you explain what roles should be used or provide any docs?

image

Changes

Added a new permission 'Groups.Category.Manage'. So we can configure roles with permission, no hard-coded role names in code.
image

Added a category link in group options:
image

Added a category popup:
image

Categories are created:
image

One thing which is not user friendly. Urlcode is generated from 'Name' and unique in DB. So it might be confusing if User tries to add a category with the same name:
image

@jmgasper
Copy link
Collaborator

jmgasper commented Nov 7, 2020

We have a lot of roles. It is necessary to clarify the Topcoder roles will be used to check certain permissions in Vanilla.
I'm confused about 'Connect Admin' vs 'administrator', 'Connect Copilot' vs 'copilot'.
Which roles are global? Which ones are related to projects/challenges?
Please could you explain what roles should be used or provide any docs?

@atelomycterus - I have similar questions out to Topcoder. No one really seems to know how the roles are setup and how they're used. I'll mark this as complete and we'll wait on TC to provide more details if we need tohanges things further, thanks.

@atelomycterus
Copy link
Collaborator

atelomycterus commented Nov 7, 2020

@jmgasper
Copy link
Collaborator

jmgasper commented Nov 7, 2020

@atelomycterus - Great, thanks! I'll bookmark that for myself :)

@sdgun
Copy link
Collaborator Author

sdgun commented Nov 9, 2020

@jmgasper The Add category(and also follow category) are available when user goes to Code documents >> challenge overview >> click on the forum.

image

But the page we are taking the user when clicking Challenge discussion link in the challenge details page is the below, it would have been pretty useful to the user if we show the Add category and follow category options on the below page or in both places:

image

Verified creating categories from copilot, manager and connect admin.

@jmgasper
Copy link
Collaborator

jmgasper commented Nov 9, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30149000

This is an automated message for ghostar via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants