[$100] When an image is pasted in the editor window by a normal user, the error ribbon is shown in the editor

[sdgun]

Steps
Go to the forums as a normal user (ex user- TopConnCustomer link - https://vanilla.topcoder-dev.com/)
Click New Discussion
Paste an image in the editor

Actual result
The error ribbon is shown in the editor

Expected result
The error ribbon should not be shown in the editor

File attach error.zip

[jmgasper]

Contest https://www.topcoder.com/challenges/30148426 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

[jmgasper]

Contest https://www.topcoder.com/challenges/30148426 has been updated - it has been assigned to obog.

This is an automated message for ghostar via Topcoder X

[jmgasper]

@atelomycterus - I'm open to suggestions on this one.

[atelomycterus]

@jmgasper 'Allow File Uploads' Vanilla permission is used for any files (attachments/images).
Each category has 'Allow File Uploads' and users are not allowed to upload any files by default.

We've implemented Roles setup for attachments (#60):

We'll also need to set up some defaults, for instance:
Regular members will not be able to attach files to posts
Copilots will be able to attach files to posts

So all files from an editor are uploaded via Vanilla REST API (/v2/media). If user is allowed to upload images then we need to fix \Vanilla\package\applications\dashboard\controllers\api\MediaApiController. At least check for image file types.

So let me know if regular members (Vanilla member role) are allowed to upload images for any category or a specific category.

[jmgasper]

@atelomycterus - Regular members will not be allowed to upload images at all, for any category (at least at this current time).

@rootelement ☝️ Correct me if I'm wrong.

[rootelement]

Correct

[jmgasper]

@atelomycterus - If you need anything else here, let me know, thanks!

[atelomycterus]

@jmgasper I wanted to reproduce this issue in DEV but I noticed that posting format is text. Rich Editor has a simple view in DEV. If post format is text then user can't upload images/attachments. Let me know if we are going to use Rich format. I'll update FormatInput in config.php.

[jmgasper]

@atelomycterus - Not sure what happened there. I just turned the rich editor off and on again and it appears to be working now.

[atelomycterus]

@jmgasper We've already tweaked permissions for copliot and regular members. All works as expected.

@atelomycterus - Regular members will not be allowed to upload images at all, for any category (at least at this current time).

Regular members can't upload any files including images. I've signed in as a regular member, The file/image buttons are not displayed because I don't have permissions to upload files. I've tested it for discussions and comments.
If I drag and drop a file into the editor, then it tries to upload it to the server. The permissions are checked on the server before saving a file. I (regular member) don't have permission to upload files. 403 Error - no permissions.
If this error message confuses users, then we can return a more specific message for this case ('No permissions to upload files.')
Let me know if I should fix a message.

File/image button is not displayed if User doesn't have upload permissions:

Drag and drop a file without Upload permissions:

2. Rich editor config: 'Markdown' was in the config ([$25] Investigate deploy issue #236)
   If RichEditor doesn't support format then Text is set by default. I saw a simple Rich Editor View in sdgun's video.
   At first I thought that maybe this new requirement from the Topсoder team. That is why I asked you about the format.
   I've updated a config file. 'Rich' is default format.

[jmgasper]

@atelomycterus - Yeah, I think if we can just say something like You don't have permission to upload files, that would be good. Sorry about the format problem - that was my fault. Thanks for fixing that.

[atelomycterus]

@jmgasper PR-#266 - update a message in the Rest API. Unfortunately, need to fix and rebuild frontend because the editor displays the hard-coded error message. We have several frontend issues. I'm going to fix them tomorrow.

[atelomycterus]

@jmgasper Ready for review. Please apply PR-#269. Thanks!

Testing

Clear browser cache before testing.

[jmgasper]

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30148426

This is an automated message for ghostar via Topcoder X

[sdgun]

Verified. After clearing cache, the given message is shown when drag and drop files. Pasting is disabled. However it seems like the file is being attached first and then the error is displayed.

Screencast 2020-12-07.zip