-
Notifications
You must be signed in to change notification settings - Fork 0
[$250] Deployment Docker #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Contest https://www.topcoder.com/challenges/30122181 has been created for this ticket. |
Contest https://www.topcoder.com/challenges/30122181 has been updated - it has been assigned to obog. |
@jmgasper What default plugins should be enabled by default? |
|
@jmgasper Done. It's ready for your review. I think I should create a PR , not push it immediately. Sorry about that.
|
@jmgasper Oauth2 SSO don't have default settings. Enabling without settings doesn't make sense. |
@jmgasper Implemented. Please apply PR (#7).
Thanks! P.S. Known issue: if you enter a wrong email, click on "continue". Vanilla Installer displays an invalid email. After, fixing it, Vanilla Installer doesn't work. So with a docker we need to execute |
@atelomycterus - For the OAuth SSO, if we provide some details, can we use those details to auto-populate the database directly to try to work around the issue above? |
@jmgasper Vanilla Forums Installer generates config.php from config-defaults.php during installation. All settings (connection db, plugins, and so on) are saved in config.php.
A file named |
@jmgasper bootstrap.early works for any plugins which keep all settings in config.php.
OAuth2 SSO All authentication providers save some parameters in the table 'UserAuthenticationProvider'. |
@jmgasper Implemented. Please apply PR. I couldn't check OAuth2 SSO Topcoder locally because I got "Callback URL mismatch.The provided redirect_uri is not in the list of allowed callback URLs.". So I tested with ngrok and configured google OAuth settings The Vanilla url 'https://<vanilla_host>/entry/oauth2' should be added in Authorised redirect URIs. What host should be used in /etc/hosts to get response from topcoder-dev.com? I tried topcoder-dev.com, dev.topcoder.com but it didn't work for me. |
@atelomycterus - I think vanilla.topcoder-dev.com should work, but if not let me know. |
@jmgasper Yes, it works without any issues if it's deployed on vanilla.topcoder-dev.com and vanilla.topcoder-dev.com is added in Authorized redirect URIs. |
@atelomycterus - I think that's fine. Normally, for other Topcoder services, we ask folks to add a local redirect to their hosts file for the targeted URL. |
@atelomycterus - One question: Can we move things from the Things like:
The secret and attributes especially need to be moved because we can't keep those values in Git. |
@jmgasper Yes, I've checked Vanilla code, we can implement
If this is false then only the in-memory config is set. Importanta Notes: After an admin makes a change in the dashboard, Vanilla will rewrite After installation db settings as plaint text in config.php.
I'll add these params as env params in a docker-compose file |
@atelomycterus - Yeah, we'll need to set those additional values from the environment those as well, thanks. I'm not too worried about having them in plaintext on the server, but I don't want them in plaintext in Git. |
@jmgasper Fixed. Please apply PR. I'll send mysql.env and vanilla.env with values by email. Thanks! |
Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30122181 |
Create a docker file to:
The text was updated successfully, but these errors were encountered: