Skip to content

[$150] Investigate notification links to profiles #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Apr 13, 2020 · 5 comments · Fixed by topcoder-platform/forums#9
Closed

[$150] Investigate notification links to profiles #6

jmgasper opened this issue Apr 13, 2020 · 5 comments · Fixed by topcoder-platform/forums#9

Comments

@jmgasper
Copy link
Collaborator

As discussed previously:

@jmgasper Some notes why some links are displayed with default styles:
notifications

I dig into Vanilla source code and see why it happens. Vanilla provides core functions ("/library/core/functions.*.php"). All functions from functions.render.php can be overriden into plugins.
Some parts of controls/views/pages are formatted with the functions declared into functions.general.php which can't be overridden at all.

Vanilla keeps activity details in the activity table with html markups:
activity_data-1

These phrases can be changed:
activity_type-1

Vanilla uses smarty templates to format these values using static functions declared functions.general.php.
e.g. "{ActivityUserID, user}" will be replaced with <a href="/profile/username" >Username</a>.

After loading activity data from database it is formatted, the first event is fired but we get rendered data in the plugin:
2020-04-12 1rendered

So we need to find a workaround if we want to change css styles(e.g. set ratings css style) or build markup dynamically. The custom formatter will be used instead of the static function 'formatString' from functions.general.php. I think it should be loaded in bootstrap. So need to investigate it if it's possible to implement.

@jmgasper
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30122180 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30122180 has been updated - it has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

atelomycterus commented Apr 14, 2020

@jmgasper Fixed. Need to apply 2 PRs:
topcoder-platform/forums#9
#7

Notifications:
notif-list

Activities:
image

Thanks!

@jmgasper
Copy link
Collaborator Author

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30122180

This is an automated message for ghostar via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants